From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC36B40BE0 for ; Fri, 24 Jan 2025 13:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737726690; cv=none; b=Fzp3/GpMbbY7cKU79BANRTVQMK4gExLKK8pPPPs+FlORzaQXlouTUIUzGmsjZ5CnjVeVkUsWzZ3tVvEJ5hP1kNLgWiIMGAlUdOKFJPxjlLDQPyqTyV+/aK4iOayQ9x5Ff02yj9niCNuIgrIXn/tfXKdpAUKdBConW8UgQ6yd+bo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737726690; c=relaxed/simple; bh=pJFaFR/cdHX84EYRD0FIV+VAe/KBfCM9byCxxPK0kf8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MBxRyfLqnDDEBpnS5S/mrSssovbBJCvBUckNUla4ZVVMbEg8LdUzjR5XiqkURb1mey7NA7umxK3ICGw/5foPrKYVQ4+/XbZlcmbc6/pmHHV3DGByoRv4ISlfaHxZ+Y9REREyPqnKGz0X9os1CSYZTQbVGSOvf6pMIe6JU4SizvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IJYkyAmf; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IJYkyAmf" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43690d4605dso14481765e9.0 for ; Fri, 24 Jan 2025 05:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737726686; x=1738331486; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zKRrbe6gGWiSaBV4mplOTEhtmjTYcRZx77kHNzgfO9s=; b=IJYkyAmfIOiE8BDleNLE7IuupEbjUaO3d7eMIuH17vzbYi3DzG2/jDB9fGulbvKSNn 8EGMglPQmfyRSug3vpU3Zt5cxO06zUAyTUU5UBjcTSpzOYnEaWeYujq2YxMcfO2LHfim KsOaUTsa0A/VzQkAd5uNIjPSn3UH5yaMbq2f+FW20Bgdk+bAQaplhjMrFZtHlw2sNemm pcbmVs/eFT59/tfD5PutgQ9mzIrVnIqkkry2g54vVddN5bl2lCGxONz3zKGDolpZ7+bA lD5y0TfANsUFryE3XkWL+/eKBhyYqYIJeLlx491ccC/brBABnSNQs9VTQYqmtTTEw29+ 0jgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737726686; x=1738331486; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zKRrbe6gGWiSaBV4mplOTEhtmjTYcRZx77kHNzgfO9s=; b=Nesc2VQ35t3j/TA77FZ0LNfJMzsIpMOf897k8Omv9ynh8mMMd6xZWyW4yPEwTL08zz KOPJ1j6h70ChiBojXVlqCEZxYITtXh9EnBXjcZay3kCg98o3T+wZywLvIdwy22alwQoG TUeaObtY2/R6TUFYfE57vs0KDa1r+Mw/4equrIciBqazbleQoXOz12JMYqnDS3qmXQAn RNQblfsnXiyOZClw6iN0zSyqK/9mG3l0oGxtwcVNDVwZ/RDQG0SpfDT8qQBFDO8Ebt9h E4c6ajNRvQb+tHWKW8BvvMij6biajUqut0WooogoN6t91lG+4m06jvqotmG4jUKsnuMg nAEg== X-Forwarded-Encrypted: i=1; AJvYcCVTj3zJkBJvE9qtVWsRsmb3VP9q7pFWdiNjGT0BAQZppCuTZBmohmk0KQx6AwyCJbAk7DKVTGynIoMmCIo=@vger.kernel.org X-Gm-Message-State: AOJu0YwTgDiJCHZP9FAUfe7mP7/UtR2cz47yRgisCwrjSgl9kiMzk2ev 7wUqY8uI+dnQ/749yEkG3ZK2MotKzFp9vy3MnbUZ4T/zXsTlmkrymFi03PXYGJQ= X-Gm-Gg: ASbGncsVDpvxFMWxS27q5/R4+Mdl9gMf8bAY1rIOj383NJrLsFfqg4WdcH9eg7CavVS rPzWr/s9Xgv0WYekoAMuv6Cp78CQSmpNJjwhZNUEs2y6xMYD9+Ib1xoexRMlw+0pClu6Q0EmEgr mHZAU368yCXeP4osHyoE49oClcOsMacDNPizqlXKxJoufTGb8uThXflSADoxuqhbD405EggcbX3 n+//XtdNrL+tTMtXJj3XDY8hoyTDTRTVUo/LYUwtkGzY14ijNR4sJjhgoXcbFYlJerWvTFaW9RT iX3ZY95NGA== X-Google-Smtp-Source: AGHT+IETFMJJrZWr/EDBakUelIAVIlOvrzgYZmGp+ZA18dqs2i5tih8sUMHw8uH4sD7esRtqKjCpXw== X-Received: by 2002:a05:600c:3585:b0:434:f297:8e85 with SMTP id 5b1f17b1804b1-438913d5da1mr323417065e9.10.1737726686177; Fri, 24 Jan 2025 05:51:26 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd485007sm27717805e9.12.2025.01.24.05.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 05:51:25 -0800 (PST) Date: Fri, 24 Jan 2025 16:51:22 +0300 From: Dan Carpenter To: "Peng Fan (OSS)" Cc: Michael Turquette , Stephen Boyd , Russell King , Sudeep Holla , Cristian Marussi , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Dario Binacchi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, Peng Fan Subject: Re: [PATCH 1/3] clk: Introduce clk_set_spread_spectrum Message-ID: References: <20250124-clk-ssc-v1-0-2d39f6baf2af@nxp.com> <20250124-clk-ssc-v1-1-2d39f6baf2af@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124-clk-ssc-v1-1-2d39f6baf2af@nxp.com> On Fri, Jan 24, 2025 at 10:25:17PM +0800, Peng Fan (OSS) wrote: > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index cf7720b9172ff223d86227aad144e15375ddfd86..a4fe4a60f839244b736e3c2751eeb38dc4577b1f 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -2790,6 +2790,45 @@ int clk_set_max_rate(struct clk *clk, unsigned long rate) > } > EXPORT_SYMBOL_GPL(clk_set_max_rate); > > +int clk_set_spread_spectrum(struct clk *clk, unsigned int modfreq, > + unsigned int spreadpercent, unsigned int method, > + bool enable) > +{ > + struct clk_spread_spectrum clk_ss; > + struct clk_core *core; > + int ret = 0; > + > + if (!clk || !clk->core) > + return 0; > + > + clk_ss.modfreq = modfreq; > + clk_ss.spreadpercent = spreadpercent; > + clk_ss.method = method; > + clk_ss.enable = enable; > + > + clk_prepare_lock(); > + > + core = clk->core; > + > + if (core->prepare_count) { > + ret = -EBUSY; > + goto fail; fail is too vague to be useful as a name. Also this should be goto unlock; > + } > + > + ret = clk_pm_runtime_get(core); > + if (ret) > + goto fail; > + > + if (core->ops->set_spread_spectrum) > + ret = core->ops->set_spread_spectrum(core->hw, &clk_ss); > + > + clk_pm_runtime_put(core); unlock: > + clk_prepare_unlock(); > +fail: > + return ret; > +} regards, dan carpenter