From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1282AC433F5 for ; Mon, 7 Feb 2022 16:02:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245533AbiBGQAG (ORCPT ); Mon, 7 Feb 2022 11:00:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377051AbiBGP5A (ORCPT ); Mon, 7 Feb 2022 10:57:00 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF3DC0401CE for ; Mon, 7 Feb 2022 07:56:59 -0800 (PST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id AEEAD4003C for ; Mon, 7 Feb 2022 15:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644249418; bh=3KCJtIIAHid1u1Ypwj6pcJ1BKiFWLA7ETi2tEpWd/KM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d3zYrg8/QwD5CAPs29nqw1oSk42TU4EDHDXDvbIJfOkP3OHO0KGY5Ay4x3iBxtmhR bo0lvQiVA1GRvjqzCWdEk5l5ggl53NysepRAOzq60aEQJ4h4k8QmE9XsvYz/zNlprS alcWO5kK9g+EJ67kQvqcffhUV6djdDrCveI5+4F7qLGqx5y0mEUFxqap3rhajbuuRK Q/7hp5dwu7dPnL8NbT2mMCYj8UgAOk6pbeI9vluwK0geu2zGIlDNyr6vHBiSCPC8dI fchcJ8zu5gC2jXXv7U67H5/qq9CGhQuoelrVJ07dEFL/Qzx8YDk86O9mx5gMnDY+XS RYsNGfgCHR8/A== Received: by mail-ej1-f72.google.com with SMTP id la22-20020a170907781600b006a7884de505so4490034ejc.7 for ; Mon, 07 Feb 2022 07:56:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3KCJtIIAHid1u1Ypwj6pcJ1BKiFWLA7ETi2tEpWd/KM=; b=fINWqeB95gv1Pt/b9iCc8Kx/ndhDz1F6MmDPNs2BsIZdiJLjorPVWfGSqKqhajkLwZ Q4cGb8PvBwV7r+hXrHZd01Q9g4WPqWO73Y2lBkTKjJ+PvyIvwkllKujW8pCQozf2F8Tx pTnVn6kVI6QqBseG9xBUZkR4kYKzLekq/QkPJDJIn9m6lWkgojOivifhGTpSxQxJ8HPm PTYEVgSfFhlfba7OGXxtcf1Y/HrYdXLFGgjQAEvVVlY51L2V+/Qq0XQfYR6jPjIhbV2U T14MSmXBTSJB/MMOCvarwUmsk5V5+2vdTuPNPRroN3TS7fq8r/Bxi0Reo/5yyQoj8ho+ +3jQ== X-Gm-Message-State: AOAM532setZHP8kuVdT1+FDTeixqbAMSDA/BrqyZDqh8amzil+Ot/kHS a19c0Hn93RQ6nFejg2nGVDBHXQsHfSqxWjs6JIjY8F4OvSu++fOfXFtxUg/azAKDMCx70Cw1D6s aYXob106Hr8dUIxk/ey5yZik5owpnq5mK0FIOaWBLUw== X-Received: by 2002:a17:907:ca6:: with SMTP id gi38mr290863ejc.353.1644249418354; Mon, 07 Feb 2022 07:56:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNtGmRyRii7O51uydqBLa9NhyKzrDOTW8Z28l8gq9kBDum2SUHT7YCiJHTkDya3nBusEaO7g== X-Received: by 2002:a17:907:ca6:: with SMTP id gi38mr290850ejc.353.1644249418176; Mon, 07 Feb 2022 07:56:58 -0800 (PST) Received: from [192.168.0.90] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id v19sm3356879edw.39.2022.02.07.07.56.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 07:56:57 -0800 (PST) Message-ID: Date: Mon, 7 Feb 2022 16:56:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/3] dt-bindings: crypto: Convert Atmel AES to yaml Content-Language: en-US To: Tudor Ambarus , herbert@gondor.apana.org.au, robh+dt@kernel.org Cc: davem@davemloft.net, nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, alexandre.belloni@bootlin.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220207032405.70733-1-tudor.ambarus@microchip.com> <20220207032405.70733-2-tudor.ambarus@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220207032405.70733-2-tudor.ambarus@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2022 04:24, Tudor Ambarus wrote: > Convert Atmel AES documentation to yaml format. With the conversion the > clock and clock-names properties are made mandatory. The driver returns > -EINVAL if "aes_clk" is not found, reflect that in the bindings and make > the clock and clock-names properties mandatory. Update the example to > better describe how one should define the dt node. > > Signed-off-by: Tudor Ambarus > --- > .../devicetree/bindings/crypto/atmel,aes.yaml | 65 +++++++++++++++++++ > .../bindings/crypto/atmel-crypto.txt | 20 ------ > 2 files changed, 65 insertions(+), 20 deletions(-) > create mode 100644 Documentation/devicetree/bindings/crypto/atmel,aes.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/atmel,aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,aes.yaml > new file mode 100644 > index 000000000000..f77ec04dbabe > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/atmel,aes.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/atmel,aes.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel Advanced Encryption Standard (AES) HW cryptographic accelerator > + > +maintainers: > + - Tudor Ambarus > + > +properties: > + compatible: > + const: atmel,at91sam9g46-aes > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: aes_clk > + > + dmas: > + items: > + - description: TX DMA Channel > + - description: RX DMA Channel > + > + dma-names: > + items: > + - const: tx > + - const: rx > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - dmas > + - dma-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include One empty line for readability. > + aes: aes@f8038000 { Generic node name, so "crypto". > + compatible = "atmel,at91sam9g46-aes"; > + reg = <0xe1810000 0x100>; > + interrupts = ; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 27>; > + clock-names = "aes_clk"; > + dmas = <&dma0 AT91_XDMAC_DT_PERID(1)>, > + <&dma0 AT91_XDMAC_DT_PERID(2)>; > + dma-names = "tx", "rx"; > + status= "okay"; > + }; Drop the status property. Best regards, Krzysztof