From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932402AbcH2UxY (ORCPT ); Mon, 29 Aug 2016 16:53:24 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50209 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932186AbcH2UxX (ORCPT ); Mon, 29 Aug 2016 16:53:23 -0400 Subject: Re: [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails To: Quorum Laval References: <1472222440-4736-1-git-send-email-quorum.laval@gmail.com> Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Dave Kleikamp Message-ID: Date: Mon, 29 Aug 2016 15:53:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472222440-4736-1-git-send-email-quorum.laval@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2016 09:40 AM, Quorum Laval wrote: > filemap_fdatawait/filemap_write_and_wait may fail, so check the return > value and jump to error_out in the case of error. > > Signed-off-by: Quorum Laval This looks good. I'll push it upstream. Thanks, Dave > --- > fs/jfs/resize.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c > index 90b3bc2..bd9b641 100644 > --- a/fs/jfs/resize.c > +++ b/fs/jfs/resize.c > @@ -379,8 +379,14 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize) > * cached in meta-data cache, and not written out > * by txCommit(); > */ > - filemap_fdatawait(ipbmap->i_mapping); > - filemap_write_and_wait(ipbmap->i_mapping); > + rc = filemap_fdatawait(ipbmap->i_mapping); > + if (rc) > + goto error_out; > + > + rc = filemap_write_and_wait(ipbmap->i_mapping); > + if (rc) > + goto error_out; > + > diWriteSpecial(ipbmap, 0); > > newPage = nPages; /* first new page number */ >