From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1BFE19E806 for ; Sat, 21 Jun 2025 10:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750500669; cv=none; b=lOarU2WZRMJHB1xmU6lyN1zSLNCrCuSTZngq0rdWiA0yBm74Rv4edzdiLUtPgXsu8X/HcfmOykqJHJC/HSuj2YHlIghdlqLyemK3WPr3vZqZvw+itMz1cpeXSzfUA5JRHnbo9iGmbvpxV4fZTuZaGtyxr76v4KBjdRZDYmuhbTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750500669; c=relaxed/simple; bh=CZZT3WEEDV87AgzVeppysTU0hqzypFYvVqQ6fABNIxA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BEMd/CFfpJEPiDM4WjsbM1DQ0rqcktJaXwqTdIlmPuIIAuWbInSeDh35UHENdltRvhnepAxWLUxIz/FR6WM1wypXWLd9m1AEpDp8Jx65vWWSlgQRFSmyyowgmVabkxom3Tjj0BEaFALr6M/DpVwkyxeZlO1PhsjmuUVDIRtbaiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cfUG2dFE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cfUG2dFE" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55L4FQtQ014647 for ; Sat, 21 Jun 2025 10:11:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Orq6xVb2NKaaLqSDAmeRwX94lHqJJdwkdgnmCDoC3WE=; b=cfUG2dFE/RicYKGs Vc/QrdzjZphcahHjfuSO2/TQildoS4dWYV3saCC7BMGYEQNmMU3uVYJjPzMV06+N PcmjPc4EZmFPiN18cPMjuDuP6XauQtmICkxqXNio6moUV/LFCBDHFaarsHLCFyeW s+4jjVEdrB/Lilb2qfiUy8FfhigyhX6yuuF6HyizuNX5nWsFidMImN7G7u0YD2kD RwP2sBkg7aQvSeQozvw8aR99P6mebg/WkvS600z1bP63iNl9tXFkSJfFJ/2WPnrN 2P2a1cX/uMeFwxNy6MQ4GhIUelA3FVaQ8Idee4UiTxuMRCSfyDL+TW/s2knXJChw sj8ruw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47dn488ekx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 21 Jun 2025 10:11:06 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fd1dcf1c5bso516536d6.3 for ; Sat, 21 Jun 2025 03:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750500666; x=1751105466; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Orq6xVb2NKaaLqSDAmeRwX94lHqJJdwkdgnmCDoC3WE=; b=jHepSu11lA5xPzqEriYRQasuaSKY3KCB+gz9RpiEIMa9bhBjd626uLIgG4hJU1TO0t k3XKcD3Op39fHqfyaYWjXQqajFpLl4vt4yhxRYKNduCulaRFNfBBWipBEpFNfDfKqoHX U0x8Rp8lDUYp9LLvkbHuVq4phsOHo2OiTlB/orA9ZEsnz0/EYxHbAzYgscgIwRLmWHoF htqmlMdFzBRKLjcl8Ejw9zhZ5IZ7+6/pH3G52o/L56neaTRydFvCVDsRNPpsZC+Hw7gi WcVarFgvxtlKNFzSoqyl7wqJ928OSW2kPjYoArCdUqM1XQc/GUd0N/+C6Xr4lllo0kXE 0Wmg== X-Forwarded-Encrypted: i=1; AJvYcCUXObOVS9KeIeMGjt23hdWWKElx7EqVVMlJyD5yAFHW3dXeaE1bwiIvny6xDzZ24aISibQnmvEcESnyvhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/S6btStGe1jRXvH3d9CjkVDSFrBaFQ6zBxBdFw0ZwtVqD53Bq 0Gmd7SCcDJ0KoHLyYdyklneIBRmLmOTu7B0PrB5rrhK4JVTAkw3xqmdwubYi3Y3ciotLgy07VeJ aHbhOG1nhwHBxAHX17ZtScBQSNRsPuJXi9OtqIpTpZNWV4zD3dCL77Ia1V6W0yY9KRTk= X-Gm-Gg: ASbGncvahN/nndZ2O23UUaTw4Fs/SKlvSFBaDz+/U2/I7IN6q7HPpl9EdCoPElZSzRQ 2/BhmccV9oqe/qvjtYD8mxETuI8o2mIOXKbirplL9JPuCpq55EgqWWAM4AsGF4YJA62X+iWvDtz TVihTQX3RxHEfZquxaWIdycGyY8tR9PzMwA9OuQWra+vBRWpKdxbPGldpqJY0qpmtxZ0wSLldg+ CETvQWljQ4W/+dADRIv1kgdW1DdSHMYVV+TxCwquYUSnLhweQJZxOvnxR78iCJ8gMetHiejxN1h 4IkmtYpBjOH7v0gfbowp4upemjfcCoAPG2DoVMqAaMQR0x3oJy3/fh7iUQKmPQ5ZUGfxxOECPsS vbsA= X-Received: by 2002:a05:620a:2981:b0:7d3:b0a3:6aa7 with SMTP id af79cd13be357-7d3f98b41f2mr366507585a.3.1750500665798; Sat, 21 Jun 2025 03:11:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFI5hLRnCZ0sPSXDM3AR91gKrHB4k2pwB/s4SqmDLL498a11aGnE/v060gc2/bExJIzuAgw5Q== X-Received: by 2002:a05:620a:2981:b0:7d3:b0a3:6aa7 with SMTP id af79cd13be357-7d3f98b41f2mr366506185a.3.1750500665404; Sat, 21 Jun 2025 03:11:05 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae05408300dsm339519466b.95.2025.06.21.03.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Jun 2025 03:11:04 -0700 (PDT) Message-ID: Date: Sat, 21 Jun 2025 12:11:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+ To: Luca Weiss , cristian_ci , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "andersson@kernel.org" , "konradybcio@kernel.org" Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "~postmarketos/upstreaming@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht>, "phone-devel@vger.kernel.org" References: <20250620-rimob-initial-devicetree-v1-0-8e667ea21f82@protonmail.com> <20250620-rimob-initial-devicetree-v1-3-8e667ea21f82@protonmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: wGVZwtHEbwjhjMh17P4HIKmhcYgiwoUy X-Proofpoint-ORIG-GUID: wGVZwtHEbwjhjMh17P4HIKmhcYgiwoUy X-Authority-Analysis: v=2.4 cv=OZGYDgTY c=1 sm=1 tr=0 ts=6856853a cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=dlmhaOwlAAAA:8 a=1bQLa7EovWpukNELjvkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=y4cfut4LVr_MrANMpYTh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIxMDA1OSBTYWx0ZWRfXyFz06VVTaqbu e0fhG/5b3gffHjRZ4JzDU+y8pgmghe+DiE/Rfj+21i1sqaQFpje6efvNFoAkkxUBYSqoR7xE3Bb hCap2DkmQDx3d+NzcTMQ6WDVyL8Z2n4LMafaTfjLnCAUxmRhJH2dJVSfEggGnkUDy+aJf/lAiIU nRk7p5Lsw5tgw3EEuMfqOkNBuQtcllcprodxZ2LwWLEnXODh8DVS8SdVDmWAh521arCnSdefhYe AZZLxQqL+MQAWATz8Fs5kiPot1N7Oxa9E0agf8TiUHkktKCD1JuBtoIKGMvJtf09pTkl/PHWtJ/ O6/Z1jmht/MO4xoZSM2BZavCMES7v3a4KhzTeb4SgXKNicnMZicYZoUiSrhRywc2rC5evrPEQHr Di83I/a1frO+XRja6yf2oq9oZHozGC/mZz9AhhdTHP1bOyQ6MtitWM6RK0RVj8sCD7VxGyUS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-21_02,2025-06-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506210059 On 6/21/25 11:27 AM, Luca Weiss wrote: > On 21-06-2025 9:07 a.m., cristian_ci wrote: >> On Saturday, June 21st, 2025 at 00:20, Luca Weiss wrote: >> >>>> + >>>> + reserved-memory { >>>> + qseecom@0 { >>> >>> >>> qseecom@84a00000 ? >>> >>>> + reg = <0x00 0x84a00000 0x00 0x1900000>; >>>> + no-map; >>>> + }; >> >> Looking at downstream devicetree, every reserved-memory nodes with "removed-dma-pool" compatible has unit address 0. OTOH, kernel documentation [1] says: >> "  Following the generic-names recommended practice, node names should >>    reflect the purpose of the node (ie. "framebuffer" or "dma-pool"). >>    Unit address (@
) should be appended to the name if the node >>    is a static allocation." >> >> In my case, downstream devicetree shows: >> >>         other_ext_region@0 { >>             compatible = "removed-dma-pool"; >>             no-map; >>             reg = <0x00 0x84a00000 0x00 0x1e00000>; >>         }; >> >> which will be 'qseecom' reserved-memory node in mainline devicetree. >> >> OTOH, 'qseecom' node in downstream devicetree also shows: >> >>         qseecom@84a00000 { >>             compatible = "qcom,qseecom"; >>             reg = <0x84a00000 0x1900000>; >>                          ... >> >> If you confirm what you suggest, 'qseecom' reserved-memory node will look like the following: >> >>         qseecom_mem: qseecom@84a00000 { >>             reg = <0x0 0x84a00000 0x0 0x1900000>; >>             no-map; >>         }; >> >> [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > > The name (qseecom@84a00000) mostly does not matter at runtime, it's just a nice label we give it. The reg is the important bit that gets used in reserved-memory. > > But actually re-checking, I don't think your reserved-memory works right now, msm8953.dtsi has > >     soc: soc@0 { >         #address-cells = <1>; >         #size-cells = <1>; > > which means that you should only have one value for address, and one for size, so "reg = <0x84a00000 0x1900000>;". This is different to most other Qualcomm arm64 SoCs. reserved-memory { #address-cells = <2>; #size-cells = <2>; ranges; Konrad