From: Kim Phillips <kim.phillips@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Ingo Molnar" <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
"Janakarajan Natarajan" <Janakarajan.Natarajan@amd.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Stephane Eranian" <eranian@google.com>,
"Martin Liška" <mliska@suse.cz>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Borislav Petkov" <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH 2/2] perf/x86/amd: Add support for Large Increment per Cycle Events
Date: Fri, 10 Jan 2020 10:22:10 -0600 [thread overview]
Message-ID: <f83eacb7-6346-6823-6429-27ee1d44f2df@amd.com> (raw)
In-Reply-To: <20200110150958.GP2844@hirez.programming.kicks-ass.net>
On 1/10/20 9:09 AM, Peter Zijlstra wrote:
> On Wed, Jan 08, 2020 at 04:26:47PM -0600, Kim Phillips wrote:
>> On 12/20/19 6:09 AM, Peter Zijlstra wrote:
>>> On Thu, Nov 14, 2019 at 12:37:20PM -0600, Kim Phillips wrote:
>> One problem I see with your change in the "not already used" fastpath
>> area, is that the new mask variable gets updated with position 'i'
>> regardless of any previous Large Increment event assignments.
>
> Urgh, I completely messed that up. Find the below delta (I'll push out a
> new version to queue.git as well).
OK, I tested what you pushed on your perf/amd branch, and it passes all my tests.
BTW, a large part of the commit message went missing, hopefully it'll be brought back before being pushed further upstream?
Thank you,
Kim
next prev parent reply other threads:[~2020-01-10 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 18:37 [PATCH 0/2] " Kim Phillips
2019-11-14 18:37 ` [PATCH 1/2] perf/x86/amd: Constrain Large Increment per Cycle events Kim Phillips
2020-01-17 10:08 ` [tip: perf/core] " tip-bot2 for Kim Phillips
2019-11-14 18:37 ` [PATCH 2/2] perf/x86/amd: Add support for Large Increment per Cycle Events Kim Phillips
2019-12-20 12:09 ` Peter Zijlstra
2020-01-08 22:26 ` Kim Phillips
2020-01-10 15:09 ` Peter Zijlstra
2020-01-10 16:22 ` Kim Phillips [this message]
2020-01-10 17:38 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83eacb7-6346-6823-6429-27ee1d44f2df@amd.com \
--to=kim.phillips@amd.com \
--cc=Janakarajan.Natarajan@amd.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®