From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbdHEMcN (ORCPT ); Sat, 5 Aug 2017 08:32:13 -0400 Received: from mout.web.de ([212.227.17.11]:52149 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbdHEMcL (ORCPT ); Sat, 5 Aug 2017 08:32:11 -0400 Subject: [PATCH 4/4] atm: idt77252: Adjust ten checks for null pointers From: SF Markus Elfring To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Sat, 5 Aug 2017 14:32:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:rA71fTqmZ1wSeZicdHfzwQUBZgrI8wm/96B0iJsZ5yjZN1urxWb 1lvhHWVlW0kZ3brQXbHs/kazO2LBJ/NaBpyr+0p7KQ7Otmw6u4L51VCMrDvV+tieXUFFIob kOPaOg2N8TIm6X3QZNWjpz5JYzFbElK5Ao8TLBQ7dKJgJ0WW08OLjIJb8/S83gXbDJyUD8y SEp07zlHkCBSE3PN46DlQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:nV3oTqZ5oGI=:/4DU81P5cJwbOajm76Zz44 Dg5N124rzR5q/7UZk2hRxAovlrxsT8cPxlw/DXlS7o4NjQJSlroxxL7tRmCBqdO0mIflKAjUx JKkp2qtPuw2RN8sXL4ymE8qR5EqD1fhXigXGXXVjkR9yotUnxchZD36ovRYgib8/ikVr2EQPt VQ/73tF2gW3LCic2GOckCymncaz9XRi5EFTyHOddFzxkFhwPbi4WQj7XprN0vcufOopgGCnwI v7bJeJ9eqLA2mP9Cl+61qOpVaulYLJRD7zR8QcN41NCOi0A1d0sEW31j6mlAPloGUcCynUzmH GIE+MbUhWkAiDmPov8Uel/gh8isDRTSsZIVlV+HHFuUTLt7uhuueHdMRVZCqyiruZ+/o4K64o i6aMPFO3M3rzhxtptKaQQ606wK8fiysltCSrIPofdvE2Ne+qV8GgcfL4EvmqfFBsVPo9CEpxP o2tuisjH/nbbIKeLqibw9iIisBD8jcEq2x+X1rx+y+ZhbtB7LgcGxGB9A5DvJKrTDcuTmG/Nr I337RfoOERKya13O+AXWKEkFYM3l0EswvTmwe3YLNjfuCPG9owWTL6dPLEsbsjyFAItqqJaKO SsGDf6c85yYwTZiW3i+eBT/f7jGk86X04k3iNtLRv4z77u7NWJa36ezEF886WkQGCQOZdzgWk T8+GjgsEXJPZOyTzCJXkZ9HYVVk4K0xNh+K4xnqYajuLVzWEzv8Ab72x6TQVHzfcsQTpKZr35 XzU6ZGWiPugk01L7K/wh+/3l2xFxsE7QTDUUWi/uyo7DthV7XwrlTjj+KLDBeFjzArnnNMCGv 03OyjgktfXLqpYgazTIlWn9iQGdk+qeZVUEZLtwyN9pg0rTpIs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 5 Aug 2017 14:04:42 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/atm/idt77252.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index e26e36a934e9..184934e05193 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -643,7 +643,7 @@ alloc_scq(struct idt77252_dev *card, int class) return NULL; scq->base = dma_zalloc_coherent(&card->pcidev->dev, SCQ_SIZE, &scq->paddr, GFP_KERNEL); - if (scq->base == NULL) { + if (!scq->base) { kfree(scq); return NULL; } @@ -973,7 +973,7 @@ init_rsq(struct idt77252_dev *card) card->rsq.base = dma_zalloc_coherent(&card->pcidev->dev, RSQSIZE, &card->rsq.paddr, GFP_KERNEL); - if (card->rsq.base == NULL) { + if (!card->rsq.base) { printk("%s: can't allocate RSQ.\n", card->name); return -1; } @@ -1026,7 +1026,7 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) } skb = sb_pool_skb(card, le32_to_cpu(rsqe->word_2)); - if (skb == NULL) { + if (!skb) { printk("%s: NULL skb in %s, rsqe: %08x %08x %08x %08x\n", card->name, __func__, le32_to_cpu(rsqe->word_1), le32_to_cpu(rsqe->word_2), @@ -1242,7 +1242,7 @@ idt77252_rx_raw(struct idt77252_dev *card) struct vc_map *vc; struct sk_buff *sb; - if (card->raw_cell_head == NULL) { + if (!card->raw_cell_head) { u32 handle = le32_to_cpu(*(card->raw_cell_hnd + 1)); card->raw_cell_head = sb_pool_skb(card, handle); } @@ -1375,7 +1375,7 @@ init_tsq(struct idt77252_dev *card) card->tsq.base = dma_alloc_coherent(&card->pcidev->dev, RSQSIZE, &card->tsq.paddr, GFP_KERNEL); - if (card->tsq.base == NULL) { + if (!card->tsq.base) { printk("%s: can't allocate TSQ.\n", card->name); return -1; } @@ -1601,7 +1601,7 @@ __fill_tst(struct idt77252_dev *card, struct vc_map *vc, avail = card->tst_size - 2; for (e = 0; e < avail; e++) { - if (card->soft_tst[e].vc == NULL) + if (!card->soft_tst[e].vc) break; } if (e >= avail) { @@ -1624,7 +1624,7 @@ __fill_tst(struct idt77252_dev *card, struct vc_map *vc, * Fill Soft TST. */ while (r > 0) { - if ((cl >= avail) && (card->soft_tst[e].vc == NULL)) { + if ((cl >= avail) && !card->soft_tst[e].vc) { if (vc) card->soft_tst[e].vc = vc; else @@ -1948,7 +1948,7 @@ idt77252_send_skb(struct atm_vcc *vcc, struct sk_buff *skb, int oam) struct vc_map *vc = vcc->dev_data; int err; - if (vc == NULL) { + if (!vc) { printk("%s: NULL connection in send().\n", card->name); atomic_inc(&vcc->stats->tx_err); dev_kfree_skb(skb); @@ -3429,12 +3429,12 @@ static int init_card(struct atm_dev *dev) card->soft_tst[i].vc = NULL; } - if (dev->phy == NULL) { + if (!dev->phy) { printk("%s: No LT device defined.\n", card->name); deinit_card(card); return -1; } - if (dev->phy->ioctl == NULL) { + if (!dev->phy->ioctl) { printk("%s: LT had no IOCTL function defined.\n", card->name); deinit_card(card); return -1; -- 2.13.4