From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763470AbdJQRV4 (ORCPT ); Tue, 17 Oct 2017 13:21:56 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:43405 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757506AbdJQRVz (ORCPT ); Tue, 17 Oct 2017 13:21:55 -0400 X-Google-Smtp-Source: AOwi7QD3/Kdb2xixPNIOtm+cs7I783YZnOMRlZCUzYxP5vtEFc5oVlmUankH6g+aRfDMrUsqSV9l6Q== From: Steve Longerbeam Subject: Re: [PATCH] staging: media: imx: fix inconsistent IS_ERR and PTR_ERR To: "Gustavo A. R. Silva" , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia Lawall References: <20171017171907.GA3957@embeddedor.com> Message-ID: Date: Tue, 17 Oct 2017 10:21:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171017171907.GA3957@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2017 10:19 AM, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in csi_link_validate. > The proper pointer to be passed as argument is sensor. > > This issue was detected with the help of Coccinelle. > > Reported-by: Julia Lawall > Signed-off-by: Gustavo A. R. Silva > --- > This code was tested by compilation only. > > drivers/staging/media/imx/imx-media-csi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > index 6d85611..2fa72c1 100644 > --- a/drivers/staging/media/imx/imx-media-csi.c > +++ b/drivers/staging/media/imx/imx-media-csi.c > @@ -989,7 +989,7 @@ static int csi_link_validate(struct v4l2_subdev *sd, > sensor = __imx_media_find_sensor(priv->md, &priv->sd.entity); > if (IS_ERR(sensor)) { > v4l2_err(&priv->sd, "no sensor attached\n"); > - return PTR_ERR(priv->sensor); > + return PTR_ERR(sensor); > } > > mutex_lock(&priv->lock); Reviewed-by: Steve Longerbeam