mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: 啟原黃 <u0084500@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	robh+dt@kernel.org, matthias.bgg@gmail.com,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	cy_huang <cy_huang@richtek.com>,
	gene_chen@richtek.com, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver
Date: Wed, 26 Aug 2020 19:07:03 -0700	[thread overview]
Message-ID: <f844b044-9ac4-094d-0ff8-feaceb50185f@roeck-us.net> (raw)
In-Reply-To: <CADiBU3_GX+BvxQCDkMtf70sXHnwFVNmBCJsrydROHjy5Lr9B4g@mail.gmail.com>

On 8/26/20 6:11 PM, 啟原黃 wrote:
> Guenter Roeck <linux@roeck-us.net> 於 2020年8月27日 週四 上午9:02寫道:
>>
>> On 8/26/20 5:59 PM, 啟原黃 wrote:
>> [ ... ]
>>>>> +static int mt6360_tcpc_remove(struct platform_device *pdev)
>>>>> +{
>>>>> +     struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev);
>>>>> +
>>>>> +     tcpci_unregister_port(mti->tcpci);
>>>>
>>>> That leaves interrupts enabled, which might be racy
>>>> because interrupts are still enabled here.
>>> M..., yes, it will cause the race condition during module remove.
>>> I'll add disable_irq before tcpci unregister to prevent it.
>>
>> Or just set TCPC_ALERT_MASK to 0, as in tcpci.c.
> Both are right, Thx. I'll choose one.
> 
> BTW, it seems enum typec_cc_status is used by tcpci.h.
> If I don't include tcpm.h, it will raise a warning during the compile time.

Ok, thanks for the note (that means tcpci.h should include
linux/usb/tcpm.h, really).

Guenter

      reply	other threads:[~2020-08-27  2:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 11:16 cy_huang
2020-08-26 11:16 ` [PATCH 2/2] usb typec: mt6360: Add MT6360 Type-C DT binding documentation cy_huang
2020-08-26 20:44 ` [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver Guenter Roeck
2020-08-27  0:59   ` 啟原黃
2020-08-27  1:02     ` Guenter Roeck
2020-08-27  1:11       ` 啟原黃
2020-08-27  2:07         ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f844b044-9ac4-094d-0ff8-feaceb50185f@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gene_chen@richtek.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=u0084500@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®