mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>,
	zhangjiao2 <zhangjiao2@cmss.chinamobile.com>
Cc: raj.khem@gmail.com, linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Clean up more build artifacts in 'clean' target
Date: Wed, 09 Sep 2026 16:50:43 -0700	[thread overview]
Message-ID: <f84b135af4b34c34166c557a9a99cd07e7f167bd.camel@linux.intel.com> (raw)
In-Reply-To: <bbbf056a-a86e-4ad4-97a4-4a32a36eafa2@kernel.org>

On Tue, 2026-09-08 at 09:39 +0200, Jiri Slaby wrote:
> On 01. 09. 26, 11:36, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > 
> > The 'clean' target currently leaves behind .* .o.cmd and .* .o.d
> > files,
> > as well as the generated 'include' directory. Extend the target to
> > remove these so 'make clean' fully resets the build tree.
> > 
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > ---
> >   tools/power/x86/intel-speed-select/Makefile | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/power/x86/intel-speed-select/Makefile
> > b/tools/power/x86/intel-speed-select/Makefile
> > index 6b299aae2ded..46874e4cee51 100644
> > --- a/tools/power/x86/intel-speed-select/Makefile
> > +++ b/tools/power/x86/intel-speed-select/Makefile
> > @@ -54,6 +54,8 @@ clean:
> >   	rm -f $(ALL_PROGRAMS)
> >   	rm -rf $(OUTPUT)include/linux/isst_if.h
> >   	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name
> > '\.*.d' -delete
> > +	find $(or $(OUTPUT),.) -name '.*.o.cmd' -delete -o -name
> > '.*.o.d' -delete
> 
> There are no *.d at this point (removed by the previous find). You
> can 
> do it on one line (as many of the other tools/):
> find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '.*.o.d' -delete
> -o 
> -name '.*.o.cmd' -delete
> 
> > +	find $(or $(OUTPUT),.) -type d -name 'include' -exec rm -
> > rf {} +
> 
> So you can remove "rm -rf $(OUTPUT)include/linux/isst_if.h" above,
> right?

Hi Zhang,

This makes sense.
Please resubmit.

Thanks,
Srinivas

> 
> thanks,

      reply	other threads:[~2026-09-09 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  9:36 zhangjiao2
2026-09-08  7:39 ` Jiri Slaby
2026-09-09 23:50   ` srinivas pandruvada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f84b135af4b34c34166c557a9a99cd07e7f167bd.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raj.khem@gmail.com \
    --cc=trivial@kernel.org \
    --cc=zhangjiao2@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®