From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbdJPBwP (ORCPT ); Sun, 15 Oct 2017 21:52:15 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8450 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdJPBwN (ORCPT ); Sun, 15 Oct 2017 21:52:13 -0400 Subject: Re: [PATCH] f2fs: return error number for quota_write To: Jaegeuk Kim , , , References: <20171012231500.19489-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Mon, 16 Oct 2017 09:52:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171012231500.19489-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.59E410C8.003F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 55518ec3355140f5847b0db007458fe1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2017/10/13 7:15, Jaegeuk Kim wrote: > This patch returns an error number to quota_write in order for quota to handle > it correctly. We should return error number like __generic_file_write_iter, right? it needs to return written bytes if we have written one page or more, otherwise return error number feedbacked from write_begin. So how about reverting 4f31d26b0c17 ("f2fs: return wrong error number on f2fs_quota_write")? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/super.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > index 2feecf5e7f4c..840a0876005b 100644 > --- a/fs/f2fs/super.c > +++ b/fs/f2fs/super.c > @@ -1397,8 +1397,11 @@ static ssize_t f2fs_quota_write(struct super_block *sb, int type, > > err = a_ops->write_begin(NULL, mapping, off, tocopy, 0, > &page, NULL); > - if (unlikely(err)) > + if (unlikely(err)) { > + if (len == towrite) > + return err; > break; > + } > > kaddr = kmap_atomic(page); > memcpy(kaddr + offset, data, tocopy); >