From: Andrew Lunn <andrew@lunn.ch>
To: Xinsheng Zhu <xinsheng.zhu.ny@gmail.com>
Cc: netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
oliver@neukum.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net] net: usb: cdc_ncm: reject short GET_NTB_PARAMETERS responses
Date: Mon, 12 Oct 2026 14:58:53 +0200 [thread overview]
Message-ID: <f84dc8e1-8dd3-4850-b87a-b526e66943b5@lunn.ch> (raw)
In-Reply-To: <CAFGKm+zjOtU8WGpcqqb6_XnFd3vmPw2RszPig9PJzbq3Uqh_Lw@mail.gmail.com>
> Fixes: 36c35416a94f ("cdc_ncm: fix endianness problem.")
What has endinesses got to do with message length? A truncated wrong
endian message is just as bad as a truncated correct endian message.
If you want a fixes tag, please make sure it is actually correct, go
back in the history and find the real place the issue was introduced,
not the last time the code was touched.
Andrew
prev parent reply other threads:[~2026-10-12 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 4:15 Xinsheng Zhu
2026-10-05 4:19 ` netdev-bot+sinfo
2026-10-05 4:36 ` Xinsheng Zhu
2026-10-07 4:16 ` netdev-bot+sashiko
2026-10-11 4:17 ` Xinsheng Zhu
2026-10-12 12:58 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f84dc8e1-8dd3-4850-b87a-b526e66943b5@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
--cc=xinsheng.zhu.ny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®