From: Paul Durrant <xadimgnik@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>,
Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM x86/xen: add an override for PVCLOCK_TSC_STABLE_BIT
Date: Wed, 1 Nov 2023 11:02:16 +0000 [thread overview]
Message-ID: <f850458d-c1a3-4851-921e-e04404e827b9@xen.org> (raw)
In-Reply-To: <028f629d16377f9a7e9fd87ef9564846b0ab4ed9.camel@infradead.org>
On 31/10/2023 22:48, David Woodhouse wrote:
> On Tue, 2023-10-31 at 15:39 -0700, Sean Christopherson wrote:
>> On Tue, Oct 31, 2023, Paul Durrant wrote:
>>>
>>> + if (force_tsc_unstable)
>>> + guest_hv_clock->flags &= ~PVCLOCK_TSC_STABLE_BIT;
>>
>> I don't see how this works. This clears the bit in the guest copy, then clobbers
>> all of guest_hv_clock with a memcpy().
>
> Agreed, that seems wrong.
>
It is indeed. Looks like it got moved the wrong side of the memcpy()
when I rebased.
Paul
prev parent reply other threads:[~2023-11-01 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 11:57 Paul Durrant
2023-10-31 22:39 ` Sean Christopherson
2023-10-31 22:48 ` David Woodhouse
2023-10-31 22:58 ` Sean Christopherson
2023-10-31 23:06 ` David Woodhouse
2023-11-01 11:06 ` Paul Durrant
2023-11-01 11:02 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f850458d-c1a3-4851-921e-e04404e827b9@xen.org \
--to=xadimgnik@gmail.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®