From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31B5C15575C for ; Mon, 14 Apr 2025 20:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744664132; cv=none; b=GuZ6yMYKmwY0g7x/UsYYofLbMhQy6bzZdNhn7baVxsiBzeFuHb1X1aQKxjDJMfquvPqcZvWNn5cG1JjBoZS4NW4mIRFCdD3IJ+JECEgPdFhab740Qsf/RLHnxAqokIc7Cs5dyPq5osrKNA7OhsG7a44H0CbPI3SLfZz1s/K9lTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744664132; c=relaxed/simple; bh=zjE3vRT+ssrRw7bL71CD3Oe95BvjsQfUHA6+heIvoZ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KKtsqSLEwIWxFOo8brNLI7vnJYXuchPz2+iO4AGI/DL3oYL4TPfi4mTrvPAmf7LDiwsA/7wojNgqa3Il5G68CfCp/Vtc1743++RLCISQfNRA32k3fQZE96pWwVTBR/lblNZJodnKktBDOSr78D7f+PSDOa8+ipI4dDjaCxhEQ74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W16IqfEg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W16IqfEg" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53EKemJ1014912 for ; Mon, 14 Apr 2025 20:55:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WxqIMMM+bD6pWCvSoOoUNZlHXMPZPcPy2ox/bPjumf4=; b=W16IqfEgr9ANz/Su PT/7IXowclo9n8BNUIy5eNsu+iLRfEttOXQ0DOXxZk6EsByU9K4U/xc0AugxXZjZ JhRWfIJXdvb8TGk2jtKw6xIkKujSxO1FMREqOei72PGhFq9pKIO2CcjF0lsk3DuD CTw5qyK251zw7ETYI5SN4wWnjIs5q/5lozfs97LQHD7X5QglnaYg4j8tnA4GpZxQ VACbYNT4b+zY018HIgXlnZvPvseQ2KI/FAhKl1v9tKQUfMXwIS3ZdV2pqFNhAwRd qxLPwdCXrj2VB36MJjf2BVUSaKzIovig4Owq2NyhSuBxwNs1ozneWSqfl5wYnq7t W9pWfw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yg8wds1e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 20:55:29 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c76062c513so121782885a.3 for ; Mon, 14 Apr 2025 13:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744664129; x=1745268929; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WxqIMMM+bD6pWCvSoOoUNZlHXMPZPcPy2ox/bPjumf4=; b=Dq3v+Se1LpT5n3wDLwkQFjhYclpOkiWbaB+dmWzos1kSiH4mWPvH7IjRt62epqNCeT ImVMC1KZdncU1OhRixRXGSkqF6QyniMvh7gFiEhbArTxUxXldFcIgXQCB0L8xeVkVet4 +56P5t/66y0wi6uf3y5A1Ccs1bTGklONNM4WvtKD/bU621RGVbKczPWkY2CbWtUYJ+7A vOdF+axw52iJyWiorIP1kOPzfBUJ+bglGtoiZhtSQKV7xmkKfsyn2T0jos5a1h1yMnt9 DxE3QoLyP9TiXyK37sonJZWjcNd9MsstVCN8FeRQJruJH7b0a/e5RIJYQDHOtsILH8W4 km0w== X-Forwarded-Encrypted: i=1; AJvYcCXwxbjwrxVNtRkwuSLWL7rOekt0RmWntLxKcPN5lVfUJI46hRw1PY8qQHgKom64gTZW5qtK7Cj3R1XotJI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv0bW51o/kmOfHDYt5NIPo2kgQr6D5RcOKqVMCDaEblfgBVajg XhnjYAooPi1PbAt5j54rFsaAGpGFfX6uSUdRYHENaSGWAWk125tqCYevBPKax+NAi7b1MLBVyiy KkUSLZdXuEpfFumpIjcyyCiglS6+3xDP2hdXaLitmpuvFkmwAmsVNoSCEdjOv7CI= X-Gm-Gg: ASbGncs0nC6dUKLqCFVDcri7jCJLqvuMx19RTFQNxZ6eFK72+quVvDEeATJDPxC3JDT 0UhB5v6Phyi55kNHlTifAxONVpl01XyRMLd45rwkE4MS51isOz8JgH62FQ9Bmvr/uL5meyt8Nvi CjoAINWaZPlq5OhOYwGW9V99FGyxs6YwYkmFg4KuECbux8xhVadBtQLBP5UyEfNYjf5rcwcphtk EJ96jb1fobCQ1ZJ3pZnsJhQLuvKcI71ZnCIqc+eq9P0E879ukLJApWWgL0IqgJwaAIGPylD/pHR DE2GhIwaHf7myTOIMmr0p11o9sEkD9dKzdmOOciVUMaQmuvp3VoK77SEbP2HurM7ww== X-Received: by 2002:a05:620a:4627:b0:7c0:bb63:536c with SMTP id af79cd13be357-7c7af10641cmr597552185a.4.1744664128874; Mon, 14 Apr 2025 13:55:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGoWIvNWBnu8DBGFjtGdagGBK2fyiZED6ibSgijR4nYQRmR9ck5XDihEjcIo4pATTzpB4UWZQ== X-Received: by 2002:a05:620a:4627:b0:7c0:bb63:536c with SMTP id af79cd13be357-7c7af10641cmr597548885a.4.1744664128405; Mon, 14 Apr 2025 13:55:28 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f36f5056easm5692216a12.63.2025.04.14.13.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 13:55:27 -0700 (PDT) Message-ID: Date: Mon, 14 Apr 2025 22:55:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] arm64: dts: qcom: Add initial support for MSM8937 To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Srinivas Kandagatla , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Dang Huynh References: <20250315-msm8937-v4-0-1f132e870a49@mainlining.org> <20250315-msm8937-v4-4-1f132e870a49@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250315-msm8937-v4-4-1f132e870a49@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=E9TNpbdl c=1 sm=1 tr=0 ts=67fd7641 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=bBqXziUQAAAA:8 a=OuZLqq7tAAAA:8 a=zdbjSHh-4Hdwht_aKTEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=BjKv_IHbNJvPKzgot4uq:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-ORIG-GUID: czDd5IdZMsrouGy1KOHDwHKI0GdhccHG X-Proofpoint-GUID: czDd5IdZMsrouGy1KOHDwHKI0GdhccHG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_07,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140152 On 3/15/25 3:57 PM, Barnabás Czémán wrote: > From: Dang Huynh > > Add initial support for MSM8937 SoC. > > Signed-off-by: Dang Huynh > Co-developed-by: Barnabás Czémán > Signed-off-by: Barnabás Czémán > --- [...] > + power-domains = <&cpu_pd0>; > + power-domain-names = "psci"; So CPU4-7 get "nicer" idle, but 0-3 don't? [...] > + cpu-map { > + /* The MSM8937 has 2 cluster A53 setup. */ This comment seems superfluous [...] > + timer { 'p' < 't', please sort top-level nodes alphabetically [...] > + wcss-wlan2-pins { > + pins = "gpio76"; > + function = "wcss_wlan2"; > + drive-strength = <6>; please unify this order (drive-strength before bias) > + bias-pull-up; > + > + }; Extra newline [...] > + gpu: gpu@1c00000 { > + compatible = "qcom,adreno-505.0", "qcom,adreno"; > + reg = <0x1c00000 0x40000>; > + reg-names = "kgsl_3d0_reg_memory"; > + interrupts = ; > + interrupt-names = "kgsl_3d0_irq"; > + #cooling-cells = <2>; > + clocks = <&gcc GCC_OXILI_GFX3D_CLK>, > + <&gcc GCC_OXILI_AHB_CLK>, > + <&gcc GCC_BIMC_GFX_CLK>, > + <&gcc GCC_BIMC_GPU_CLK>, > + <&gcc GCC_OXILI_TIMER_CLK>, > + <&gcc GCC_OXILI_AON_CLK>; Please align the + clock-names = "core", > + "iface", > + "mem_iface", > + "alt_mem_iface", > + "rbbmtimer", > + "alwayson"; > + operating-points-v2 = <&gpu_opp_table>; > + power-domains = <&gcc OXILI_GX_GDSC>; > + > + iommus = <&adreno_smmu 0>; > + > + status = "disabled"; > + > + gpu_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-19200000 { > + opp-hz = /bits/ 64 <19200000>; > + opp-supported-hw = <0xFF>; 0xff is overly broad, please document the existing known speed bins [...] > + adreno_smmu: iommu@1c40000 { > + compatible = "qcom,msm8996-smmu-v2", > + "qcom,adreno-smmu", > + "qcom,smmu-v2"; > + reg = <0x1c40000 0x10000>; Does it work as-is, without iommu changes? [...] > + thermal_zones: thermal-zones { > + aoss-thermal { > + polling-delay-passive = <250>; There are no passive trip points> + > + thermal-sensors = <&tsens 0>; > + > + trips { > + aoss_alert0: trip-point0 { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "hot"; > + }; Please convert these to 'critical' instead [...] > + cpuss1-thermal { > + polling-delay-passive = <250>; You can drop polling-delay-passive under CPU tzones, as threshold crossing is interrupt-driven > + > + thermal-sensors = <&tsens 4>; > + > + cooling-maps { > + map0 { > + trip = <&cpuss1_alert0>; > + cooling-device = <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + > + trips { > + cpuss1_alert0: trip-point0 { > + temperature = <75000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpuss1_alert1: trip-point1 { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "hot"; > + }; On newer platforms we rely on LMH to shut down the device if it were to reach the junction temperature, but let's leave them here as probably no one remembers for sure how reliable that is on these older platforms and you're most likely not willing to test that Konrad