From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
andersson@kernel.org, baolin.wang@linux.alibaba.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
ulf.hansson@linaro.org
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 0/4] mmc: sdhci-brcmstb: rpmb sharing by claiming host for TZOS
Date: Thu, 31 Jul 2025 09:43:18 -0700 [thread overview]
Message-ID: <f85367bb-566e-43d6-b405-b896c49c9aa7@broadcom.com> (raw)
In-Reply-To: <d542b1fa-6e2a-4af1-a14b-eee32a7f3de6@intel.com>
On 7/28/25 02:11, Adrian Hunter wrote:
> On 11/07/2025 18:42, Kamal Dasu wrote:
>> This patch adds support to claim host for TZOS RPMB access and synchronized
>> access to the controller hardware using hwspinlock framework.
>> To achieve this Linux OS and the secure TZOS make use of:
>> - shared hardware semaphore register
>> - a set of SDIO shared work registers and
>> - IPI interrupt registers
>>
>> The currently running OS that needs access to the controller puts itself in its
>> slot of work register and if its next in line it can try to grab the hardware
>> semaphore and complete its mmc requests. The shared work registers indicate next
>> in queue to access the controller, and current agent in the queue. Next agent
>> queue state is changed under the hwspinlock is owned by the current OS accessing
>> the controller hardware before release the semaphore, send and receive IPI
>> interrupts between linux and secure world are used to indicate completion of
>> transaction to the waiting OS. TZOS has its own RPMB driver which accesses
>> partition when it wants to read/write RPMB frames. Current implementation
>> assumes Linux and TZOS as the two work agents.
>>
>> This patchset is an alternative method to initial RFC patch:
>> [PATCH RFC 0/3] mmc: sdhci-brcmstb: Add rpmb sharing support
>> https://lkml.org/lkml/2025/2/6/1711
>
> Does it address Ulf's comments? i.e.
>
> https://lore.kernel.org/all/CAPDyKFrCjo8gGnxmXWP6V39N+b1o62VQH9zwMUNb2_+D3-qrdw@mail.gmail.com/
If you are referring to the fact that Linux is the exclusive owner of
the eMMC controller, then no, that is still not what is being done here,
but we did respond as to why this is done that way, and there was no
subsequent question or comments on my respond to Ulf:
https://lore.kernel.org/all/6328fe8d-c4ea-4945-b6ba-d994403121b5@broadcom.com/
--
Florian
prev parent reply other threads:[~2025-07-31 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 15:42 Kamal Dasu
2025-07-11 15:42 ` Kamal Dasu
2025-07-11 15:42 ` [PATCH 1/4] dt-bindings: brcmstb-hwspinlock: support for hwspinlock Kamal Dasu
2025-07-13 8:37 ` Krzysztof Kozlowski
2025-07-11 15:42 ` [PATCH 2/4] hwspinlock: brcmstb hardware semaphore support Kamal Dasu
2025-07-13 6:33 ` kernel test robot
2025-07-11 15:42 ` [PATCH 3/4] dt-bindings: mmc: add brcmstb share register and hwlocks reference Kamal Dasu
2025-07-13 8:40 ` Krzysztof Kozlowski
2025-07-11 15:42 ` [PATCH 4/4] mmc: sdhci-brcmstb: rpmb sharing by claiming host for TZOS Kamal Dasu
2025-07-13 8:44 ` Krzysztof Kozlowski
2025-07-28 9:11 ` [PATCH 0/4] " Adrian Hunter
2025-07-31 16:43 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85367bb-566e-43d6-b405-b896c49c9aa7@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kamal.dasu@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®