From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794324671; b=o+xuJ2VZ9NlMR2Sh/4px/JkZ26ztvem27dAd3id884VosQ1npGVa2bgea5H3GnLFW0vA Xa8yHQG4rypNxz65c1A3KrDlm4nmsk9lqA9uxdefNbVQFuPGoGMYokFOgyfJSKW6VZimB hnVFGhuNBgqY1DikqctjdfAQFINGvT66XW3plVaD1LrF+6cy0j+p0wfRQIaVJzq3ivUC0 beBeffMIllDGuk7oeHVgj4/H1rDldlSo0tMKIn5raSN1YXxygGIxHVicFI1JqX2KkK2VN BhJ68yt71ehcXOXZbniiO0lLYPjiT++IG5Q6PnF61g4FKehBu7xpBf4z3F62FIDIQUQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794324671; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: Content-Language:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=gXjqAYmOZzBpoVOClTeMCf3Fr5RoD9/tZaRkMD38hnw=; b=0kw2QEhreeny09RUnvEbuwtD1YMsv9oa9yMXX93wu90uPFJqHhGvlcGqixdB8cvCPIYV 786/WVxPG5R2TKaO30nrzbI3m+i/mEdIDj6HfjqLa8xfTGb12cTwz9N7jxnK8ZhUO5tx/ taokdz2h/lkzjgw1Lx1KBrPsXm/LTRnkTT6u/NDMvG7HWpis+HnV2ftJ9qf2wJVmYd/yR /Wq0fHHgtzdvp8rMzcxnNAZPPOv6O2ZnRVirS1oWsMJ5x4TIXXXfPUXFuvdYzw0NyRgJ2 R6uBE4Xd3K/RtY24juasNNzCXxCjteKFgLWKbNCwGy8spalnFjpNhUj4rHnmLFAQjcw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hcQUGjb4; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=o2DRGKwa; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D3D606A31C for ; Tue, 10 Nov 2026 15:31:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B8D3D606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hcQUGjb4; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=o2DRGKwa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794324669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gXjqAYmOZzBpoVOClTeMCf3Fr5RoD9/tZaRkMD38hnw=; b=hcQUGjb4o9ZInWycESOrSrCPhAWfXSoa2WP81h/GTWZB+3SSAaeexbsov8hi+t/xVenCYU XV2VPzeZAd8vcNiPyCyfETT6iGJHPYXANGIAPKDZ+Dpbo/KOytaAE3VpO0CvcxhQ7IEKqu c0xr/Xato41pKFnrogQyusx3RuxjYOo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-Qd_rjMm6M-qClYwmVJVmpw-1; Tue, 10 Nov 2026 10:31:08 -0500 X-MC-Unique: Qd_rjMm6M-qClYwmVJVmpw-1 X-Mimecast-MFC-AGG-ID: Qd_rjMm6M-qClYwmVJVmpw_1794324667 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4ba01393800so9133055e9.1 for ; Tue, 10 Nov 2026 07:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1794324667; x=1794929467; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=gXjqAYmOZzBpoVOClTeMCf3Fr5RoD9/tZaRkMD38hnw=; b=o2DRGKwamIrWbnBK8ZAYCOGE6SW95LqzSGt7qtdluNDesOZ5jy4HWjJJUYO3RlAtMY p2LKWjmpdnr8AvjY8atM7KdhDQGSPhIuVPCSDrJby4abJkS3FfEQ5BxA5hemjvN9xZYC f0HQLuHH242uuwmKRoDKbsoz8BP2/4KdsGeCEO+ZpioQLw/PVjVTIUjecxrF5bjUk/dB 7w2kcnrcWh5gGvoKh4496mkOxZSXxIvRWmgyNsTl4I4yZvTdCn88gL9cDX10EXtimZ+v id3WdZR5kBsHOGlzrBfsIkTsqhIWc0mipnLJsf8eszFjO8xdX28RHQPKyA+lWVyCnoww d3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794324667; x=1794929467; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gXjqAYmOZzBpoVOClTeMCf3Fr5RoD9/tZaRkMD38hnw=; b=A1ftYrigzONerxybNqSzee50iuiR9kcKFwLeJfixhH6sfbsIhjvUa0m2tezXlVnhcW cG1Sr3YI9apNDf6OXfkaPYzBtxxEgpWa/DrjmUY+Cq5b8oJNDj8W+1U9MmUiv9+3X5Sv UOvBxEMQXVeTHJlx/xL5EiQYGkgLJtS7C06WOtxWrWSEhiqbck3Ha7VGveDrQpVRSEeC NVpOPovqnOIJbmAAZ8wminxLzSdWcmrjcDa6yEjxAsCYA6NyRLYaNRC+KFHM7b2g1k8F NAw0HjzHI5+VQFItOOI8oSGl75Ypt92HcPyfpi++telTXjNp21FrZZjF4RB32pETWzfB vK5Q== X-Forwarded-Encrypted: i=1; AL+hErGvJhmYrcQw5wjjVistb0A5hl3/0UCEYDoclxQAjyzSbBooAWfg5YM0yn9FFl02MCPM2H0DILii4tvE1GM=@vger.kernel.org X-Gm-Message-State: APuU4Z+ZnjxrQZMVlTLc2AxqX0QCZ+5FoRTpziA0ge67DqRw6ujDRgsn 1gYB22fb3D/cM4Rqg8o53JtgaPF4dHhQKyX4nqevtd/MTEpu0pYaFEj1IyS8/8fP10h16BSWj2k aPYXY4DFvy3hksnRhRfiCWUrg3xTHRaI7aasNm30PjsIhDO8c7BuDN+f3ovJURS8LMA== X-Gm-Gg: AYBFou07O58qqbjKcToXUFfu26jwaR7KFp6Wcyia3/maiRezSr8M37T9q7Bz7lYvbIm q7j74LnlUTq40h/JuHLEgcgehRUgdUKm4/AJmFfNuWvYwZ2HKvqrthEvpXkouBAOA7P2fiztnr3 szDy2/xPoM7o1qnaABBLMH9sCadjc1Ea9tVcHNocb+D7glpSGAJcU6IlmqmeUsEquLSELLLmjs8 Q2i7R5d72mBAsRO3yKB60hKs3ORlyvaLzM2WWnDC66vvKPpmf3SiSECXnl8QVZwRXpUvq4IMEpn 3sV0nBjxvsRZj5zDUD547X0WdtpFg7lKE2auBK1lWsWflSd492XHeTJH/glj1f1bQ0KPmPC/Q0D VP7y6iRBOfQ4krvdO00MD4ZnfawBtE8nYx3s= X-Received: by 2002:a05:600c:811a:b0:4a5:1cf1:b7bd with SMTP id 5b1f17b1804b1-4ba02348d9amr50067725e9.16.1794324667017; Tue, 10 Nov 2026 07:31:07 -0800 (PST) X-Received: by 2002:a05:600c:811a:b0:4a5:1cf1:b7bd with SMTP id 5b1f17b1804b1-4ba02348d9amr50066905e9.16.1794324666429; Tue, 10 Nov 2026 07:31:06 -0800 (PST) Received: from [10.43.3.161] ([213.175.37.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba022ff5c3sm31998605e9.0.2026.11.10.07.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2026 07:31:05 -0800 (PST) Message-ID: Date: Tue, 10 Nov 2026 16:31:04 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/10] ice: dpll: update locking comments Content-Language: en-US To: Ivan Vecera , netdev@vger.kernel.org Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Jonathan Corbet , Shuah Khan , Randy Dunlap , Min Li , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Grzegorz Nitka , Karol Kolacinski , Saeed Mahameed , Tariq Toukan References: <20261106121005.1327603-1-ivecera@redhat.com> <20261106121005.1327603-10-ivecera@redhat.com> From: Petr Oros In-Reply-To: <20261106121005.1327603-10-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/6/26 1:10 PM, Ivan Vecera wrote: > Callbacks run under the DPLL core domain locks instead of dpll_lock. Note > that callbacks of pins of an external DPLL run under the domain of that > DPLL, so only pf->dplls.lock serializes them with the rest of the driver. > > Signed-off-by: Ivan Vecera > --- > drivers/net/ethernet/intel/ice/ice_dpll.c | 4 ++-- > drivers/net/ethernet/intel/ice/ice_dpll.h | 3 +++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c > index d6302409a2dacf..07cbd4cf0160ca 100644 > --- a/drivers/net/ethernet/intel/ice/ice_dpll.c > +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c > @@ -1178,8 +1178,8 @@ ice_dpll_input_state_get(const struct dpll_pin *pin, void *pin_priv, > * peer via dpll netlink learn about the update. > * > * Context: Called from dpll_pin_ops callbacks after pf->dplls.lock is > - * released. Uses __dpll_pin_change_ntf() because dpll_lock is > - * still held by the dpll netlink layer. > + * released. Uses __dpll_pin_change_ntf() because the domain lock > + * is still held by the dpll core. > */ > static void ice_dpll_sw_pin_notify_peer(struct ice_dplls *d, > struct ice_dpll_pin *changed) > diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.h b/drivers/net/ethernet/intel/ice/ice_dpll.h > index 4ba76e2e2e0b01..39e041a30090d0 100644 > --- a/drivers/net/ethernet/intel/ice/ice_dpll.h > +++ b/drivers/net/ethernet/intel/ice/ice_dpll.h > @@ -165,6 +165,9 @@ struct ice_dpll { > * tx_refclks usage map), acquire pf->dplls.lock first, then > * ctrl_pf->dplls.lock. Skip the second acquire when pf == ctrl_pf > * to avoid recursive locking. > + * - Callbacks of the SYNCE and TIME_REF pins of an external DPLL run under > + * the DPLL core domain lock of that DPLL, not of the TXC and TSPLL DPLLs, > + * so only @lock serializes them with the callbacks of these DPLLs. > * - @txclk_notify_rwsem is held for read across > * ice_txclk_update_and_notify(), including the out-of-lock > * dpll_*_change_ntf() calls. ice_dpll_deinit() takes the write side Reviewed-by: Petr Oros