From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E079F30FC2D for ; Mon, 1 Dec 2025 12:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764593435; cv=none; b=aK6xWZw0PmrEDpUNQhSp15XxD0FLZxJtsygmxh1+5HW2JSc7QSV7snqRgPMMpk8Wg+t2iBqJ2YFu9/YDdckmWGuLatEzCTVoGnXDJLLnYd7dk+O689orlNK6M1uz59E1p1KwyYc5vSlVEGFTx7ZrlpXAa/Q0UHd8zWiq082Vqfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764593435; c=relaxed/simple; bh=3Lempk/IOUZAlYvbPF2A/aQxGYHdGcn33YO5RSNVjRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=skGl0knByEsK/iaIpoP2HSck9T1hJMdWsEQ9dAe/de693FfFoZdup55CQmsWW/T+Dz7mbubIwzci62Snlznmj/SftvefvUeg+Ub1QszO6z/BCNhPFfQTHj1NFBdTOjQjDn1Zlp1jPcYOL/XGHNEaJZluQSyUaB2yi0aSMz6CiFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=fail smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Aau7poNP; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Aau7poNP" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so29789345e9.2 for ; Mon, 01 Dec 2025 04:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764593431; x=1765198231; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3JlqK0ZnrQL7pFj/vous2tYHR6XDdun4YSY1ntH8dXY=; b=Aau7poNPM7BaKhv7LzTA1uvPJ5hOOUaCNxivIpo4UcfK0q5aSNKsU8SsQU+AmWpDkJ Pylb8ifHaIrJ8hT8SfJs973553skug2nb1bcSY5AhOMKSlIAHXFcbXJxyJK0ik8F0Roq 7yruYhQ4QN/sGgXGf2PgW6TEZJ2umCfxZBgVMdHYY2wYruMpZ7qmFseY42ZNXm2WQ7W8 KluFhMSvUJOx4aiqSeMUNsDifjIKBUkEh6Y2osEhE+3VVxuVAQxJ0ObkzWC3KkpxraQA IHY6+iS+xI8CocwcyoAtY1wTDz/khi3R9GjY8MzDvABTb5SF++DO4Qm1YGa1d6tZdJ+L bmyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764593431; x=1765198231; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3JlqK0ZnrQL7pFj/vous2tYHR6XDdun4YSY1ntH8dXY=; b=tDtiaVnWDhc0/vRVUbEkQ/+lyPh5ovu2opw5+OYU3PciGEruDJ2LTa2q/jLZ9aji99 0CecwdoPBZw6DglIJSlheKfutFk3hRVM0h6s0WqVzwqAT0ieSyAotm7J4H56U0ziyhE7 ol1j3CI7hbNLZ4sTvnfhncXMGoShlQZLHuo2Go6U39ocv6UojjYYMC2+VkyBJsQFTInt otgw65ZZZxLjkLJAK8gcex5Ik932kyGS85aJUpuowhinPmjOzcm+Fb+mF/6eDXdVu8TM de9AGbgqJtXZzoyKEh1pez9FQ4IBPprqMWgfJFJorGUFFQeK9swR2244HaynguxrGwz3 vBoQ== X-Forwarded-Encrypted: i=1; AJvYcCXlclZNODjGbzBrBRqtqC6cZGkox6oRsVX60iIwdo21yorN1RRWcg0UK4WdOLa0yHUkzETd5dIWiaONJKQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTKyheDkPy5Dl0U3VYE2GeDcDeIlRQZNTPl6BZr43AORO4cLUF SW78GrxbrBTfmRq1FwhySiS4i1wVkVek5ytfY1+wjR1WFAodXzHztd/TGFkahlSoGIsM7JATWhh 1aIyj X-Gm-Gg: ASbGncvch6QKaMOPB9t69BzKHcLsqEl7yAozat7f0/ymeLckzcz4uwfZxf0qic3lUI3 z48gt531OE9xUjbpD/rgk1z5u1+X96rX5/YlPhrNik+h/JqBk3yXuDSDMPq34ZzWHe558XLmfaC oSsLxaZ1q5GpBeiI60F4jfHZOV06IVo7hnNsxR74HHA7HPdeL42LRrWXkgDd7bkkQ9EsvgEku6B vlsKGMSoLIiMbzmF+3cPnFFsSeSvgnuFPEz8Pyl89nFhqDDOazC4zsbgWktSRHrsVKyKQs5tcTA 8xx+JFg6as+XReVNHlh5Vwlkg8Sg0bVoqv2Ft3lAnE1KjDjfz2j8Ooye0Jl7nnONMwiLttqDQ81 moIDwerO7CCm2KpMl3N7SiIVAvuyVyOMdytEZsJpTzT4N9wdeNUr1rXzqXx61VDva7SJjLtznJb AkXP5IneCmPexm/8CM2UJgakIeZy+izNyH3FOAkFkfQboZEkrdNOg= X-Google-Smtp-Source: AGHT+IFCiHhSv7clOJbOTsjbFGUe1tQYLwM5Ciro9iNMejKFvi5zfUI19dCqAQbxePS0HCp6jxwcYw== X-Received: by 2002:a05:600c:1551:b0:477:7d94:5d0e with SMTP id 5b1f17b1804b1-47904b23c43mr242645295e9.27.1764593431085; Mon, 01 Dec 2025 04:50:31 -0800 (PST) Received: from [192.168.1.36] (p549d4b1b.dip0.t-ipconnect.de. [84.157.75.27]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479040d3c72sm158803585e9.6.2025.12.01.04.50.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 04:50:30 -0800 (PST) Message-ID: Date: Mon, 1 Dec 2025 13:50:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: labibb is not used on OnePlus 6/6T Content-Language: en-US To: Konrad Dybcio , david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251130-oneplus-labibb-v1-1-bb3653e43120@ixit.cz> <3fcfc5b8-7509-4e4c-a1cd-e973d7e1d091@oss.qualcomm.com> From: Casey Connolly In-Reply-To: <3fcfc5b8-7509-4e4c-a1cd-e973d7e1d091@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/12/2025 13:48, Konrad Dybcio wrote: > On 11/30/25 1:08 AM, David Heidelberg via B4 Relay wrote: >> From: David Heidelberg >> >> The lab and ibb regulators aren't used here. Disable them. >> >> Removes following warnings: >> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device link (0x180) with supplier c440000.spmi for /soc@0/spmi@c440000/pmic@3/labibb/lab >> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device link (0x180) with supplier c440000.spmi for /soc@0/spmi@c440000/pmic@3/labibb/ibb > > These are only vaguely related, as there's nothing to be wary about that's > specific to these devices - it's just devlink being grumpy > >> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices") >> Signed-off-by: David Heidelberg >> --- >> I assume this is right approach, as OLEDs on both devices are driven by >> different regulators. >> >> Question is, if should be labibb nodes enabled by default? > > They're onboard. I'd rather keep them predictably parked than left in > whatever (potentially ON) state the bootloader may leave them at Shouldn't they be default disabled in the pmic dtsi and only enabled on the devices that actually use them? Many SDM845 devices with OLED panels don't use these regulators. > > Konrad -- // Casey (she/her)