From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B62C001E0 for ; Tue, 1 Aug 2023 09:22:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229885AbjHAJWH (ORCPT ); Tue, 1 Aug 2023 05:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231731AbjHAJVs (ORCPT ); Tue, 1 Aug 2023 05:21:48 -0400 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1810330E6; Tue, 1 Aug 2023 02:20:28 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R391e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VoqCIxF_1690881552; Received: from 30.221.149.238(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VoqCIxF_1690881552) by smtp.aliyun-inc.com; Tue, 01 Aug 2023 17:19:14 +0800 Message-ID: Date: Tue, 1 Aug 2023 17:19:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5 3/5] perf test: Add pmu-event test for "Compat" and new event_field. To: John Garry , Ian Rogers Cc: Will Deacon , Mark Rutland , Robin Murphy , Ilkka Koskinen , Namhyung Kim , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Shuai Xue References: <1690525040-77423-1-git-send-email-renyu.zj@linux.alibaba.com> <1690525040-77423-4-git-send-email-renyu.zj@linux.alibaba.com> <2dc21269-2fa0-ea39-454d-5f12a414bc13@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/7/31 下午9:12, John Garry 写道: > On 31/07/2023 13:30, Jing Zhang wrote: >>>> +        .pmu = { >>>> +            .name = (char *)"uncore_arm_cmn_0", >>>> +            .is_uncore = 1, >>>> +            .id = (char *)"43602", >>>> +        }, >>>> +        .aliases = { >>>> +            &sys_cmn_pmu_hnf_cache_miss, >>>> +        }, >>>> +    }, >>>> +    { >>>> +        .pmu = { >>>> +            .name = (char *)"uncore_arm_cmn_1", >>> Shouldn't this match some perf_pmu_test_event entry with same matching_pmu member? But is perf_pmu_test_event.matching_pmu member ever used for any checking??? >>> >> I need to double check because I was testing against 6.3-rc2. > > That 6.3-rc2, was for the the kernel? Or baseline for this series? See see maintainers for git/branch to base perf tool dev on. > I have now developed based on the latest perf tool, but I'm still confused. "matching_pmu" does not seem to have any effect. No matter what value matching_pmu is, it will not affect the final test result. Thank, Jing