From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE61C433FE for ; Mon, 7 Nov 2022 17:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232350AbiKGRYA (ORCPT ); Mon, 7 Nov 2022 12:24:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231829AbiKGRX6 (ORCPT ); Mon, 7 Nov 2022 12:23:58 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36ED7140E5 for ; Mon, 7 Nov 2022 09:22:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667841777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rZ09hkMmaoZyaAHo1tsMTz2+wpqw+JOCPiAMroMDJUc=; b=f2bbVvFWtSz/4C5a+W6T4PiaMQbBgHrjQMfsXreywUX7mg2mAn2KrtsKso7p4fxBZm7Qv6 QZYKGkq5O7Vd5sLonmTZ1z4fu1fyvQjTEnzRwr2HUkYbaWyDAG2fXN4+Hd9iLZAQnairYE JKpKtabCrL+Grbh7/vEmkSZZmJsOagc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-126-K399CrYCPmmWbaTX_4tglA-1; Mon, 07 Nov 2022 12:22:56 -0500 X-MC-Unique: K399CrYCPmmWbaTX_4tglA-1 Received: by mail-wr1-f71.google.com with SMTP id e21-20020adfa455000000b002365c221b59so3064960wra.22 for ; Mon, 07 Nov 2022 09:22:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rZ09hkMmaoZyaAHo1tsMTz2+wpqw+JOCPiAMroMDJUc=; b=v1xeQ+a3CIoF4IlFkUyb0i3NDjmPonxYKp+0fI6DuZx3N/iLHjpci43IViCwkQBcij QxbhLj/elsjkpD/kfRAN3aZVg5f2eEtjXfrGlbK9ZsVH+E2dHkMjZVqibeYu2wrldBw6 aahAMrPui9xZvxYrTJPTypfj1LrWU8Ao/Quql6ewPMF5Z4DYsTfjM9nyqAf7AXQ8gLjr LY8dSKPsYJ4VYkFWdS9Sh88Y5DoZYTgR1xmcrfcKVOStxKZnuuczd9Cohq+wV2bMYFYV lDaxvL7G2EhzMy7I/f1UNgur42GSB/Xmld5NiXe6WgH12OietFDJdQ0PEuafrx9BpFoP 2zYQ== X-Gm-Message-State: ANoB5plDg59I/L/LPil2XzKSWu3Qv5bs/5Ml72syllLsMi6c7XvGq0GC T55RYdAps9ojGuPohsfqI6TsRXfZtngVzjgX2D+hijjN2iSgEi7wJMOCjjAgupj5YhthQXxoekd MsDQE13IuF3rRS2tdapA1l0oa X-Received: by 2002:a05:600c:230d:b0:3cf:acc6:ba97 with SMTP id 13-20020a05600c230d00b003cfacc6ba97mr3544879wmo.102.1667841774872; Mon, 07 Nov 2022 09:22:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf7qokg77pGCfqZ79Xlcw58RP/DEA32EcgvzY5lzjy3O/cLRok4O78DHfLKUoSjy0W/V37mzEA== X-Received: by 2002:a05:600c:230d:b0:3cf:acc6:ba97 with SMTP id 13-20020a05600c230d00b003cfacc6ba97mr3544869wmo.102.1667841774642; Mon, 07 Nov 2022 09:22:54 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id p15-20020adfce0f000000b0022cbf4cda62sm9477730wrn.27.2022.11.07.09.22.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 09:22:53 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 18:22:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/8] KVM: SVM: replace regs argument of __svm_vcpu_run with vcpu_svm Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, nathan@kernel.org, thomas.lendacky@amd.com, andrew.cooper3@citrix.com, peterz@infradead.org, jmattson@google.com, stable@vger.kernel.org References: <20221107145436.276079-1-pbonzini@redhat.com> <20221107145436.276079-3-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/22 18:10, Sean Christopherson wrote: > Needs to include asm/asm-offsets.h, otherwise the compiler may think that > SVM_vcpu_arch_regs is a symbol. > > ERROR: modpost: "SVM_vcpu_arch_regs" [arch/x86/kvm/kvm-amd.ko] undefined! > > diff --git a/arch/x86/kvm/svm/vmenter.S b/arch/x86/kvm/svm/vmenter.S > index 8fac744361e5..8d0b0781462e 100644 > --- a/arch/x86/kvm/svm/vmenter.S > +++ b/arch/x86/kvm/svm/vmenter.S > @@ -1,6 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #include > #include > +#include > #include > #include > #include Yeah, it's included slightly later (I did test each patch independently, but I'm not sure how it ended up disappearing from this one). Paolo