From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03111A0BC4 for ; Tue, 3 Sep 2024 09:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725357397; cv=none; b=LwR6yt3Se7sHmPfXMWxJy+hGjzJeR6k3qXyXRmYQErlTNQSWkO6kxZfX11MGFIKfOJPJQb0zY9HaEeT5hs80Sckx4wAQBL1rug0B/8NvVm8j4SwI5fljkm6fUBvEh965FNYQI4jAHWDj3LT2Udsb5Yg8bee+07nZMZoVSLxAKxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725357397; c=relaxed/simple; bh=wXmoPYOep+h3XyZTqNCX0XZSRCowT5vbWV1Ogo/MIdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ujYLkZ+11UUzZ+kAt9b9IqybXmQZlxHh5yl60qHYMNhVJXMx8ZfDTgYcBlhi16aWKFo3YrpqKJ5Dqs/Ntb22HudYm92WR0OdzarISgIsYhFfISE7rYj/FkJf5wQGbhFSrL1wlysrnwHCapn0J/Nw9OTgDCRpuBbcRAuFG7hjfy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OMrkL4+u; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OMrkL4+u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725357394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b7haqHBO4Bmmvo6I/VLdqWxTwNidBjBDf11sa79tfrc=; b=OMrkL4+uG+cRsacDzhjMVle+WUDN9qY3swUJnASO/ehGo/ICtTYmjno/uE41w0I8N9BB21 7uHYQ8m+HjrebQAo7dGa8Bb1gGZuCdgIxRmstF4zWMmxyKJYitJhnRqnv1Jo97MtdVTCdF EW0s8lEDHmN+R2z4yJ7RHsrQ23HPeqQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-0T9_6TcfNEqzIKpD9DR4iQ-1; Tue, 03 Sep 2024 05:56:33 -0400 X-MC-Unique: 0T9_6TcfNEqzIKpD9DR4iQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42bb5950d1aso58166275e9.2 for ; Tue, 03 Sep 2024 02:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725357392; x=1725962192; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=b7haqHBO4Bmmvo6I/VLdqWxTwNidBjBDf11sa79tfrc=; b=kQXzDadGzOzSuyUMEYgkxPbOvp+jpepu6T+HGJr9qVOxatSW+B6y5MIgclAKz//nEK HxMHsc0X/J6kIpZ6+qISsuNN87Ar7i/GEdZnnCDyIGI6rxuGZq7xjTzLyXVinNLo2h+t I9CFqkqziPLfK2xnGdRFarvEeCe7DYNnOuBjQP3iyhcAFDHhEvYdim+OYYYiZtBzur25 bMhlFHFypp/pjpix5uEuNDbkVtgQJ+LJgKFi2U0+sniBAf/fi9RMek5zr9EMc9WKQZdv JmQayvNj/6K9F3ZGQkakJpvbudupM0UdfOnW8pn9JxSVPjcokntWLL1xnp1qZO5RokNZ AB/g== X-Forwarded-Encrypted: i=1; AJvYcCUUPPAWeQsPRkHBLMHZwnqZVzJUBPBmXarA+/x7xFYx1MmJ9QUvg4zZ+ToIVKC6Ullz1qkOceR0BMk0Op4=@vger.kernel.org X-Gm-Message-State: AOJu0YxgpBrMsPjXT8pMAnHylKXGBSx9mAJYdtObRycTD20nMOViLmPv pM86ul2OzIgkVaRn2sAYpzoKTyR/jiOlgIo/QJBRUjvVCxmT7oNiZEntSgb8L1CKJ1y9EkMy4ez j2vZYBQIuyiYPhY6mU59Q4SJeq1nSk0kg2Ek6MSZiiPa7f9xDsCZLurBSGyrB1A== X-Received: by 2002:a05:600c:1391:b0:426:6f87:65fc with SMTP id 5b1f17b1804b1-42bb01c19c0mr152717105e9.17.1725357392055; Tue, 03 Sep 2024 02:56:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVW7lKj9YKjiOKwHVJ4D1KT3wg+q0YeW+RAJdjHhOcNPeiwpIfDtYn7zOkM33vLTCQfi6JkA== X-Received: by 2002:a05:600c:1391:b0:426:6f87:65fc with SMTP id 5b1f17b1804b1-42bb01c19c0mr152716745e9.17.1725357391243; Tue, 03 Sep 2024 02:56:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:7f00:8a04:4c6f:a761:af60? (p200300cbc7097f008a044c6fa761af60.dip0.t-ipconnect.de. [2003:cb:c709:7f00:8a04:4c6f:a761:af60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6e33d60sm165994925e9.43.2024.09.03.02.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 02:56:30 -0700 (PDT) Message-ID: Date: Tue, 3 Sep 2024 11:56:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Skip the reserved bootmem for compaction To: Rong Qianfeng <11065417@vivo.com> Cc: opensource.kernel@vivo.com, Rong Qianfeng , vbabka@suse.cz, mgorman@techsingularity.net, Andrew Morton , Mike Rapoport , "Kirill A. Shutemov" , Zi Yan , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240902122445.11805-1-rongqianfeng@vivo.com> <3b8994a6-cbe5-46be-86eb-b78198c31ef8@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03.09.24 09:14, Rong Qianfeng wrote: > Hi David, > > Thanks very much for the detailed comments and explanations! > > 在 2024/9/2 21:45, David Hildenbrand 写道: >> On 02.09.24 14:24, Rong Qianfeng wrote: >>> Reserved pages are basically non-lru pages. This kind of memory can't be >>> used as migration sources and targets, skip it can bring some >>> performance >>> benefits. >> >> Any numbers? :) > > I am still thinking about how to design test cases. If you have any good > suggestions,  please tell me. Thank you very much. Well, you claim that it can bring performance improvement, so it's your responsibility to prove it :) I have real idea how you could measure that, sorry. This change will make the code more complicated (and as raised, there are some corner cases not handled yet). So it's better worth the price. :) [...] > >> >> >> What about free_reserved_page() ? There might be more, though >> (kimage_free_pages()). You have to take a look at all functions where we >> clear PageReserved. > > Thanks for your reminder, I found that I missed a lot of functions. > Maybe a better choice is to clear PB_migrate_skip in free_reserved_page() > to reduce the amount of modification. Hm, maybe. At least for free_reserved_area() it would be beneficial to minimize the per-page handling. -- Cheers, David / dhildenb