From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BB932720C for ; Wed, 8 Apr 2026 04:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775622250; cv=none; b=S2o9DNdkudO/qGQg4qvuyXu1JBp04h26qRTknb36zi92qZB51baixwH6Loc3G+84rkouI5lHlt3rZo5xXGUsHM/B6gm6xfFLl2lqP2vYgEMPnuw/d9H8Ux324e+Odg+Vn6Lkd9rhHj3RD8WkV1BZ7uF0Kox7c2WQapJuvEMtY3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775622250; c=relaxed/simple; bh=IJOgYgOKLfzsduMNOuNRKBK2CZadWAfXKCim+jSb6Mw=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=aoQgOdxBwf0JGCR4rxdLmztGg3oHqaJ+vlF2Uet6nVl5xgBFVbQIMnKdoNq4oYXfwfG8PUCENPtDZSaaWuROzgS/Ezid0oB9TN1CgeAHp4x8+fjs1VrMNThg4VKAVV3pC9rIjiwBAu3RVU/QWV3OPuP2qX2zrjVqs1qoYhjLRbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KWJ1oFDv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dj/acHfi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KWJ1oFDv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dj/acHfi" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637NfXpr1259200 for ; Wed, 8 Apr 2026 04:24:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PbbVj97jX5V7I3ImftwwIPW7XZwhvJYdUHnJ5ygLavk=; b=KWJ1oFDvBOEaTnhR BWmB1yLCX5RwdWjYBaEOGjFZFIDqkb8Oz6GLfMN9BBOC7FtR7ZspZqfxiOnvWH59 /iQc6FMDBeRamRknp7VJNNWfBbpIe5DkQme18WyLa0w4CqSWky1+2XwXCKiKslK1 bI2MES2PDg4Fyt5eUyL0/kHWzX3f+F0XLL2pqCC2idhRAaih8DbE2F0uanY76TRp 4aVH8X0lQC9OtcLB9I5KcXHTdYRsZk8JaWBr5OS34Iy/9wAXQWq0GocGPFq9HBSm G9TivZd/0fZXx75KMp13yMT4C88mGY9ZyBXuuXOqiSRsp6WEjfp1KoPrRWqGVSlI VvET6Q== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddbttrr14-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 04:24:07 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c70f19f0f37so317741a12.0 for ; Tue, 07 Apr 2026 21:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775622247; x=1776227047; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=PbbVj97jX5V7I3ImftwwIPW7XZwhvJYdUHnJ5ygLavk=; b=dj/acHfiAJNkPMNOt28IUVg/46tuwCEJy2tFE54ThTD2nQBnvjYYtSWEKZWpDC+Ksp /dk1h/0PxqfQiCtoaVzBhjrG7els0cHWw4VZ/NJLgifpFcHQH0ai5Aj0+faOASz1aPrz p7rMVDo4UlYRVb4khP1hP6Wd1pgnZEjwz9lvYQRG36KNkGwl1serWXc8tGems3Hv+nv9 L08Z5vZvWfaWEVeG8A1A/1zEmWVJnH4POLhNgZn2KjjxsbSHVxMZ//AVRwZBtqW7cLLK MQ7EEraesKTGHRylKqGcbu1dekMlS0MDVfioViE+JXIrTbwe5P0Cqu2+pJVBSqg6NIgX 2WXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775622247; x=1776227047; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PbbVj97jX5V7I3ImftwwIPW7XZwhvJYdUHnJ5ygLavk=; b=Z0blCfmwVf9273kpNx8PM9Fzltlm72ySt5mOj2RX4R+6f9yIwrkb1y2a1+ilLA5qxk TvOQYsES1WDrFNN3XQKn3H4/mTNWBdcNhY8nTXq9M3FHSyRuDCRjivqPYz2jpvLPDKM+ TR3bp4ltt366gOI9BHWKuDTafIxvTwLu00R96yfUBXs1b1DAnUMve7Rybn2vBWI9WfkF WCWX2hBBdFTB0Ow2RgeEevFm4YoDNgW4b01vVOH5cyPXQ/BCX5eUPsLD2Spi5BwY1zRE 96FkdR5r8biBQzETfiqGCK1gkfhCfOe99hy0mCfChfTLAiy/eyeaMgyu1Oemnnyp6HBg 4Gbg== X-Forwarded-Encrypted: i=1; AJvYcCW7NcdqUSBrWjGS006lA5zNNnBzuY3aKDRKlHf/J+frfl06AOwr3+pl2AGpTc9Lj/f9QbId03PMM+4jZwM=@vger.kernel.org X-Gm-Message-State: AOJu0YyzH44e7p+eE6gUkNqVoaqi5HfbpdTe4orfZ+B6DXCNVJMERx3t F7YsdaXDD9n+zjl7+O/xWD+TUHpJ2ot4oO/TNIMDoitCJdT5g80CvCCc7aafdKyp9lYs2e8hi1H 97xluvvCiF+gXEK2pMSObCjsKp5yAMS9gFWvdfp9oz/ir8ZEzpaMS7+3xTKuKiygaZ4/fs5S9x5 M= X-Gm-Gg: AeBDieviznENKQCT3Y8bSbBS7fCAfNcbfagq6SH+4DMzxoLyvll4TktkCfQrNmCg0oz lxkWaqhpusOOGFAoRUOob/ulDIU/AANGruKDh86613FWOYRM3PIt4h3IfI1Dwh/EQmWD6KZK5HZ U3qL7wQRHPTfkTClWnXjii8Nk7A5Owzctp8kR3NGzKnRuyXIcqga0q44q7cPYkCVGSqqLVvxxRV MCzpe+my/FbcdHxAcS0WfucdbZ5ne3jo+oENpkuign8Qb9JMleD5k3k7WsoLZRpP6aDtWSkTqm8 4l5pHWc0oNktWczvIGqZyps9IZIznEaZ02SUCFyqJ+Y7nSFVi7CMGs/ZCX6c/NB00iQP3WKA+TO jDM+dVnc6RNY6iTgX4h3eJsofYU5J62c/If8njB07ZWPedjJF7Q== X-Received: by 2002:a05:6a20:a109:b0:39b:897c:6f8d with SMTP id adf61e73a8af0-39f2d9e7529mr18743269637.16.1775622246693; Tue, 07 Apr 2026 21:24:06 -0700 (PDT) X-Received: by 2002:a05:6a20:a109:b0:39b:897c:6f8d with SMTP id adf61e73a8af0-39f2d9e7529mr18743247637.16.1775622246199; Tue, 07 Apr 2026 21:24:06 -0700 (PDT) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c6563597sm20655477a12.16.2026.04.07.21.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 21:24:05 -0700 (PDT) Subject: Re: [PATCH] mmc: host: sdhci-msm: Fix the wrapped key handling To: Ulf Hansson Cc: Dmitry Baryshkov , adrian.hunter@intel.com, ebiggers@kernel.org, abel.vesa@linaro.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260403105949.1007447-1-neeraj.soni@oss.qualcomm.com> From: Neeraj Soni Message-ID: Date: Wed, 8 Apr 2026 09:54:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: v_xHHiYcvhr2fL5sbmcoZldHyY090QEz X-Proofpoint-GUID: v_xHHiYcvhr2fL5sbmcoZldHyY090QEz X-Authority-Analysis: v=2.4 cv=TOt1jVla c=1 sm=1 tr=0 ts=69d5d867 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=asX3J4iNEGbadXDLWWsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDAzNiBTYWx0ZWRfX2m3uUzn4Jx6p 37tmV4LBQ4i7gTS0kUTIMiTBMGS9yyKODx3zDIBbHJengodGoGGVvxH4ZU9vB6KAFBYrPZOzYFR mCGawQi+IZqge8DexN3YzQATGLj+/PvmNp5TLpooQ/MoKQxnkzwsOjLGwTZToq7FZa4AzFxP5Yt RiblghJK1GzU+MEoKChUgnJkLk7SVUZJIdCUY2qcHWzi5WTMF8jpYYZ3f88fp7350RB9+4fPffh dWpXBrwz2IA9PqaqW/WjDu2SQWhkt8kotvHzy+1+OdUpQsblyYFGvWS0J7aX0s4HqXp3jixJsJo lK/ciDYC+8khu+UP4EwuTCXp681hMDbMfoYuD+bxi2hDmNQuiwwA7VTqjkLCJ8OaLcU24ACvhQv B9sy6d/SSfp49G/4aGiIs2GoqEChVmGwXIqNN/9uL+IpDw8WAiwNlmw0ry/W7hPlUgt28aSeRq+ LyuldfiFbeAmH7/G22g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_02,2026-04-07_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080036 On 4/6/2026 7:17 PM, Ulf Hansson wrote: > On Mon, 6 Apr 2026 at 09:29, Neeraj Soni wrote: >> >> >> >> On 4/4/2026 1:30 AM, Dmitry Baryshkov wrote: >>> On Fri, Apr 03, 2026 at 04:29:49PM +0530, Neeraj Soni wrote: >>>> This change was originally intended to land with the patch series: >>>> "mmc: host: sdhci-msm: Add support for wrapped keys". The fix was present >>>> till v4 but was accidentally dropped in v5 while rebasing. >>> >>> Don't describe what is being changed or what was intended. Please >>> describe, why you are performing the change. I.e. what is broken. >>> >> Ack. >> >>> Also, likely you missed the Fixes tag. >>> >> The SHA-1 ID for "mmc: host: sdhci-msm: Add support for wrapped keys" >> is not yet available in tree so i did not add the "Fixes:" tag: >> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes > > The commit should be available on the next branch in my mmc tree > git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next > > commit fd78e2b582a0 ("mmc: sdhci-msm: Add support for wrapped keys") > Ack. I will post v2 with "Fixes:" updated. > [...] > > Kind regards > Uffe > Regards Neeraj