mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mark Brown <broonie@kernel.org>, Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	Joey Gouly <joey.gouly@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>
Cc: Dave Martin <Dave.Martin@arm.com>, Fuad Tabba <tabba@google.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v7 11/29] KVM: arm64: Document the KVM ABI for SME
Date: Thu, 21 Aug 2025 23:50:58 -0700	[thread overview]
Message-ID: <f87145e5-5a86-4ccf-96ac-61e16e894b81@infradead.org> (raw)
In-Reply-To: <20250822-kvm-arm64-sme-v7-11-7a65d82b8b10@kernel.org>



On 8/21/25 6:53 PM, Mark Brown wrote:
> SME, the Scalable Matrix Extension, is an arm64 extension which adds
> support for matrix operations, with core concepts patterned after SVE.
> 
> SVE introduced some complication in the ABI since it adds new vector
> floating point registers with runtime configurable size, the size being
> controlled by a prameter called the vector length (VL). To provide control

                  parameter

> of this to VMMs we offer two phase configuration of SVE, SVE must first be
> enabled for the vCPU with KVM_ARM_VCPU_INIT(KVM_ARM_VCPU_SVE), after which
> vector length may then be configured but the configurably sized floating
> point registers are inaccessible until finalized with a call to
> KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_SVE) after which the configurably sized
> registers can be accessed.
> 
...
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  Documentation/virt/kvm/api.rst | 117 +++++++++++++++++++++++++++++------------
>  1 file changed, 82 insertions(+), 35 deletions(-)
> 
> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> index 6aa40ee05a4a..71f46b342641 100644
> --- a/Documentation/virt/kvm/api.rst
> +++ b/Documentation/virt/kvm/api.rst

> @@ -2600,12 +2600,12 @@ Specifically:
>    0x6020 0000 0010 00d5 FPCR        32  fp_regs.fpcr
>  ======================= ========= ===== =======================================
>  
> -.. [1] These encodings are not accepted for SVE-enabled vcpus.  See
> -       :ref:`KVM_ARM_VCPU_INIT`.
> +.. [1] These encodings are not accepted for SVE enabled vcpus.  See

                                               SVE-enabled
was good.

> +       :ref:`KVM_ARM_VCPU_INIT`.  They are also not accepted when SME is
> +       enabled without SVE and the vcpu is in streaming mode.
>  

> @@ -2665,19 +2675,25 @@ follows::
>  	/* Vector length vq * 16 bytes not supported */
>  
>  .. [2] The maximum value vq for which the above condition is true is
> -       max_vq.  This is the maximum vector length available to the guest on
> -       this vcpu, and determines which register slices are visible through
> -       this ioctl interface.
> +       max_vq.  This is the maximum vector length currently available to
> +       the guest on this vcpu, and determines which register slices are
> +       visible through this ioctl interface.
> +
> +       If SME is supported then the max_vq used for the Z and P registers
> +       then while SVCR.SM is 1 this vector length will be the maximum SME

I'm having trouble parsing the 2 lines above.

> +       vector length available for the guest, otherwise it will be the
> +       maximum SVE vector length available.
>  
>  (See Documentation/arch/arm64/sve.rst for an explanation of the "vq"
>  nomenclature.)
>  

> @@ -3520,7 +3537,7 @@ Possible features:
>  	        initial value of this pseudo-register indicates the best set of
>  	        vector lengths possible for a vcpu on this host.
>  
> -	   * Before KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_SVE):
> +	   * Before KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_VEC}):

		Why the inserted '}', please?

>  
>  	      - KVM_RUN and KVM_GET_REG_LIST are not available;
>  
> @@ -3533,11 +3550,40 @@ Possible features:
>  	        KVM_SET_ONE_REG, to modify the set of vector lengths available
>  	        for the vcpu.
>  
> -	   * After KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_SVE):
> +	   * After KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_VEC):
>  
>  	      - the KVM_REG_ARM64_SVE_VLS pseudo-register is immutable, and can
>  	        no longer be written using KVM_SET_ONE_REG.
>  
> +	- KVM_ARM_VCPU_SME: Enables SME for the CPU (arm64 only).
> +	  Depends on KVM_CAP_ARM_SME.
> +	  Requires KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_VEC):
> +
> +	   * After KVM_ARM_VCPU_INIT:
> +
> +	      - KVM_REG_ARM64_SME_VLS may be read using KVM_GET_ONE_REG: the
> +	        initial value of this pseudo-register indicates the best set of
> +	        vector lengths possible for a vcpu on this host.
> +
> +	   * Before KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_VEC}):

	ditto: inserted '}'

> +
> +	      - KVM_RUN and KVM_GET_REG_LIST are not available;
> +
> +	      - KVM_GET_ONE_REG and KVM_SET_ONE_REG cannot be used to access
> +	        the scalable architectural SVE registers
> +	        KVM_REG_ARM64_SVE_ZREG(), KVM_REG_ARM64_SVE_PREG() or
> +	        KVM_REG_ARM64_SVE_FFR, the matrix register
> +		KVM_REG_ARM64_SME_ZA() or the LUT register KVM_REG_ARM64_ZT();
> +
> +	      - KVM_REG_ARM64_SME_VLS may optionally be written using
> +	        KVM_SET_ONE_REG, to modify the set of vector lengths available
> +	        for the vcpu.
> +
> +	   * After KVM_ARM_VCPU_FINALIZE(KVM_ARM_VCPU_VEC):

-- 
~Randy


  reply	other threads:[~2025-08-22  6:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  1:53 [PATCH v7 00/29] KVM: arm64: Implement support " Mark Brown
2025-08-22  1:53 ` [PATCH v7 01/29] arm64/sysreg: Update SMIDR_EL1 to DDI0601 2025-06 Mark Brown
2025-08-22  1:53 ` [PATCH v7 02/29] arm64/fpsimd: Update FA64 and ZT0 enables when loading SME state Mark Brown
2025-08-22  1:53 ` [PATCH v7 03/29] arm64/fpsimd: Decide to save ZT0 and streaming mode FFR at bind time Mark Brown
2025-08-22  1:53 ` [PATCH v7 04/29] arm64/fpsimd: Check enable bit for FA64 when saving EFI state Mark Brown
2025-08-22  1:53 ` [PATCH v7 05/29] arm64/fpsimd: Determine maximum virtualisable SME vector length Mark Brown
2025-08-22  1:53 ` [PATCH v7 06/29] KVM: arm64: Introduce non-UNDEF FGT control Mark Brown
2025-08-22  1:53 ` [PATCH v7 07/29] KVM: arm64: Pay attention to FFR parameter in SVE save and load Mark Brown
2025-08-22  1:53 ` [PATCH v7 08/29] KVM: arm64: Pull ctxt_has_ helpers to start of sysreg-sr.h Mark Brown
2025-08-22  1:53 ` [PATCH v7 09/29] KVM: arm64: Move SVE state access macros after feature test macros Mark Brown
2025-08-22  1:53 ` [PATCH v7 10/29] KVM: arm64: Rename SVE finalization constants to be more general Mark Brown
2025-08-22  1:53 ` [PATCH v7 11/29] KVM: arm64: Document the KVM ABI for SME Mark Brown
2025-08-22  6:50   ` Randy Dunlap [this message]
2025-08-22  1:53 ` [PATCH v7 12/29] KVM: arm64: Define internal features " Mark Brown
2025-08-22  1:53 ` [PATCH v7 13/29] KVM: arm64: Rename sve_state_reg_region Mark Brown
2025-08-22  1:53 ` [PATCH v7 14/29] KVM: arm64: Store vector lengths in an array Mark Brown
2025-08-22  1:53 ` [PATCH v7 15/29] KVM: arm64: Implement SME vector length configuration Mark Brown
2025-08-22  1:53 ` [PATCH v7 16/29] KVM: arm64: Support SME control registers Mark Brown
2025-08-22  1:53 ` [PATCH v7 17/29] KVM: arm64: Support TPIDR2_EL0 Mark Brown
2025-08-22  1:53 ` [PATCH v7 18/29] KVM: arm64: Support SME identification registers for guests Mark Brown
2025-08-22  1:53 ` [PATCH v7 19/29] KVM: arm64: Support SME priority registers Mark Brown
2025-08-22  1:53 ` [PATCH v7 20/29] KVM: arm64: Provide assembly for SME register access Mark Brown
2025-08-22  1:53 ` [PATCH v7 21/29] KVM: arm64: Support userspace access to streaming mode Z and P registers Mark Brown
2025-08-22  1:53 ` [PATCH v7 22/29] KVM: arm64: Flush register state on writes to SVCR.SM and SVCR.ZA Mark Brown
2025-08-22  1:53 ` [PATCH v7 23/29] KVM: arm64: Expose SME specific state to userspace Mark Brown
2025-08-22  1:53 ` [PATCH v7 24/29] KVM: arm64: Context switch SME state for guests Mark Brown
2025-08-22  1:53 ` [PATCH v7 25/29] KVM: arm64: Handle SME exceptions Mark Brown
2025-08-22  1:53 ` [PATCH v7 26/29] KVM: arm64: Expose SME to nested guests Mark Brown
2025-08-22  1:53 ` [PATCH v7 27/29] KVM: arm64: Provide interface for configuring and enabling SME for guests Mark Brown
2025-08-22  1:53 ` [PATCH v7 28/29] KVM: arm64: selftests: Add SME system registers to get-reg-list Mark Brown
2025-08-22  1:53 ` [PATCH v7 29/29] KVM: arm64: selftests: Add SME to set_id_regs test Mark Brown
2025-09-01 12:44 ` [PATCH v7 00/29] KVM: arm64: Implement support for SME Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f87145e5-5a86-4ccf-96ac-61e16e894b81@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Dave.Martin@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=joey.gouly@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®