From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97BA8C433EF for ; Mon, 21 Feb 2022 10:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355308AbiBUKmk (ORCPT ); Mon, 21 Feb 2022 05:42:40 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355271AbiBUKkF (ORCPT ); Mon, 21 Feb 2022 05:40:05 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99BF1F35 for ; Mon, 21 Feb 2022 02:02:03 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id c6so25385054edk.12 for ; Mon, 21 Feb 2022 02:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=kMIEQ6EmXrcKF9QOgwi4JP+rN/GpqbWH/lqcMa8liiA=; b=QQbUtc7TFLde+vu666fP1jpn3ZV0FX04icLIemzeQRGi911a0jMrdL8vJdmL3pepEi 6okCY+lM3vY8PCpbLkL0CN1RQ4ccaCqElG9sY+NLCKb3+FcPSFZopQ52JY04uQApqnML Q4cY5EH3iUC6W+Su0VttBmEwgrjlKWAQYvTGBsWINSb5FBW79dNR5AY4+0ePzW4cOSBz Q0sUk5AIW65Wwz/1e5NuOnsKKgKEjkWiLU4zNXi8yPSJJtSQpBUtIyP/KtVR7SCVX7xF /nGHil8Eqxvg9T8QZOz9HbijZq4GNAT7JXWKEOQyr7dui6njbDWHiKdx9LVYzym+qEK1 yy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kMIEQ6EmXrcKF9QOgwi4JP+rN/GpqbWH/lqcMa8liiA=; b=JHX6IYTlgCKSpny81UQ9wUX53Dnp3P66UUDMLkfW4cX3fBRpmOy0OTFUaNWRgzC8nE 5pplu9Bkupkx2xXeRH26zAaaAMQZDYb6nRPLosA1PPtok8S2U00RvoGXQ3RFv+SpBgrw FE6SchT82k6kaVGst3EwNbusffKeH8fzlaK2+nIBv4tWhFaYaQX1ZKIwcuJNb1385NVM 18xeWXxnsZDQAye98S7voTn2KkkWyTktodvWb3YX6avjVluroKTKdRc4TEPR7HB6mQh5 x0xXxaWHM+0H+8Rj2X+EvYEzDd8CzqdBQZosmxBfEfF/aljFFRojra5mHl1QFzxdTeak M/4w== X-Gm-Message-State: AOAM531dMDwIj5N54dgUoXRcVDa6Wd4g3sWKOpH6XmWMvSFjZCVlgrAy 0KZAH5VzDLIhw4gCfnKb5B8QUA== X-Google-Smtp-Source: ABdhPJwoxhTQ66ov81uyxAEEkMdXe2eNB3Eu5awgfYyKsjlTo0UYbaWCPMaaN9gxOKo3lAv87zWjkw== X-Received: by 2002:a50:f686:0:b0:410:e352:e61a with SMTP id d6-20020a50f686000000b00410e352e61amr19883345edn.23.1645437721836; Mon, 21 Feb 2022 02:02:01 -0800 (PST) Received: from ?IPV6:2a02:768:2307:40d6::f9e? ([2a02:768:2307:40d6::f9e]) by smtp.gmail.com with ESMTPSA id gs6sm702985ejb.17.2022.02.21.02.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 02:02:01 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 11:02:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] iio: adc: xilinx-ams: Use devm_delayed_work_autocancel() to simplify code Content-Language: en-US To: Jonathan Cameron , Christophe JAILLET Cc: Anand Ashok Dumbre , Lars-Peter Clausen , Michal Simek , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <2626e6a057e40cd2271ef0e5f81d12e607bad5b4.1644776929.git.christophe.jaillet@wanadoo.fr> <20220220114552.53fedd33@jic23-huawei> From: Michal Simek In-Reply-To: <20220220114552.53fedd33@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2/20/22 12:45, Jonathan Cameron wrote: > On Sun, 13 Feb 2022 19:29:05 +0100 > Christophe JAILLET wrote: > >> Use devm_delayed_work_autocancel() instead of hand writing it. This is >> less verbose and saves a few lines of code. >> >> devm_delayed_work_autocancel() uses devm_add_action() instead of >> devm_add_action_or_reset(). This is fine, because if the underlying memory >> allocation fails, no work has been scheduled yet. So there is nothing to >> undo. >> >> Signed-off-by: Christophe JAILLET > Looks good to me, but I'd ideally like some input from someone familiar with > the driver. Anand told me that the change is fine that's why here is my Acked-by: Michal Simek Jonathan: Anand decided to do change in his carrier that's why that emails won't go through. But I am still around if you need something xilinx/amd to test. Thanks, Michal