From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ACDB848EC86; Mon, 19 Oct 2026 07:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792396174; cv=none; b=Hae84Dm+XUeIDv4sLg8AiCLnayS2YEJWrqUEEolrn2/uQqVL0ae/MUtZ8uNa6avaB4a1YkDOpAYlQDFqFSKneuMuvQuy6sUuR9GAem4+HnK3P35EXL4bimdbap/2y105uhQX96LA9A/qfyTZO0N0mbjxUkOGsPvJUwSsCvW2vGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792396174; c=relaxed/simple; bh=9m8ND55bE6LAT0sYf5FjzlMSmT/c2rxHNWt6aZRTktA=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=eAr4WgQBsb0jq0kq1hMGdhT6n58UO7MZ9ugjAzRRV6aLdqKdlvAOz3Edvf7fCFFFk5dBYw9KOw4LqME2NxkdRAfKveAx+klXBVTukO33ksglSsMarIwScuhurObkD+BtRwfoKdo6kIM2rhYPNdVdNJ1ayq/tKnNI0M+6Fb12evg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [123.138.236.242]) by gateway (Coremail) with SMTP id _____8CxutGFy9VqVzcXAA--.2204S3; Mon, 19 Oct 2026 15:49:25 +0800 (CST) Received: from [127.0.0.1] (unknown [123.138.236.242]) by front1 (Coremail) with SMTP id qMiowJDxg8yEy9VqmO8tAA--.3247S2; Mon, 19 Oct 2026 15:49:25 +0800 (CST) Subject: Re: [PATCH bpf-next v2] selftests/bpf: Use snake_case for subtest descriptions in jit_insns_arena.c From: Tiezhu Yang To: Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261019040106.27309-1-yangtiezhu@loongson.cn> <84434f7a-1c38-03ea-3062-8e8cf364fd4e@loongson.cn> Message-ID: Date: Mon, 19 Oct 2026 15:49:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <84434f7a-1c38-03ea-3062-8e8cf364fd4e@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:qMiowJDxg8yEy9VqmO8tAA--.3247S2 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoWxZFyUXFWDArykXr4xtw1rXwc_yoW5uF4fpF Wkta1xtrWxJ3WSvw4kZw18W3WF9Fn5JFn8Gr1rXrW5urs8JF1aqryxKF1YkF90grWxZr1Y ka12yrZFgF17CrcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9ab4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E 14v26r126r1DMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4 CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1x MIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF 4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsG vfC2KfnxnUUI43ZEXa7IU8PCzJUUUUU== On 2026/10/19 下午3:18, Tiezhu Yang wrote: > On 2026/10/19 下午2:47, Daniel Borkmann wrote: >> On 10/19/26 6:01 AM, Tiezhu Yang wrote: >>> Normalize two inline assembly test descriptions in jit_insns_arena.c >>> from space-separated strings to snake_case. >>> >>> It is done for consistency with other neighboring subtests registered >>> in test_jit_insns() (such as alu_imm, alu_reg, etc.). This also makes >>> it convenient to execute these subtests directly from the command line >>> without being forced to use shell quoting. >>> >>> Otherwise, unquoted shell word-splitting causes test_progs to reject >>> the extra arguments before the filter code runs: >>> >>> $ sudo ./test_progs -t jit_insns/arena access with zero offset >>> Usage: test_progs [OPTION...] >>> Try `test_progs --help' or `test_progs --usage' for more information. >>> >>> $ sudo ./test_progs -t jit_insns/cast to a user address >>> Usage: test_progs [OPTION...] >>> Try `test_progs --help' or `test_progs --usage' for more information. >>> >>> Signed-off-by: Tiezhu Yang >> Do these not work already? >> >>    ./test_progs -t jit_insns/arena_zero_off >>    ./test_progs -t jit_insns/cast_to_user > > Yes, they work. > > I misunderstood that the name is "cast to a user address" in the output > rather than "cast_to_user" before, there is difference between the > description and the name. > > Something like this: > > $ sudo ./test_progs -t jit_insns/cast_to_user > #191/2   jit_insns/cast to a user address:OK > #191     jit_insns:OK > #192     jit_insns_blinded:OK > Summary: 2/1 PASSED, 0 SKIPPED, 0/0 FAILED > > Anyway, if this patch is not necessary, please ignore it. By the way, IMO, it is better to remove the __description strings, so that the test output style matches the actual program names like other neighboring subtests. This prevents developers from being misled into copying space-separated strings from the standard output. What do you think about something like this? diff --git a/tools/testing/selftests/bpf/progs/jit_insns_arena.c b/tools/testing/selftests/bpf/progs/jit_insns_arena.c index b396d5aefb5a..95736eae2a58 100644 --- a/tools/testing/selftests/bpf/progs/jit_insns_arena.c +++ b/tools/testing/selftests/bpf/progs/jit_insns_arena.c @@ -34,7 +34,6 @@ struct { #if defined(__BPF_FEATURE_ADDR_SPACE_CAST) SEC("syscall") -__description("arena access with zero offset") __success __retval(0) int arena_zero_off(void *ctx) { @@ -82,7 +81,6 @@ int arena_zero_off(void *ctx) } SEC("syscall") -__description("cast to a user address") __success __retval(0) int cast_to_user(void *ctx) { The output is something like this: $ sudo ./test_progs -t jit_insns/arena_zero_off | tail -3 #191/1 jit_insns/arena_zero_off:FAIL #191 jit_insns:FAIL Summary: 1/0 PASSED, 0 SKIPPED, 1/1 FAILED $ sudo ./test_progs -t jit_insns/cast_to_user #191/2 jit_insns/cast_to_user:OK #191 jit_insns:OK #192 jit_insns_blinded:OK Summary: 2/1 PASSED, 0 SKIPPED, 0/0 FAILED The main goal here is that if a test fails, developers can immediately recognize the exact, actionable test name from the standard output and rerun it without any confusion. Thanks, Tiezhu