From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753172AbcEIMDj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 May 2016 08:03:39 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:29267 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751002AbcEIMDi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 May 2016 08:03:38 -0400
Subject: Re: [PATCH] f2fs: introduce f2fs_reserve_blocks to speedup fallocate
To: Jaegeuk Kim <jaegeuk@kernel.org>
References: <20160507081634.96677-1-yuchao0@huawei.com>
 <20160507174401.GA92790@jaegeuk.gateway>
CC: <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
From: Chao Yu <yuchao0@huawei.com>
Message-ID: <f877ae36-1293-ddc6-aa36-da129d5df836@huawei.com>
Date: Mon, 9 May 2016 20:03:18 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20160507174401.GA92790@jaegeuk.gateway>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.134.22.195]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020204.57307C8D.01DB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: f62e1eca345d8aa57eb97ba5dbc98663
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jaegeuk,

On 2016/5/8 1:44, Jaegeuk Kim wrote:
> Hi Chao,
> 
> Good catch, but I've been already testing a patch which uses f2fs_map_blocks().
> We don't need to add whole things redundantly. :)

Good, your patch looks quite clean especially the size updating part! :)

However, I think there are still room of performance improvement, I wrote a
patch for that based on your patch, could you check that?

Thanks,