mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leilk Liu <leilk.liu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-spi@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH V2 5/6] dt-bindings: spi: support spi-hclk
Date: Sat, 26 Feb 2022 11:14:34 +0800	[thread overview]
Message-ID: <f879ce25aab1d7e4a413455cb2a2454930cc9164.camel@mediatek.com> (raw)
In-Reply-To: <YhkoEJiLMs8jfUAm@robh.at.kernel.org>

On Fri, 2022-02-25 at 13:03 -0600, Rob Herring wrote:
> On Mon, Feb 21, 2022 at 12:07:16PM +0800, Leilk Liu wrote:
> > this patch support spi-hclk.
> > 
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2
> > ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > index 241c0f5880d3..6920ced5451e 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > @@ -55,12 +55,14 @@ properties:
> >        - description: clock used for the parent clock
> >        - description: clock used for the muxes clock
> >        - description: clock used for the clock gate
> > +      - description: clock used for the AHB bus, this clock is
> > optional
> 
> Not optional unless you have minItems.
> 
OK, I'll add minItems,thanks for your comment.

> >  
> >    clock-names:
> 
>        minItems: 3
> 
Got it, thanks

> 
> >      items:
> >        - const: parent-clk
> >        - const: sel-clk
> >        - const: spi-clk
> > +      - const: spi-hclk
> >  
> >    mediatek,pad-select:
> >      $ref: /schemas/types.yaml#/definitions/uint32-array
> > -- 
> > 2.25.1
> > 
> > 


  reply	other threads:[~2022-02-26  3:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21  4:07 [PATCH V2 0/6] spi: mediatek: add single/quad mode support Leilk Liu
2022-02-21  4:07 ` [PATCH V2 1/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with single mode Leilk Liu
2022-02-25 18:57   ` Rob Herring
2022-02-21  4:07 ` [PATCH V2 2/6] spi: mediatek: add IPM single mode design support Leilk Liu
2022-02-22 10:09   ` AngeloGioacchino Del Regno
2022-02-23  1:51     ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 3/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with quad mode Leilk Liu
2022-02-25 19:01   ` Rob Herring
2022-02-26  3:24     ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 4/6] spi: mediatek: add spi memory support Leilk Liu
2022-02-22 10:49   ` AngeloGioacchino Del Regno
2022-02-23  1:59     ` Leilk Liu
2022-03-05  8:22       ` Leilk Liu
2022-02-21  4:07 ` [PATCH V2 5/6] dt-bindings: spi: support spi-hclk Leilk Liu
2022-02-25 19:03   ` Rob Herring
2022-02-26  3:14     ` Leilk Liu [this message]
2022-02-21  4:07 ` [PATCH V2 6/6] spi: mediatek: " Leilk Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f879ce25aab1d7e4a413455cb2a2454930cc9164.camel@mediatek.com \
    --to=leilk.liu@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®