From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: "open list:PCIE DRIVER FOR QUALCOMM MSM"
<linux-pci@vger.kernel.org>,
"open list:PCIE DRIVER FOR QUALCOMM MSM"
<linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] PCI: qcom: Don't unroll init if init fails
Date: Thu, 3 Aug 2017 12:24:19 +0300 [thread overview]
Message-ID: <f882d2eb-b531-966f-04ce-06b722faee92@mm-sol.com> (raw)
In-Reply-To: <20170716063947.3272-2-bjorn.andersson@linaro.org>
Hi,
The patch looks correct.
On 07/16/2017 09:39 AM, Bjorn Andersson wrote:
> When the init op fails it will restore the state of the resources, so we
> should not disable them one more time when this happens.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pci/dwc/pcie-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index d15657dc3990..7b703741a3fd 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -901,7 +901,7 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
>
> ret = pcie->ops->init(pcie);
> if (ret)
> - goto err_deinit;
> + return ret;
>
> ret = phy_power_on(pcie->phy);
> if (ret)
>
next prev parent reply other threads:[~2017-08-03 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 6:39 [PATCH 1/3] PCI: dwc: Handle host_init failures Bjorn Andersson
2017-07-16 6:39 ` [PATCH 2/3] PCI: qcom: Don't unroll init if init fails Bjorn Andersson
2017-08-03 9:24 ` Stanimir Varbanov [this message]
2017-07-17 11:18 ` [PATCH 1/3] PCI: dwc: Handle host_init failures Joao Pinto
2017-07-17 19:28 ` Jingoo Han
2017-08-03 21:19 ` Bjorn Helgaas
2017-07-16 6:41 [PATCH 2/3] PCI: qcom: Don't unroll init if init fails Bjorn Andersson
2017-08-02 21:39 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f882d2eb-b531-966f-04ce-06b722faee92@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome