mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Cc: "Stockmann, Lukas" <lukas.stockmann@siemens.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: pcf85063: do a SW reset after rtc power fail
Date: Fri, 1 Mar 2024 11:10:12 +0000	[thread overview]
Message-ID: <f882d7964d2d905288bcb7d01421b5eb5bd1b6f2.camel@siemens.com> (raw)
In-Reply-To: <2024022922080217cbe165@mail.local>

Hello Alexandre!

Thank you for your review!

On Thu, 2024-02-29 at 23:08 +0100, Alexandre Belloni wrote:
> > "There is a low probability that some devices will have corruption of the
> > registers after the automatic power-on reset if the device is powered up
> > with a residual VDD level. It is required that the VDD starts at zero volts

...

> Doing this in probe is putting a band-aid on a wooden leg as you are not
> guaranteed you will have a probe to catch this case. This should be
> rather done in pcf85063_rtc_set_time but it comes with its own set of

As I read the datasheet (quoted above) the device has "peculiarities" in
Power-On-Reset implementation, namely it's not always detected. In our
applications (and probably most other designs) it's the startup of Linux
with driver probe, which immediately follows the Power-On event
(which had some residue voltage because of large capacitors, whatsoever).

It is an issue we really observed and solved in 100% cases for our design.
I just thought it might be useful for others because it's also documented
by NXP. Maybe not as separate errata document and it's a bit hidden in
datasheet but I'd ultimately consider it a POR errata.

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

  reply	other threads:[~2024-03-01 11:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 13:14 A. Sverdlin
2024-02-29 22:08 ` Alexandre Belloni
2024-03-01 11:10   ` Sverdlin, Alexander [this message]
2024-03-15 10:03     ` Sverdlin, Alexander
2025-01-07 10:06     ` Sverdlin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f882d7964d2d905288bcb7d01421b5eb5bd1b6f2.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=lukas.stockmann@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®