Re: [PATCH] ocfs2: remove redundant assignment to pointer root_bh

[Joseph Qi <joseph.qi@linux.alibaba.com>]

On 12/28/21 9:37 AM, Colin Ian King wrote:
> Pointer root_bh is being initialized with a value that is not read,
> it is being re-assigned later on closer to its use. The early
> initialization is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index bb247bc349e4..bf9357123bc5 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -2040,7 +2040,7 @@ static void ocfs2_complete_edge_insert(handle_t *handle,
>  	int i, idx;
>  	struct ocfs2_extent_list *el, *left_el, *right_el;
>  	struct ocfs2_extent_rec *left_rec, *right_rec;
> -	struct buffer_head *root_bh = left_path->p_node[subtree_index].bh;
> +	struct buffer_head *root_bh;
>  
>  	/*
>  	 * Update the counts and position values within all the