From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC8B0C169C4 for ; Wed, 6 Feb 2019 16:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C49D20811 for ; Wed, 6 Feb 2019 16:41:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mOO6T1op" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731364AbfBFQl1 (ORCPT ); Wed, 6 Feb 2019 11:41:27 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46734 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730520AbfBFQl0 (ORCPT ); Wed, 6 Feb 2019 11:41:26 -0500 Received: by mail-lj1-f194.google.com with SMTP id v15-v6so6619334ljh.13; Wed, 06 Feb 2019 08:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fr1YRMG/sCoobZgJasTyQtPVc1+gPjd3Vq1LupEquRc=; b=mOO6T1opQvxkeYvGZcprIhe6eNG+16IBnR8IxfPNXfj9i5H5Cv1iyE0t/k6ZoDAKr2 hY2Juk/dfV3UzpXRwBpEd3ZY5eWlm3jcCpor29+HJQq3bqm+/g/lOYdvn2BQ/Y+Fln82 atyikox58hQyYCgM7vVIISK0okPP3d4mi8lxyw5obsRttHB0V3lnNoxLJUeHk2X4sr// matBAhNWLs0pe7MFnKnuzT8rgkPv+Fvyg610f6biQ+RWV+PiFIwps+dttSXyHWWPx8D+ +sZ+g6X4VQx4DeSA+u+Pbx8MJULHDePYcB4X9gR+IYjGwW1/VPTwNmhIovf99b4QkHWK Wr+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fr1YRMG/sCoobZgJasTyQtPVc1+gPjd3Vq1LupEquRc=; b=BeEjdAkcuEG/fKRuqhvxTNmwywK/tBzb9pBA6iB0fgQGa1h/pyq7Zg+llPwBLbrOM5 eagEMgj91JEe7qm03U91JxzdcqvxCZgXXBkmxyYmFL7cKWGM96SJVZb4ZTKYcB+vF/2b 9FsseoP4+h4doI2waYOcFPCk9Ai6g91ewtkk/yZiPVHKDa2fx6HAGjs2VYTv44QgTHDI H2Lb9vxm/mHslyBP1LibKGn+mcSakR/pAWxUT/WhmH9dBRJOIj+gqTYRA7qL4LHVuLrO 2yUsPgCh5OAQZe5T6ZW1rIKcdMrRAs+2mER+Rae3wQ6TxmtdhDdLImt/Bu+BkTuV3AbZ kvsw== X-Gm-Message-State: AHQUAubZM4cvKvNZyeGpWY3MFIFa8BkxpcC2xUmFXV8rkWD7IyDXnfps ctfCabELTOMfdxP6dMFzF+E319iF X-Google-Smtp-Source: AHgI3IbeFuTz9VMGHFQj5sJ7PEznMGCFhmfndySVjZ6saiiiw557JH0a3XYgEX7H8nOxuhUanERuww== X-Received: by 2002:a2e:4601:: with SMTP id t1-v6mr7092733lja.111.1549471283372; Wed, 06 Feb 2019 08:41:23 -0800 (PST) Received: from [192.168.2.145] (ppp91-79-175-49.pppoe.mtu-net.ru. [91.79.175.49]) by smtp.googlemail.com with ESMTPSA id u22sm3008666lfu.78.2019.02.06.08.41.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 08:41:22 -0800 (PST) Subject: Re: [PATCH V13 3/5] i2c: tegra: Add DMA support To: Sowjanya Komatineni , "thierry.reding@gmail.com" , Jonathan Hunter , Mantravadi Karthik , Shardar Mohammed , Timo Alho Cc: "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" References: <1549464441-1836-1-git-send-email-skomatineni@nvidia.com> <1549464441-1836-3-git-send-email-skomatineni@nvidia.com> <4ecd3894-a1cb-20dd-8675-26e6e84254e7@gmail.com> <9c6524ec-b40b-5b0f-eb70-f9ce2c426fd9@gmail.com> <8eccb125-b771-fe10-492f-41dcda00c3b0@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 6 Feb 2019 19:41:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 06.02.2019 19:38, Sowjanya Komatineni пишет: >>>> Looking into timestamps and transactions, DMA timeouts after start of DMA for I2C1 to touch during this transaction. >>>> While it is waiting for I2C1 DMA transfer, lots of DVC transactions >>>> happened thru DMA which are successful >>>> >>>> What is the I2C1 speed? >>> >>> 400KHz >>> >>>> Also incase if device is running slow for some reason, probably timeout was not enough as this patch series changes timeout with base 100mS + msg transfer time based on transfer size. >>>> Can you give quick try with increased timeout incase if device is running slow? >>>> >>> >>> Tried to increase the timeout to 1 second, doesn't help. >>> >>> What helped again is the I2C HW resetting after each transfer. Likely that means that HW isn't programmed correctly, please carefully check every bit. >>> >>> DMA-only + I2C HW reset: http://dpaste.com/26AQXFM.txt >> >> Seems I found what's the problem. Here is the fix, please include it to v14 if it is correct. >> >> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index a9391c3646b6..5ad54da70304 100644 >> --- a/drivers/i2c/busses/i2c-tegra.c >> +++ b/drivers/i2c/busses/i2c-tegra.c >> @@ -912,7 +912,7 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev, >> size_t len) { >> - u32 val, reg; >> + u32 val = 0, reg; >> u8 dma_burst = 0; >> struct dma_slave_config slv_config = {0}; >> struct dma_chan *chan; >> @@ -922,7 +922,6 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev, >> reg = I2C_MST_FIFO_CONTROL; >> else >> reg = I2C_FIFO_CONTROL; >> - val = i2c_readl(i2c_dev, reg); > > > > if (i2c_dev->is_curr_dma_xfer) { > > if (len & 0xF) > > Thanks dmitry. Good catch. Didn't caught to my eyes. Yes FIFO_CONTROL is set based on read value without masking and oring causing back-back DMA transfers resulting in incorrect trig levels > We can directly set trig levels. > Will fix it. > Awesome!