From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782FD1E1A3B for ; Sat, 14 Mar 2026 08:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773476380; cv=none; b=CbeB8NidpiGJGPp2DRs9d/sGdu+ON+KwwAI5AzyMznCCn/vZeUoIYvELIdiTa9+sUJrPTSFMWVfAf36BVvxhoebyXj4E6Eo5tIzWp+N4ExcapHzrzwxohdkIEpEQ7CmcHBY92jw1U1WC5BxhA5eZIJSUewlT8miGom3vnV84+xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773476380; c=relaxed/simple; bh=yL57mEjBppZAhUsI12YY/enfvU2Ir84udGgV3hciYH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ONSf9u8T6pY60vp9Kqg9KXA85D6qCVvEolLSnEX5Sdrib/l1Yi8AgFDAVNgmv306R56p/aNuX2b7pC8VXPK2LQWyVXQZ7M8nmTj2B8v3pwRjInLhFqJn3rb6eg6w074c6k4ZQj2aXrShZxWyS3ouUPzjkgu4nIDA9OaxdoKD5pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pqHs+MKc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kCii8r9I; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pqHs+MKc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kCii8r9I" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62E3mtck2537467 for ; Sat, 14 Mar 2026 08:19:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2GKqjWkJCf/SFXEAPiGWvpOX9aXVYHPgP7iT/euqkP8=; b=pqHs+MKcFLny6c3l ob2sS8LVQfT2dSXIifyHkb4lzBQEV3ndLS+ox/1lLY4qdEaTpfeZOsxMh+ZV2U2L CR5EGrARH4k+YSgYYacwI31tQ7ndNEV9S+vOR0gnzofkiAJRWtf4rp6dumI7UpOS zdWFhaG37b2EneQXNHGnDxGKonTCOmIIXUorXcJj58PMiuAHKKqRydb6f3mQEvoQ mxskyWg/SQ5nFP/KnzMHJ6T+hmv5E7g/Ftt3Cof/7uW3zHepQMBaA4h3ICfBm2BC /UU2NgyLdDBwx8xLqkVq8NAVOpl4vE8o4wzgp0jkHh+nJCfCINX9AaqtQTQMaz+r 7Cy7aw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw03qgdex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Mar 2026 08:19:38 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c737ced4036so1756369a12.1 for ; Sat, 14 Mar 2026 01:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773476377; x=1774081177; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2GKqjWkJCf/SFXEAPiGWvpOX9aXVYHPgP7iT/euqkP8=; b=kCii8r9IT5+y5u6FNmBy7c6+K0uaNSvo3DcYC+TcdPFjtgGnhXCplBrHzCR5beEQdd RG5WdfY9Be6mJWxamMIGJBRNWIZUv85HnmeQO2buFRj43No5M55Var263ZhBTl5kPHCm yR8iyK4UGzZNqCJWsKL84Kl2mtAjSqLnwWBpyaepqO5FhSOmHoLtyIdC0nJEBs18Q9M4 +VcyVa/e0x5scHot3Fo5toLF1cnowAAUypWWdlq8HRhnvgBf3uDVQ8xVQnlYMFrcYBml YCa/fVTrcavlsGgIaAPsiaYp/XBQ9eqR1tKTB6qgJiv32SLHxWOS8ln8Ib4Q5Cc9RmKP kbWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773476377; x=1774081177; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2GKqjWkJCf/SFXEAPiGWvpOX9aXVYHPgP7iT/euqkP8=; b=QGhShAXfl0SSI942GVUSRw6FZSSsBtK8OhDxjy5nwYeWiR+NBAmugLZMX4esao4O4L vExpLyk3n0aNLhaBFQZb9AtUaDpg4W0w0D6BsRZ7281/zgTCAJcV+b54eKWx4PLOZx8V uueQF84aYfgjUTIk0AClduLY3fcKV9Fsh0E69P0adRpE1TrgpcU9KxrFPX8b6o/048kN KGOLlXMbPcA3nbvxgJ/g9X944VF7Umhx4uxbUqblyJ5wh1BFOi1jbdVHscXcuUJV/TMY pLxYcjokTPpYcFF7/s5qdpgGHu84iidjHLT/wgydU7PzhBiGNa0IVxSAxq6Wxr2O21gg eNJA== X-Forwarded-Encrypted: i=1; AJvYcCUIQnQWJphQYrIoKxJem5jYgMWzRsoRzoR61CvQ3ukNdfVuEI/QVl3R2m3XgOrG5+IN8rhf2gf/YuYAHqU=@vger.kernel.org X-Gm-Message-State: AOJu0YzwtubNnKpIu8LoJyP5nPf2jrxSpE6uZ7f3u7juiNwN+c+e+hOi DRWj73ZC/jPhQh/UNKzT0YMGrYMEGnwliM1dC9ggigUZWv/cpworLME6WVPkbNMP24ZttAeuzaY aXHHSui9TMTWhaNUlx9PKqbrtaRV/Dy0kIWeEnUsHpOW5f2jxS+auteRE+WvVs2LdiL0= X-Gm-Gg: ATEYQzx4QIu5LOcWE7ArYu+1OIwu7zYfn+66XDmFGGDNLhrgM1IKfL3GSMl9Tg9g99h aJU/4StEU4M1goaEhjgjolww6XV2o+Ks7bVuwUWiCIx/EJHw8Jnx3k5BPRduPWX/eG2VxJw6tHk PL5wbn4uJseYVPfQGdG+uwEVV3qPt0ngdMKrGtzCK/zVDPnlEO/Nw5OfnSYsfNgGAWrke3VhA1l Cosb5stXtLda1wnNpoH1hXgQNSZ7BwcEFH1Sib/cYrWXmEZ3lBRMpjwzneeFb2mf6MLDhkMJNgy poDtgp1vXGr8uL2egatxyNOfFn5D80dC1gxK3QqRPIM5B5+FVwJptqeEMoj+B3+pvCX6hXPFEiu 21tDaCc4jBThJcNuNrR7w6Z4XdxV6uFdEOp0Hu/QytMwdSJX4B7+G5r/49zechGLiz0n3VJpN67 ww/ywQbEKRHg== X-Received: by 2002:a05:6a00:84c:b0:829:86a5:d30f with SMTP id d2e1a72fcca58-82a19703a46mr5506925b3a.11.1773476377373; Sat, 14 Mar 2026 01:19:37 -0700 (PDT) X-Received: by 2002:a05:6a00:84c:b0:829:86a5:d30f with SMTP id d2e1a72fcca58-82a19703a46mr5506906b3a.11.1773476376928; Sat, 14 Mar 2026 01:19:36 -0700 (PDT) Received: from [10.133.33.24] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07366974sm8005672b3a.48.2026.03.14.01.19.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 01:19:36 -0700 (PDT) Message-ID: Date: Sat, 14 Mar 2026 16:19:30 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Peter Wang , "Bao D. Nguyen" , Adrian Hunter , open list References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-5-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 6mpNv5c5AUTDy_WoHZnFnHcjuTb27pe0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE0MDA2MyBTYWx0ZWRfX6hQ1XYJD1qGd uGzT6frOvDMj4YzsjWLmhA+kvOozB/Qx8eKkPrkJWnOcUEw/y8GiI6vYs2NMKiCC22Nab6VRxjt KIJfdJEJ6RQ2NoGkwECaoYHKXfUWhbrWfKgEgNrohjax/+EpoB9pZ0BdZSDsNvWcPJ8BCKPVisB sv6wGZxW12IRckjhcQEUnsl+cc1kKN4H5u1ZzYMRZlUpgI1gyrhaULfXk6iMGMnVDaecmxHTAk1 0zPDJqzGkH/Fnucr1Fk92fD8xx0VPBf2MNN8lTn9F9C53T22INciTFapdhciwPggIRm+Q+obHSz iJcxdgYExVokYtp/0cbWSSTD3GmaQCVqb7FsbbSaWZYhf8Ub49oO77swOxiB7r7Z/eUOtueDfeg 5bTYMEDsb5EeD8QFSr8yUb+QevYJlDBT0ZC3F9I/aFdraSwLsppgQSumQw1NqGRbxknEMZYY/pS u9uxipPiZ/bXL0JTdUg== X-Proofpoint-ORIG-GUID: 6mpNv5c5AUTDy_WoHZnFnHcjuTb27pe0 X-Authority-Analysis: v=2.4 cv=ZbQQ98VA c=1 sm=1 tr=0 ts=69b51a1a cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=FkDJwfnGEHPz-odBGkUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-14_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603140063 On 3/14/2026 6:19 AM, Bart Van Assche wrote: > On 3/8/26 8:14 AM, Can Guo wrote: >> +static int txeq_gear_set(const char *val, const struct kernel_param >> *kp) >> +{ >> +    return param_set_uint_minmax(val, kp, UFS_HS_G1, UFS_HS_G6); >> +} > > Why UFS_HS_G6 instead of UFS_HS_GEAR_MAX? I will use 'UFS_HS_GEAR_MAX - 1' in next version. > >> @@ -955,6 +1045,11 @@ enum ufshcd_mcq_opr { >> + * @host_preshoot_cap: host TX PreShoot capability >> + * @host_deemphasis_cap: host TX DeEmphasis capability >> + * @device_preshoot_cap: device TX PreShoot capability >> + * @device_deemphasis_cap: device TX DeEmphasis capability > > Please either explain the meaning of the bits in the above four new > member variables or add a reference to the standard that defines the > meaning of the bits in these member variables. OK. > >> +#define UFS_HS_RATE_STRING(rate) \ >> +    ((rate) == PA_HS_MODE_A ? "A" : \ >> +     (rate) == PA_HS_MODE_B ? "B" : \ >> +     "Unknown") > > Why a #define instead of an inline function? Aren't inline functions > preferred over preprocessor macros? Let me change to inline function in next version. Thanks, Can Guo. > > Thanks, > > Bart.