From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Lizhi Hou <lizhi.hou@amd.com>, <ogabbay@kernel.org>,
<dri-devel@lists.freedesktop.org>
Cc: <linux-kernel@vger.kernel.org>, <min.ma@amd.com>,
<max.zhen@amd.com>, <sonal.santan@amd.com>, <king.tam@amd.com>,
<mario.limonciello@amd.com>
Subject: Re: [PATCH] accel/amdxdna: Refactor hardware context destroy routine
Date: Fri, 31 Jan 2025 10:37:02 -0700 [thread overview]
Message-ID: <f89025f7-8db9-19d1-53dc-4eb5899db5ce@quicinc.com> (raw)
In-Reply-To: <20250124173536.148676-1-lizhi.hou@amd.com>
On 1/24/2025 10:35 AM, Lizhi Hou wrote:
> It is required by firmware to wait up to 2 seconds for pending commands
> before sending the destroy hardware context command. After 2 seconds
> wait, if there are still pending commands, driver needs to cancel them.
>
> So the context destroy steps need to be:
> 1. Stop drm scheduler. (drm_sched_entity_destroy)
> 2. Wait up to 2 seconds for pending commands.
> 3. Destroy hardware context and cancel the rest pending requests.
> 4. Wait all jobs associated with the hwctx are freed.
> 5. Free job resources.
>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
next prev parent reply other threads:[~2025-01-31 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 17:35 Lizhi Hou
2025-01-31 17:37 ` Jeffrey Hugo [this message]
2025-02-14 15:45 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89025f7-8db9-19d1-53dc-4eb5899db5ce@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=king.tam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®