From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755055AbcISKoY (ORCPT ); Mon, 19 Sep 2016 06:44:24 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:57182 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754765AbcISKoO (ORCPT ); Mon, 19 Sep 2016 06:44:14 -0400 X-AuditID: cbfec7f1-f79f46d0000008eb-c0-57dfc179f9db Subject: Re: [PATCH] mtd: s3c2410: add device tree support To: Sergio Prado Cc: dwmw2@infradead.org, computersforpeace@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, k.kozlowski@samsung.com, boris.brezillon@free-electrons.com, richard@nod.at, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Sylwester Nawrocki Message-id: Date: Mon, 19 Sep 2016 12:44:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1474125760-28168-1-git-send-email-sergio.prado@e-labworks.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SeUiTcRjH++19373vVtPXafZgFw2klNKMitcK6TB4iSALwg4iV76o5NQ2 ZxpEUZi6nJp2rGmzw1nNeTDN1HllXiV5ZVl4/bFKa4asFRh0OV8F//s8z/N9Th4Kk3YSPlRM XCKnjJPHyoRivLr9V8+GlOdj4RvHtR5M88R9nGntLcWYwtZugrn+JA9j7BNBTLbNjjEW2zuC eVNXIGSsl4tJRtfTKGCMg30CJq92EjGpDa0kUzmcL9zpxpoNZsQ+7BpE7EdLH2Jr9SMkW/nY n7WYMoRsZdFF9oPhLJtVZUKs07IqTHxMvCOSi41J4pSBIRHiaOv4gQQNkTz5/Rm6hPJxDRJR QG+G3ltOAc/e0DtaLtQgMSWljQg0mW9IV0BKOxEUGdTzCRVTRpIXFSNod5Qh3hhHUHttSuhS edLbwJTzdLaFFx0Aju5i3CXC6C8CqDF9mS0rpINA25aFXCyhQ+Bl5r9Zxmlf6E+vm0mgqKX0 EbCOcLzEA6bzRmdriuj9MPxnEHMxRm8E3Y0XAp5XQ6X5G8ZP+ouEOzlyVxmgV4Klec4dCg7N TYJnT/jaUUXyvAIy0p8LXGMCnY2g03wF8YYOwXBaztyNtsOLjj6Cb+YGudW3Mb6BBNKvSnkJ C6XWXMTzLsiuncD5AxUiGNJ9xnLQav2CffQLdtAv2OEewkzIi1OrFFGcalOASq5QqeOiAk7H Kyxo5r+6/nY4atBU57YWRFNItkSyKGwsXErIk1QpihYEFCbzknyqn3FJIuUp5zll/EmlOpZT taDlFC5bJqm/NxAupaPkidwZjkvglPNRASXyuYT0W99q85ads0aspdY07DvlPh2StE5r9yvZ fdgY8C2l/PhPm2/Z/ciXjuT+qr1Cp/mB7UNjwdj7G7/xWD9RX7gzjTg4bnjUH1qhtd/NLIoj N3cFL7atdx+oaCoxebcF2pOa3L1fBZcNvd6iDhr4oedijrp5KiNTHcaloyfC9Icu7JHhqmh5 kD+mVMn/A1xIyQNbAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t/xy7r+B++HG9zdpmJx4MVCFosjF9Yy W8w/co7VYuLKycwWr18YWvQ/fs1ssenxNVaLy7vmsFnsblrGbjHj/D4mi6XXLzJZTN75htGi de8RdovNd2azOfB5rJm3htFj8enrjB5PNl1k9Ng56y67x+YVWh6bVnWyeWxeUu9xc16hR9+W VYwenzfJBXBFudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5 RgZowME5wD1YSd8uwS1j93P/gi7WijeftjM2MM5m6WLk5JAQMJHY8H4pO4QtJnHh3nq2LkYu DiGBJYwS1xsnsEM4zxklrjz9xQRSJSxgJbFqwlawbhEBPYmP55axQBQtZJR4tugMWDuzwEsm iQVtq8Gq2AQMJXqP9jGC2LwCdhIne/6D2SwCqhKXOnaB1YgKREjcWvURqkZQ4sfke2BxTgEf iTt/rzN3MXIADdWTuH9RCyTMLCAvsXnNW+YJjAKzkHTMQqiahaRqASPzKkaR1NLi3PTcYkO9 4sTc4tK8dL3k/NxNjMBY3nbs5+YdjJc2Bh9iFOBgVOLhZQi4Hy7EmlhWXJl7iFGCg1lJhPfp HqAQb0piZVVqUX58UWlOavEhRlOgFyYyS4km5wPTTF5JvKGJobmloZGxhYW5kZGSOG/Jhyvh QgLpiSWp2ampBalFMH1MHJxSDYwqB3oWNbLV3Jw188ejgKCa+1lvp5r2/H/t6rRA54tfudCd afsSZvTOEtUR9Vr8U2Hfr13rXhZaHe5Y08rKz59WltzsOGmDle6yP6c4xU8FFjufesvJnef4 S63+zoETVkebJ23oUk370lGctNVr0lrJCz/WzzvLIpIccshEwYqNu1bu99TmtBlKLMUZiYZa zEXFiQAL8kFi+wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160919104408eucas1p26e2453dfc86ab77da9836a6973438bb1 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160917152404eucas1p2ca0ebfe59dd762f5cdd611a9dd3cd1a5 X-RootMTR: 20160917152404eucas1p2ca0ebfe59dd762f5cdd611a9dd3cd1a5 References: <1474125760-28168-1-git-send-email-sergio.prado@e-labworks.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2016 05:22 PM, Sergio Prado wrote: > +static int s3c24xx_nand_probe_dt(struct platform_device *pdev) > +{ > + const struct s3c24XX_nand_devtype_data *devtype_data; > + struct s3c2410_platform_nand *pdata; > + struct s3c2410_nand_info *info = platform_get_drvdata(pdev); > + struct device_node *np = pdev->dev.of_node, *child; > + const struct of_device_id *of_id; > + struct s3c2410_nand_set *sets; > + > + of_id = of_match_device(s3c24xx_nand_dt_ids, &pdev->dev); > + if (!of_id) > + return 1; > + > + devtype_data = of_id->data; You could make it a bit simpler with of_device_get_match_data(). -- Thanks, Sylwester