From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C21DC83F19 for ; Mon, 28 Aug 2023 13:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbjH1N5S (ORCPT ); Mon, 28 Aug 2023 09:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjH1N4n (ORCPT ); Mon, 28 Aug 2023 09:56:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0BC9C0 for ; Mon, 28 Aug 2023 06:56:40 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qacjM-0007Hz-Rt; Mon, 28 Aug 2023 15:56:36 +0200 Message-ID: Date: Mon, 28 Aug 2023 15:56:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Ahmad Fatoum Subject: Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base To: Bartosz Golaszewski , Linus Walleij Cc: Alexander Stein , Bough Chen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "christophe.leroy@csgroup.eu" , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team References: <20230506085928.933737-1-haibo.chen@nxp.com> <12270129.O9o76ZdvQC@steina-w> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Cc += i.MX maintainers as this file isn't matched by the MAINTAINERS entry. On 21.08.23 14:17, Bartosz Golaszewski wrote: > On Mon, Aug 21, 2023 at 12:21 PM Linus Walleij wrote: >> >> On Mon, Aug 21, 2023 at 9:44 AM Alexander Stein >> wrote: >>> Am Montag, 21. August 2023, 09:25:54 CEST schrieb Linus Walleij: >>>> On Mon, Aug 21, 2023 at 4:47 AM Bough Chen wrote:> > Hi >>> Linus and Bartosz, >>>>> >>>>> For this patch, still not in the main trunk (Linux 6.5-rc7) and >>>>> linux-next(next-20230818). Can you help apply or any comment? >>>> >>>> As pointed out by Bartosz you cannot just mechanically switch the base >>>> to -1. >>>> >>>> You also need to convince us that this doesn't break any systems, and if >>>> it does, fix them so they don't break before submitting this patch. >>> >>> I think it's hard to tell if something breaks, this driver is used in a lot of >>> boards. AFAIR some people are relying on the assumption of fixed order. Using >>> dynamic allocation this not ensured. A possible fix is to use aliases [1]. >> >> Hm I might have been to grumpy! >> >> It looks like any boardfiles using gpio-mxc have been eliminated >> so this driver is now only used in device tree-boots? Right? >> >> Then I feel a lot better about it. >> >> Acked-by: Linus Walleij >> >> Yours, >> Linus Walleij > > I will not be queueing it for v6.6 as merge window opens in a week, I > want to give it more time in next and see if anyone complains so it'll > make it for v6.7. IMO, this should not be merged. I would hate to do a kernel update and see the kernel toggle some unrelated GPIO, because probe order changes. This will eventually happen to somebody and if they're unlucky, it will break something. For systems, where the order was never fixed, I agree it's on them, but for i.MX, it has been fixed since inception AFAIK and I fail to see what strong reason there is to justify breaking their setups in such a manner. Yes, the sysfs interface will eventually go away and fixed numbering with it but that has been announced long in advance and when that happens, updated systems with legacy scripts will cease to do GPIO until fixed and not essentially toggling GPIOs at random. Thanks, Ahmad > > Bart -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |