From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F72CA9EB5 for ; Mon, 21 Oct 2019 08:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72D17214AE for ; Mon, 21 Oct 2019 08:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727617AbfJUIjQ convert rfc822-to-8bit (ORCPT ); Mon, 21 Oct 2019 04:39:16 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:36642 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726227AbfJUIjP (ORCPT ); Mon, 21 Oct 2019 04:39:15 -0400 Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id 0477F4D2FF7C58E08319; Mon, 21 Oct 2019 16:39:13 +0800 (CST) Received: from dggeme765-chm.china.huawei.com (10.3.19.111) by DGGEMM405-HUB.china.huawei.com (10.3.20.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 21 Oct 2019 16:39:12 +0800 Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by dggeme765-chm.china.huawei.com (10.3.19.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 21 Oct 2019 16:39:12 +0800 Received: from dggeme763-chm.china.huawei.com ([10.6.66.36]) by dggeme763-chm.china.huawei.com ([10.6.66.36]) with mapi id 15.01.1713.004; Mon, 21 Oct 2019 16:39:12 +0800 From: linmiaohe To: Thomas Gleixner CC: "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "sean.j.christopherson@intel.com" , "vkuznets@redhat.com" , "wanpengli@tencent.com" , "jmattson@google.com" , "joro@8bytes.org" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] KVM: remove redundant code in kvm_arch_vm_ioctl Thread-Topic: [PATCH] KVM: remove redundant code in kvm_arch_vm_ioctl Thread-Index: AdWH6kPXLNyqJ2lVU0Oc7cFVv0sKlA== Date: Mon, 21 Oct 2019 08:39:12 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.189.20] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, tglx wrote: >On Mon, 21 Oct 2019, Miaohe Lin wrote: >> If we reach here with r = 0, we will reassign r = 0 unnecesarry, then >> do the label set_irqchip_out work. >> If we reach here with r != 0, then we will do the label work directly. >> So this if statement and r = 0 assignment is redundant. > >Can you please get rid of that odd jump label completely? > > if (irqchip_kernel(kvm)) > r = kvm_vm_ioctl_set_irqchip(kvm, chip); > >Hmm? Sure, thanks for your reply. I will send patch v2 to complete it. Thanks again.