mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Nava kishore Manne <nava.manne@xilinx.com>,
	mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com,
	michal.simek@xilinx.com, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, git@xilinx.com
Subject: Re: [PATCH v2 4/5] fpga: Use tab instead of spaces for indentation
Date: Sat, 26 Mar 2022 10:08:44 -0700	[thread overview]
Message-ID: <f8929af9-daa4-2111-1dff-edbf1f2041e7@redhat.com> (raw)
In-Reply-To: <20220322082202.2007321-5-nava.manne@xilinx.com>


On 3/22/22 1:22 AM, Nava kishore Manne wrote:
> Trivial fix.

This is not descriptive.

Improve the commit log to explain the issue and solution.

Tom

>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> ---
> Changes for v2:
> 		-None.
>
>   drivers/fpga/Makefile | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile
> index 0bff783d1b61..5935b3d0abd5 100644
> --- a/drivers/fpga/Makefile
> +++ b/drivers/fpga/Makefile
> @@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX)		+= ts73xx-fpga.o
>   obj-$(CONFIG_FPGA_MGR_XILINX_SPI)	+= xilinx-spi.o
>   obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA)	+= zynq-fpga.o
>   obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA)	+= zynqmp-fpga.o
> -obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA)      += versal-fpga.o
> -obj-$(CONFIG_ALTERA_PR_IP_CORE)         += altera-pr-ip-core.o
> -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT)    += altera-pr-ip-core-plat.o
> +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA)	+= versal-fpga.o
> +obj-$(CONFIG_ALTERA_PR_IP_CORE)		+= altera-pr-ip-core.o
> +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT)	+= altera-pr-ip-core-plat.o
>   
>   # FPGA Bridge Drivers
>   obj-$(CONFIG_FPGA_BRIDGE)		+= fpga-bridge.o


  reply	other threads:[~2022-03-26 17:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  8:21 [PATCH v2 0/5] fpga: fix for coding style and kernel-doc issues Nava kishore Manne
2022-03-22  8:21 ` [PATCH v2 1/5] fpga: zynq: Fix incorrect variable type Nava kishore Manne
2022-03-26 16:54   ` Tom Rix
2022-04-01 15:45     ` Nava kishore Manne
2022-03-22  8:21 ` [PATCH v2 2/5] fpga: fpga-mgr: fix for coding style issues Nava kishore Manne
2022-03-26 17:03   ` Tom Rix
2022-04-01 15:47     ` Nava kishore Manne
2022-03-22  8:22 ` [PATCH v2 3/5] fpga: fpga-mgr: Add missing kernel-doc description Nava kishore Manne
2022-03-26 17:06   ` Tom Rix
2022-04-01 15:50     ` Nava kishore Manne
2022-03-22  8:22 ` [PATCH v2 4/5] fpga: Use tab instead of spaces for indentation Nava kishore Manne
2022-03-26 17:08   ` Tom Rix [this message]
2022-04-01 15:51     ` Nava kishore Manne
2022-03-22  8:22 ` [PATCH v2 5/5] fpga: fpga-region: Add missing kernel-doc description Nava kishore Manne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8929af9-daa4-2111-1dff-edbf1f2041e7@redhat.com \
    --to=trix@redhat.com \
    --cc=git@xilinx.com \
    --cc=hao.wu@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=nava.manne@xilinx.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®