From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbdJLIGl (ORCPT ); Thu, 12 Oct 2017 04:06:41 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:9851 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753699AbdJLIGj (ORCPT ); Thu, 12 Oct 2017 04:06:39 -0400 Subject: Re: [PATCH] drm/omap: displays: panel-dpi: add backlight dependency To: Arnd Bergmann , David Airlie CC: , References: <20171005120651.376485-1-arnd@arndb.de> From: Tomi Valkeinen Message-ID: Date: Thu, 12 Oct 2017 11:05:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171005120651.376485-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9C86i1h020554  Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 05/10/17 15:06, Arnd Bergmann wrote: > The new backlight code causes a link failure when backlight > support itself is disabled: > > drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of': > panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node' > > This adds a Kconfig dependency like we have for the other OMAP > display targets. > > Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/omapdrm/displays/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig > index c226da145fb3..a349cb61961e 100644 > --- a/drivers/gpu/drm/omapdrm/displays/Kconfig > +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig > @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV > > config DRM_OMAP_PANEL_DPI > tristate "Generic DPI panel" > + depends on BACKLIGHT_CLASS_DEVICE > help > Driver for generic DPI panels. Thanks, I've queued this for 4.14 fixes. Tomi