From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E472726E161 for ; Thu, 20 Nov 2025 08:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763625934; cv=none; b=pheK4ZOUGVOtqNoAgot/EEevs7g+SFEyn/DMeJjHYVTvJF9/bNKJChnE7kxB6ZuUHuZx0oIvEru+vPyISLAKsUSQwlIwNIHcm2JcSLGTjoQlycT4MsSiknbn0BZjt1qf/PzbKbIrwfnFG6wyGRSbPWjF38e1kt6s9/RNjKDfcYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763625934; c=relaxed/simple; bh=4odYw6lphQIVkI4BWQ65rxrqQM+lFn8fevTKJ7zCzLU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hx7CaqU3FSZvXyS1FnOH8hntPJX+3LB49hKMDUeH1dT3v2lrv/ALLdZcQtV5279gP7KKSLAJo41ciuKQZyZvGWwOfjndI32mjC+Wj1SLdSgXN6K05c++NJV+0pHNQa6aWLgWvI70+2VxuJ6dJJU7+TogB71Vr7yuavSD9eagWVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ErQuyRNN; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ErQuyRNN" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42b3c965ca9so304963f8f.1 for ; Thu, 20 Nov 2025 00:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763625931; x=1764230731; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8PztCW99nsI9W45kahbPszZ32SfHFrWK98zZmX/7wnE=; b=ErQuyRNNcb6IDLy16q4sUp5N+Yt3iNGVi7dYIzl0Fls2aB1hfQY8Om7QElBASP4AOZ aDEnDetBWsenMiKepIqOxXYDrsQsqhaYNYuZUcRPIFADFmLitj1rtOPnsleVrW9n7jeb Tnmk8AsI9BAZGABA568fcCCRPYTV5c/GeuVzZDbjD7tZlIohqNYNspvFYSQz/rXsuxad OjSL20YtAkZ9sEKelcrrDQN0pzVb2OF8nkhTP95uXghKHvQ9tNEJ/ij2vS8XLFvXD6ZH TGKOP32AunkMiJx0Ji/sRMXvaKpAoy43nUzTBjsIF+DbxWQpO98De8/oVY1p/VXWaYE9 qd1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763625931; x=1764230731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8PztCW99nsI9W45kahbPszZ32SfHFrWK98zZmX/7wnE=; b=RXLED+CyTdV8zXwybnQa6R35BEPOSI2kXvATrC8gLHysvGdXZsfsVfEU6Fo7v1G6TA ORw6L++LtLEQBdJfOj9gpFY+j01Ctno2DJ7YvpyUSUu98EznUwRVscjmP40v0gXJV2/z gHac1cQyx1RLtsrhKRJAf5jTk7HXU2mv1saDWG6RqhtjQLZJ0z3wxifQMjh+9izpsnNO El6zPQWFjyZ5fXjm0HH226HY65NCqP9cRNt7W+qxOgqux6Bx/z3+8TqDFxin+OqHBWYU PQ/GsNJ/H+iU6R7Gx/mOrA3O/ceG4HGZnTlG7ieDmGMmNZHzCviMnS6sHOVTOG7fLKem xYkw== X-Forwarded-Encrypted: i=1; AJvYcCWhaQ1mtEudaRmc3QBvSeV/oSg2tq76j/OOcMmyBQCMmdwosZZ4inmGNFJg9nUmxkZcgczTzP2NnBiL5ys=@vger.kernel.org X-Gm-Message-State: AOJu0YyXJIYdaAM20MrMeMQWdkoP6S9TsWoj0n0F6B/2mY1QwMPgV/wx 8FpdHL1EpEj5G/4Y2QFpVJTJMab8MTxqqUzIkwszp7JSBRHLmMGDAfa89+nYiTUl7bo= X-Gm-Gg: ASbGncvHIjrimnJFe2J51qKEvvE8cOoK8Z3fiynIDzrZHPa/+pqfMIEZGcVGyKq1Uj/ i8wn2X/NOaBzXATJZ8ZHjG6AoJuRUjw7Nd9AwSPGWzgQIArpaSGzrpR2Qsgym56odmWKqV5guLc e9u8tij4SlEon2q7w5+o6X5+7EOX8Jes1DBvIp71nxiaaBuqQMEXybd3Ru8KG/Q/178l1Y4aydC ScurtyKwm/Ffpg06syHIpsdwABjXS9FSq0BszJ/074jSPQVL1/wt/nzvMlt87le06Zp61uOSsgo cuS/60Sxp9nUg/vswL078M9614kJJcIVkbZGzYMjeX/rGBV3g8n29uQ+fB0gu6iNPyaIszJm0nS PSQ0q8a925dRXUIpaUcwYcjOgq/eQbMyA/Ba0VNmIvhvaohCYFMjooJkP9cIrhkcoKwhFcU0pu7 FdK0SAzeRipuI4l+Iw X-Google-Smtp-Source: AGHT+IE5v+9a80Zn9J2fmQEfUzMbSA47PM8PvbAZc/vWxwU72hK4Du32I64ZpwzSWFiC0CaXw3Jplw== X-Received: by 2002:a05:6000:26d0:b0:42b:3023:66a6 with SMTP id ffacd0b85a97d-42cbb2aa131mr1087403f8f.40.1763625931093; Thu, 20 Nov 2025 00:05:31 -0800 (PST) Received: from [10.11.12.107] ([5.12.85.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34ffesm4477241f8f.10.2025.11.20.00.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 00:05:30 -0800 (PST) Message-ID: Date: Thu, 20 Nov 2025 10:05:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/28] mtd: spinand: Fix kernel doc To: Miquel Raynal Cc: Mark Brown , Richard Weinberger , Vignesh Raghavendra , Pratyush Yadav , Thomas Petazzoni , Steam Lin , Santhosh Kumar K , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org References: <20251031-winbond-v6-17-rc1-oddr-v1-0-be42de23ebf1@bootlin.com> <20251031-winbond-v6-17-rc1-oddr-v1-4-be42de23ebf1@bootlin.com> <87v7j6aqlr.fsf@bootlin.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <87v7j6aqlr.fsf@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/25 7:18 PM, Miquel Raynal wrote: > On 05/11/2025 at 16:57:39 +01, Tudor Ambarus wrote: > >> On 10/31/25 6:26 PM, Miquel Raynal wrote: >>> The @data buffer is 5 bytes, not 4, it has been extended for the need of >>> devices with an extra ID bytes. >>> >>> Fixes: 34a956739d29 ("mtd: spinand: Add support for 5-byte IDs") >> >> no fixes tag for documentation. >> >> with that: >> Reviewed-by: Tudor Ambarus >> >> (commit msg can be updated to smth like "update kernel doc comment" >> too) > > I partially disagree. Tell me if I'm wrong, but may I guess that you > have backports in mind? As opposed to backporting comment fixes which yes, I was thinking on stable rules, where trivial fixes like this, are not accepted. But you didn't cc stable, so I think that's fine. > might not make much sense indeed, _fixing_ a comment makes sense. We > know that stable maintainers, even though they ask people to Cc stable > for backports, they automatically pick with the help of AI almost any > commit with a Fixes tag. I believe it is wrong to not mark such commit > and even change the title (because "fix" in the title may also lead to > an automatic backport) to circumvent their tooling. The tooling must > adapt, not the accuracy of the commits. Plus, backporting this kind of > commit is harmless, so I wouldn't care too much? okay