From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, pmladek@suse.com
Cc: rostedt@goodmis.org, andriy.shevchenko@linux.intel.com,
senozhatsky@chromium.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] lib/vsprintf: Remove redundant code
Date: Thu, 19 Oct 2023 13:51:45 +0200 [thread overview]
Message-ID: <f89a00c8-2ea2-4ef1-909e-2eaf7bc17cf9@rasmusvillemoes.dk> (raw)
In-Reply-To: <20231018064817.86721-1-jiapeng.chong@linux.alibaba.com>
On 18/10/2023 08.48, Jiapeng Chong wrote:
> When variable needcolon is assigned a value of false, it must be
> assigned a value of true later on, which is redundant code.
NAK on any patch modifying these things without first filling the blank
space in ip6() in lib/test_printf.c with tests for all the various ip6
printing modes.
Adding test cases there is much more useful than code-golfing, and would
help verify that these changes are actually ok. Or may reveal that the
current code is buggy.
Rasmus
next prev parent reply other threads:[~2023-10-19 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 6:48 Jiapeng Chong
2023-10-18 12:56 ` Andy Shevchenko
2023-10-19 11:51 ` Rasmus Villemoes [this message]
2023-10-19 12:21 ` Andy Shevchenko
2023-10-19 13:21 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89a00c8-2ea2-4ef1-909e-2eaf7bc17cf9@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=abaci@linux.alibaba.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®