From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941447AbcJXWYp (ORCPT ); Mon, 24 Oct 2016 18:24:45 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59395 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941393AbcJXWYo (ORCPT ); Mon, 24 Oct 2016 18:24:44 -0400 Subject: Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting" To: Joe Perches , Kees Cook References: <20161024220212.8464-1-colin.king@canonical.com> <1477347610.2111.6.camel@perches.com> Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Nathan Fontenot , Heiko Carstens , Rashmica Gupta , "linuxppc-dev@lists.ozlabs.org" , LKML From: Colin Ian King Message-ID: Date: Mon, 24 Oct 2016 23:24:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477347610.2111.6.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/10/16 23:20, Joe Perches wrote: > On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote: >> On Mon, Oct 24, 2016 at 3:02 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> trivial fix to spelling mistake in pr_debug message >>> >>> Signed-off-by: Colin Ian King >>> --- >>> arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c >>> index a1b63e0..c8929cb 100644 >>> --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c >>> +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c >>> @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index) >>> { >>> int rc; >>> >>> - pr_debug("Attemping to remove CPU %s, drc index: %x\n", >>> + pr_debug("Attempting to remove CPU %s, drc index: %x\n", >>> dn->name, drc_index); >>> >>> rc = dlpar_offline_cpu(dn); >>> -- >>> 2.9.3 >> >> Reviewed-by: Kees Cook >> >> scripts/spelling.txt should likely get an addition for "attemping". It >> already has "attemps"... > > There may not be enough of these to be useful and to my > knowledge Colin isn't fixing comments Indeed, I'm just using my kernelscan tool to scrape for errors in kernel messages as these are seen by users as opposed to comments. Plus the occurrences of the mistakes I'm finding are generally very small. > > $ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting > arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */ > arch/powerpc/platforms/pseries/hotplug-cpu.c: pr_debug("Attemping to remove CPU %s, drc index: %x\n", >