From: jerome Neanne <jneanne@baylibre.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFT] [PATCH] regulator: tps65219: Fix .bypass_val_on setting
Date: Mon, 12 Sep 2022 11:49:09 +0200 [thread overview]
Message-ID: <f8a92b6d-ad23-24e7-2a01-73839e57cb85@baylibre.com> (raw)
In-Reply-To: <20220828120153.1512508-1-axel.lin@ingics.com>
Hi Axel,
On 28/08/2022 14:01, Axel Lin wrote:
> The .bypass_val_on setting does not match the .bypass_mask setting, so the
> .bypass_mask bit will never get set. Fix it by removing .bypass_val_on
> setting, the regulator_set_bypass_regmap and regulator_get_bypass_regmap
> helpers will use rdev->desc->bypass_mask as val_on if the val_on is 0.
I think this will result in exact same behavior. val would be assigned
to 1 when enable is set and 0 otherwise. Anyway you are right this line
is useless.
> I don't have this h/w to test, please help to review and test the patch.
I'll double check on the board.
next prev parent reply other threads:[~2022-09-12 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 12:01 Axel Lin
2022-09-09 22:56 ` Mark Brown
2022-09-12 9:49 ` jerome Neanne [this message]
2022-09-12 23:48 ` Axel Lin
2022-09-13 10:00 ` jerome Neanne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a92b6d-ad23-24e7-2a01-73839e57cb85@baylibre.com \
--to=jneanne@baylibre.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®