From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601Ab3GMWdi (ORCPT ); Sat, 13 Jul 2013 18:33:38 -0400 Received: from terminus.zytor.com ([198.137.202.10]:53646 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341Ab3GMWdh (ORCPT ); Sat, 13 Jul 2013 18:33:37 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: <1373659660-31123-1-git-send-email-keescook@chromium.org> <20130712203802.GA14702@www.outflux.net> <51E169F1.5010301@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 1/3] x86, boot: add mmio serial during compressed boot From: "H. Peter Anvin" Date: Sat, 13 Jul 2013 15:33:09 -0700 To: Yinghai Lu CC: Kees Cook , "Eric W. Biederman" , Linux Kernel Mailing List , Rob Landley , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Greg Kroah-Hartman , linux-doc@vger.kernel.org, linux-serial@vger.kernel.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think we will need to map the uart explicitly, which is complex as that in turn implies seeing up something like the fixmap for the decompressor... not impossible but additional complexity to be sure. At least on 64 bits the high half should not conflict with any physical addresses. Either that or be able to add pagetables to map the mmio directly or via a #PF handler like we already have in the early kernel. Yinghai Lu wrote: >On Sat, Jul 13, 2013 at 7:53 AM, H. Peter Anvin wrote: >> On 07/12/2013 11:47 PM, Yinghai Lu wrote: >>> >>> for 32 bit, that is ok. >>> for 64 bit via 32bit bootloader, arch/x86/boot/compressed/head_64.S >>> will set page table for first 4G still ok. >>> for 64 bit via 64bit loader, like kexec via bzImage64, First >Kernel/Kexec only >>> set ident mapping for usable range, so mmio just under 64 is not >mapped. >>> >>> Looks like we need to update boot.txt to add requirement for 64bit >bootloader >>> that 0-4G need to be all ident mapping? >>> >> >> I think that is an unrealistic requirement, especially if this is the >> sole user. > >That will cause regression for: >64bit system with kexec/kdump bzImage64. >if second kernel carry "console=uart,mmio,0xABCD0000" > >or we can extend kexec-tools to make it scan second kernel command line >string >and one entry into image->segment[] > >Yinghai -- Sent from my mobile phone. Please excuse brevity and lack of formatting.