From: Hector Martin <marcan@marcan.st>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
sven@svenpeter.dev, hdegoede@redhat.com
Cc: kernel@puri.sm, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tipd: keep default interrupts enabled during probe()
Date: Tue, 11 Jan 2022 20:10:14 +0900 [thread overview]
Message-ID: <f8b4606a-e3ec-e452-f291-7ac36c69f8cd@marcan.st> (raw)
In-Reply-To: <20220110163559.711404-1-martin.kepplinger@puri.sm>
On 2022/01/11 1:35, Martin Kepplinger wrote:
> Commit 9990f2f6264c ("usb: typec: tipd: Enable event interrupts by default")
> writes a fixed set of interrupts to TPS_REG_INT_MASK1. In case interrupts
> had been enabled by the firmware by default, these get disabled now
> which can break use cases. Only append to what is already enabled instead.
>
I'm confused. The kernel drives the hardware, it needs to enable only
the interrupts it can handle. Do you have some kind of firmware trying
to share access to the same I2C port that needs other interrupts? That
sounds like a recipe for trouble... or am I misunderstanding things?
If the *kernel* needs other interrupts enabled to make something work,
then they should also be enabled unconditionally, and you'd have to
check the IRQ handler to make sure it actually handles it.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
next prev parent reply other threads:[~2022-01-11 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 16:35 Martin Kepplinger
2022-01-11 9:11 ` Heikki Krogerus
2022-01-11 11:10 ` Hector Martin [this message]
2022-01-13 9:15 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8b4606a-e3ec-e452-f291-7ac36c69f8cd@marcan.st \
--to=marcan@marcan.st \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®