From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94BEC4332F for ; Wed, 27 Apr 2022 12:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234375AbiD0MiS (ORCPT ); Wed, 27 Apr 2022 08:38:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234177AbiD0MiP (ORCPT ); Wed, 27 Apr 2022 08:38:15 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E77CF50E3A; Wed, 27 Apr 2022 05:35:03 -0700 (PDT) Received: from sslproxy04.your-server.de ([78.46.152.42]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1njgse-000Bll-3T; Wed, 27 Apr 2022 14:34:52 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy04.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njgsd-000Gt8-Hj; Wed, 27 Apr 2022 14:34:51 +0200 Subject: Re: [PATCH v5 1/3] selftests: bpf: add test for bpf_skb_change_proto To: Lina.Wang@mediatek.com, "David S . Miller" , Jakub Kicinski , Paolo Abeni , Shuah Khan , Matthias Brugger Cc: Alexei Starovoitov , Andrii Nakryiko , Jesper Dangaard Brouer , Eric Dumazet , linux-kernel@vger.kernel.org, Maciej enczykowski , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org References: <9dc51533-92d2-1c82-2a6e-96e1ac747bb7@iogearbox.net> <20220418015230.4481-1-Lina.Wang@mediatek.com> From: Daniel Borkmann Message-ID: Date: Wed, 27 Apr 2022 14:34:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20220418015230.4481-1-Lina.Wang@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.5/26525/Wed Apr 27 10:19:41 2022) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/18/22 3:52 AM, Lina.Wang@mediatek.com wrote: [...] >> OT: In Cilium we run similar NAT46/64 translation for XDP and tc/BPF >> for our LB services [4] (that is, >> v4 VIP with v6 backends, and v6 VIP with v4 backends). >> >> [4] >> https://github.com/cilium/cilium/blob/master/bpf/lib/nat_46x64.h >> >> https://github.com/cilium/cilium/blob/master/test/nat46x64/test.sh > > It is complicated for me, my case doesnot use XDP driver.I use xdp_dummy > just to enable veth NAPI GRO, not real XDP driver code. My test case is > simple and enough for my patch, I think. I have covered tcp and udp, > normal and SO_SEGMENT. Ok, fair enough, then lets resend with the minor fixups as discussed earlier and worst case we can do the test_progs integration at a later point to avoid blocking the fix. At least there is something runnable under net/bpf selftests.. even if not yet in BPF CI but we can follow-up on it later. Thanks Lina!