From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756263AbdKGIbG (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Nov 2017 03:31:06 -0500
Received: from mail-wr0-f182.google.com ([209.85.128.182]:43395 "EHLO
        mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755652AbdKGIbE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Nov 2017 03:31:04 -0500
X-Google-Smtp-Source: ABhQp+ROq603eyXwtGRnWvgTADJh3OckxHa540XsRfCHmJtbLtsaLawV3Sy+Kv2a1KWMa8lUnXYMlQ==
Subject: Re: [PATCH] dm-crypt, dm-integrity: allow unaligned bv_offset
To: =?UTF-8?Q?Bruno_Pr=c3=a9mont?= <bonbons@sysophe.eu>,
        Mikulas Patocka <mpatocka@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,
        linux-kernel@vger.kernel.org
References: <20171102213903.1baa4a10@uranus>
 <20171106161808.GC25073@redhat.com> <20171106232918.25c0ae1a@uranus>
 <alpine.LRH.2.02.1711061852380.23082@file01.intranet.prod.int.rdu2.redhat.com>
 <20171107091323.20664e3f@pluto.restena.lu>
From: Milan Broz <gmazyland@gmail.com>
Message-ID: <f8bb8497-7b6d-3ce1-8a59-0eb90975c4c0@gmail.com>
Date: Tue, 7 Nov 2017 09:31:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.3.0
MIME-Version: 1.0
In-Reply-To: <20171107091323.20664e3f@pluto.restena.lu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/07/2017 09:13 AM, Bruno Prémont wrote:
>> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>> Cc: stable@vger.kernel.org	# v4.12+
>> Fixes: 8f0009a22517 ("dm crypt: optionally support larger encryption sector size")
>> Fixes: 7eada909bfd7 ("dm: add integrity target")
> 
> Reported-by: Bruno Prémont <bonbons@sysophe.eu>
> Tested-by: Bruno Prémont <bonbons@sysophe.eu>
> 
> Successfully tested on 4.12.14, 4.13.11 and 4.14-rc8+ (e4880bc5dfb1).

Thanks!

(That alignment check was added after our discussion - we wanted
to have dm-crypt and dm-integrity to check the same thing, just to trigger
possible data corruption, but obviously it was incorrect check.)

It must go to stable well, I think there are possibly more situations
we broke for dm-crypt by this.

Reviewed-by: Milan Broz <gmazyland@gmail.com>

m.