From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: Drop redundant port
Date: Tue, 19 May 2026 11:14:19 +0100 [thread overview]
Message-ID: <f8bda354-ca64-433e-9e9a-4eabeb9a7169@linaro.org> (raw)
In-Reply-To: <20260519100014.282058-3-krzysztof.kozlowski@oss.qualcomm.com>
On 19/05/2026 11:00, Krzysztof Kozlowski wrote:
> The binding defines both "port" and "connector" properties, where the
> "port" is claimed to be for "data-role switching messages". There is no
> such dedicated data port for this device and role switching is part of
> connector ports - the port going to the USB controller.
>
> The driver does not use the "port" property and there is no upstream DTS
> which would have it. It looks like it's left-over of early versions of
> this patchset and is completely redundant now, so let's drop it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> index 6d3fa2bc9cee..975032ba6004 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -84,11 +84,6 @@ properties:
> vdd-pdphy-supply:
> description: VDD regulator supply to the PDPHY.
>
> - port:
> - $ref: /schemas/graph.yaml#/properties/port
> - description:
> - Contains a port which produces data-role switching messages.
> -
> required:
> - compatible
> - reg
True, the ports are in the connector now.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod
next prev parent reply other threads:[~2026-05-19 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 10:00 Krzysztof Kozlowski
2026-05-19 10:00 ` [PATCH 2/2] USB: typec: qcom-pmic-typec: Drop redundant header includes Krzysztof Kozlowski
2026-05-19 10:15 ` Bryan O'Donoghue
2026-05-19 10:35 ` Konrad Dybcio
2026-05-19 13:58 ` Heikki Krogerus
2026-05-19 10:14 ` Bryan O'Donoghue [this message]
2026-05-19 10:30 ` [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: Drop redundant port Konrad Dybcio
2026-05-19 10:34 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8bda354-ca64-433e-9e9a-4eabeb9a7169@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®