From: Oliver Neukum <oneukum@suse.com>
To: Gui-Dong Han <hanguidong02@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
oneukum@suse.com
Cc: robert.hodaszi@digi.com, kees@kernel.org,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: Re: [BUG] usb: cdc-wdm: Missing barriers in ad-hoc lockless buffer
Date: Thu, 5 Mar 2026 12:35:53 +0100 [thread overview]
Message-ID: <f8c304be-c061-4656-b7ba-83150c2b8746@suse.com> (raw)
In-Reply-To: <CALbr=LbrUZn_cfp7CfR-7Z5wDTHF96qeuM=3fO2m-q4cDrnC4A@mail.gmail.com>
On 04.03.26 09:41, Gui-Dong Han wrote:
> Additionally, the driver relies heavily on set_bit() and test_bit() on
> desc->flags for synchronization. These bit operations do not provide
> implicit barriers, which might lead to similar ordering issues.
Hi,
going through the driver it seems to me like all relevant cases
are covered by the iuspin spinlock. Do you have any concrete suspicions
or do you generally distrust this style?
Regards
Oliver
next prev parent reply other threads:[~2026-03-05 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 8:41 Gui-Dong Han
2026-03-04 9:15 ` Greg KH
2026-03-05 11:35 ` Oliver Neukum [this message]
2026-03-05 12:28 ` Gui-Dong Han
2026-03-05 12:44 ` Oliver Neukum
2026-03-05 13:26 ` Gui-Dong Han
2026-03-06 9:25 ` Oliver Neukum
2026-03-06 10:36 ` Gui-Dong Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8c304be-c061-4656-b7ba-83150c2b8746@suse.com \
--to=oneukum@suse.com \
--cc=baijiaju1990@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanguidong02@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.hodaszi@digi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®