From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 568123909A1 for ; Mon, 9 Mar 2026 10:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773052690; cv=none; b=l1rzOahDPkgsrNBuImEJHzyTZnk+ZEghKKF4N9ABHq7XI4JNcKBs5J8DXVcI6Nd29HiFMSvS3VPIEvBd+KeF5f82P2sswWjmyOjrzAEV0ornbDO4YuZIZxC3zitSuwkb7hNWnV5JnZnS8ijRFUxYPkKJ+sKuz8XhMOET6oZpwMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773052690; c=relaxed/simple; bh=B5DhKyW6XnxmZCh84HVUvLOd+qT97CiYfHEmFjfS27A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ThbmudTZDOjHEg1x6oU+Er2eYLgjMrffWzFIK3QhF3S4sgP94RMyEvrV6O29kXpkyGZACPaQKvuLYHrF2a12kbL9+hng2ShHs+wFUQjRs2y+0NnpPeLoZnssEZkFqnOLIj+KvAyqgoetngjrUGOj6tfv/6Vut4086nTzMhOz5d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V1ONAfeO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OxVgPlhH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V1ONAfeO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OxVgPlhH" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6298Iu2G3464415 for ; Mon, 9 Mar 2026 10:38:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= toGVqDilV/frdxrJNFy8PXgYOTeFfEpHhK5xed2QXzY=; b=V1ONAfeO0HIy+8ss MXtZdC/z6lVQdmGVaOuxXxzRy4DM/VQVnW5KOZeVjqVI4X+ejljjcsZZ2F5A7cgh PaPpAY9B3SBLvabOy6QGflcfkCadEfm3U2Sx8x8l2NhY64bc0ey4zsyAKBAxotBv ElYH07DuRSeFW3yRqcRYBLhP51aYgVjoCFLZn4BU/XupxetsSAXUpyfjU7to0vPM ikFgU8+Lfj0zzQ2GVD2OUT/NOxCIDhzXeH/kSnC5MGy2DmUxW6A1UwjQrHyQL8Xb uaUqRcR0qxFU6g3wzyDw+oPR0MxI+mdk/Q8AUe+8TjEdfNi1s3ECKDZernD40BOB YM9JDA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crcd8cy73-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 10:38:08 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-899ebdd0b08so52622886d6.3 for ; Mon, 09 Mar 2026 03:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773052687; x=1773657487; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=toGVqDilV/frdxrJNFy8PXgYOTeFfEpHhK5xed2QXzY=; b=OxVgPlhH/8T/GWST8GSPpB0CkwpRe9foLDycCXtiZwMZ4NdLW+bedS7ob14+PtMth8 8LN1Eu2oUDdrsrc8zsHBKoe7z90Efyuz8e3AhsRF2zwUhBy2iJMcF6IQxD1RhCbeX47m fiIql7VvNXeszmAvYOfLOpfuNz9OQTejAtHPVzeoPxKjtV7cg1r9AZXdgNM7QHBZvDPE QQUSAF5xEphcj6u0wDmtTEZxXJJ4DSfAJbZxQDtAM/8LohYADmZTG267WRAUAJY63iAd poGhsZbUVbsNx2k2z/KY5kcvnRiyIPhBHGnOeOY/16l1J4fg3IdH0rW6w5ZdZoG8qePs F+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773052687; x=1773657487; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=toGVqDilV/frdxrJNFy8PXgYOTeFfEpHhK5xed2QXzY=; b=fRd4sxqd9QQGLOji4whQR3pJQoLzoLko4lOv/2xFIOdgAVrd5aPHNGmpgYPRzoxlkh Qx8SFq15xk604dbuQgz0re32bZXIcDX+B/An00w2V9iZBxNAq/OG2wuxeZwsR6vPwzUp fRgtUr6lbOD93Kv7EOadCyW4gPMrYTU0SLADmIvQwNfCIlvVMRwq5YmOc6cuQ8E1ZHbX BQEPL3aic94P75pLG+vMPj1ZDqCu8W2Ra00VOLJrF8nat9xPfo0H9P6/L+9Qr8zQusYU te46r20GDlJxcGnlh3ZfvrYmJPN0RD85Fl2v9s0FxX50O/sdQ4DsiIUAu8s7H0Y2RZP6 mtsg== X-Forwarded-Encrypted: i=1; AJvYcCW8VCFQQgSnmpw0E+8PYupkWJCNGW8Om3RWSZGcAqfDZ7gsTj53mFViTvI725jy4A1r2hF35aUzRXLA90c=@vger.kernel.org X-Gm-Message-State: AOJu0YzjwlN38KBOVjsHvIN4yALsiWWiOaMqdnd0iRxjUrR6yvsf+HjL ODheJmIk0ETpCvo3Xuwx7sunXaQSFnd/OY1uMiyynVoBW5lgQwpOLT6RSLj5Uk/xQ60ftS92KwU BBI5JBQNrfNetAUTvwJTXht4rXn35wTKpDrW9WFqz9EBXDQhSA8SS2RlwrtU94M7BGLA= X-Gm-Gg: ATEYQzyCcGeijkE+j9bOGeaecWcrdMWRhN5ZmPloIBVuMKQrLqCzElNj7gTbAaSVkjA 43NPLc22S5VQ/H+scwm4+BFXMINL/1+/rneQPxYC2jQdqYH2rUfyFR/7Kekdb+rf31h1eO9lgG8 aYk0SM69ac1HxpGJaoMUSKYmLqlZdfoSsRbnglb3zOW6VwxUXgWryZAaOWqGQOj8zW8CTf0O2Zk Vo+O87FKErql/M4f7U8ty6jAZLYATaGVsSU5nY0ebh+Iv+whbsdYWgG68TwMVkxM51H+Fm5Ji0V gj98vCcpE/IVNsn+IoEsRJGE1bifWha6cOSp5KoAnAAtX62p751RYxjWrhmkAJx2fu4/iqGpyio 6hUCfltMQOnpKYIjhmdBxnheVxGrwZNbgm6y6/9qubP+pePbNPbC+140qyxpqPCiLgs8lYPyxhs Pc7Ck= X-Received: by 2002:a05:6214:809b:b0:89a:50b4:bc94 with SMTP id 6a1803df08f44-89a50b4bf54mr16300676d6.0.1773052687555; Mon, 09 Mar 2026 03:38:07 -0700 (PDT) X-Received: by 2002:a05:6214:809b:b0:89a:50b4:bc94 with SMTP id 6a1803df08f44-89a50b4bf54mr16300546d6.0.1773052687159; Mon, 09 Mar 2026 03:38:07 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942f139e3dsm353902766b.36.2026.03.09.03.38.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 03:38:06 -0700 (PDT) Message-ID: Date: Mon, 9 Mar 2026 11:38:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: pmic_glink_altmode: Fix SVID=DP && unconnected edge case To: Neil Armstrong , Konrad Dybcio , Bjorn Andersson , Jack Pham Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa References: <20260306-topic-pgaltmode_fixup-v1-1-ec154b2d8e89@oss.qualcomm.com> <7fcbf142-f2c6-4b9e-bb63-befa553aceff@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7fcbf142-f2c6-4b9e-bb63-befa553aceff@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: fAuS23bzlkF-MwN2dFza20wObae4FFB9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA5OCBTYWx0ZWRfX+cmEpnn225Fg vDREI86y6VE4chP4ma24B9ntNPki89r0IociHUhcuCCPuiy91dblT3lpI25oCM+s0b7t5XBzEqj UUPChd0CYtRy7hTtHoEftkFFIwofwGfXoizT1Wi0pXEml33CWK5nO9gGhZ8Es4Jt83VCNbZuecu ImcmLwcgcY6CkvNLw9Cwe8kZW9rX19eRghuANpe0wnSPp6jFGUX7O6KpNGRwZGknGmaQl2kGiIH Qz/uZYV8kyy4bSlrX1+XHU+DisIpWGzkQdycu7dZfxNiQUZrbfGGC0+sJyVnIBcCyFZQ3/Jm+Ph TRnRro5FN0hWJfhM9j0GcK91UI2Zp6WzAMkaGBb/7HwoKFn6bC6eGybu6UnPT9umqRMKol1ImUn uSpz8hjYs+0JWzSceNbqm0obwyw1eV5uZcXFs8VwqlDgByq2ThiUT9K46tP50xJqKSLofTLC0L5 UNwQ2bceGckKd4sb3bg== X-Authority-Analysis: v=2.4 cv=O/w0fR9W c=1 sm=1 tr=0 ts=69aea310 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=vvrTTaMuKQl5oY9UaJYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: fAuS23bzlkF-MwN2dFza20wObae4FFB9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090098 On 3/6/26 3:47 PM, Neil Armstrong wrote: > On 3/6/26 12:20, Konrad Dybcio wrote:[...] > So what's the difference with : > > > if (blah) >     ... > else (alt_port->svid == USB_TYPEC_DP_SID) { >     if (alt_port->mux_ctrl == MUX_CTRL_STATE_NO_CONN) >         pmic_glink_altmode_safe() >     else >         pmic_glink_altmode_enable_dp > } > else (blah) >     ... > else (blah) >     ... > else (alt_port->mux_ctrl == MUX_CTRL_STATE_NO_CONN) >     pmic_glink_altmode_safe() > > > Before, if mux_ctrl was MUX_CTRL_STATE_NO_CONN, it would set to safe mode whatever the svid, > now it's either in the DP case or at the end. > > I don't see the difference here, except if your desire is to ignore > the MUX_CTRL_STATE_NO_CONN for USB_TYPEC_TBT_SID and MUX_CTRL_STATE_TUNNELING. > > But it doesn't match the commit message at all. The difference is the call to drm_aux_hpd_bridge_notify() in the DP case, which isn't very visible in the patch diff. Konrad