mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: praneeth@ti.com, nm@ti.com, vigneshr@ti.com, a-bhatia1@ti.com,
	j-luthra@ti.com, kristo@kernel.org, jyri.sarha@iki.fi,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region
Date: Wed, 14 Feb 2024 11:10:09 +0200	[thread overview]
Message-ID: <f8cc383e-1150-45d2-8325-a8dd69969300@ideasonboard.com> (raw)
In-Reply-To: <20240115125716.560363-2-devarsht@ti.com>

Hi,

On 15/01/2024 14:57, Devarsh Thakkar wrote:
> TI keystone display subsystem present in AM65 and other SoCs such as AM62
> support two separate register spaces namely "common" and "common1" which
> can be used by two separate hosts to program the display controller as
> described in respective Technical Reference Manuals [1].
> 
> The common1 register space has similar set of configuration registers as
> supported in common register space except the global configuration
> registers which are exclusive to common region.
> 
> This adds binding for "common1" register region too as supported by the
> hardware.
> 
> [1]:
> AM62x TRM:
> https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers)
> 
> AM65x TRM:
> https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers)
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
>   .../devicetree/bindings/display/ti/ti,am65x-dss.yaml       | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index b6767ef0d24d..55e3e490d0e6 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> @@ -37,6 +37,7 @@ properties:
>         - description: OVR2 overlay manager for vp2
>         - description: VP1 video port 1
>         - description: VP2 video port 2
> +      - description: common1 DSS register area
>   
>     reg-names:
>       items:
> @@ -47,6 +48,7 @@ properties:
>         - const: ovr2
>         - const: vp1
>         - const: vp2
> +      - const: common1
>   
>     clocks:
>       items:
> @@ -147,9 +149,10 @@ examples:
>                       <0x04a07000 0x1000>, /* ovr1 */
>                       <0x04a08000 0x1000>, /* ovr2 */
>                       <0x04a0a000 0x1000>, /* vp1 */
> -                    <0x04a0b000 0x1000>; /* vp2 */
> +                    <0x04a0b000 0x1000>, /* vp2 */
> +                    <0x04a01000 0x1000>; /* common1 */
>               reg-names = "common", "vidl1", "vid",
> -                    "ovr1", "ovr2", "vp1", "vp2";
> +                    "ovr1", "ovr2", "vp1", "vp2", "common1";
>               ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
>               power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>;
>               clocks =        <&k3_clks 67 1>,

Looks fine to me, I'll apply to drm-misc-next.

  Tomi


  parent reply	other threads:[~2024-02-14  9:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 12:57 [PATCH 0/2] Add common1 register space for TI Keystone displays Devarsh Thakkar
2024-01-15 12:57 ` [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region Devarsh Thakkar
2024-01-15 16:17   ` Conor Dooley
2024-01-16  9:13     ` Devarsh Thakkar
2024-01-16  9:36       ` Conor Dooley
2024-02-14  9:10   ` Tomi Valkeinen [this message]
2024-02-14  9:23     ` Tomi Valkeinen
2024-02-14 11:23       ` Devarsh Thakkar
2024-01-15 12:57 ` [DO NOT MERGE PATCH 2/2] arm64: dts: ti: Add common1 register space for AM62x and AM65x SoCs Devarsh Thakkar
2024-01-15 16:14   ` Conor Dooley
2024-01-16  9:18     ` Devarsh Thakkar
2024-01-16  9:38       ` Conor Dooley
2024-01-16 14:05       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8cc383e-1150-45d2-8325-a8dd69969300@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=a-bhatia1@ti.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j-luthra@ti.com \
    --cc=jyri.sarha@iki.fi \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®