From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0ED12D63E2 for ; Mon, 8 Dec 2025 15:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765208697; cv=none; b=QuaLBcf3vkD7YNFx4DtaMCKjk9u34shrleDV5h5wI3Fp+VNvPN1O9ZFeXCMZfy/99tjATfnOKPtxjES4itmjB2HtBKh7JMa6/nq6MekdGX/U3JURc9BbGaJosTo1st6NG05Jl9lotmT6X90EVXZEbqN9vDMFf4/SmpXeX0iGha8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765208697; c=relaxed/simple; bh=z6fXEQqvGKi4O2zkZhxy65l+Ky23ibWbRx+dFpzFMb4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q5o/ChmNzB3W6R5nypW5f8+EhTjrb5kCJkRrwh8dyZn133d5VTXhuaK/RnqZuVUJ+9FaOtxQyxn7L+9ZMjQojgEAVLt4a0g7cgxAoWqWqmiDsYwQ9z/B7CjZH20AqBvTtvzkMF+0NHlwCtWGfcQtejVipjek29CxZPEqKgoqaFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hZMEdh7J; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hZMEdh7J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765208694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ZA8EtJ/Yb3hDRtk61pdFksnnDW88iHKAyV8Vf/m1G0=; b=hZMEdh7JeC2yGOR8gelUNXqUcCrOQre/qo1MsdtVT+ASdCxi/beKwM2clf+mSRcFU7BXKE MBt7hUaoPcyNvYybNFo1xJRYZOrlmrk/QXspghcgLDM9O95FIQPprAQ+Wd045pg5Jhz3cJ dMprupf4r0dqUJHSYp6zk7kqFdYZ3A0= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-1s479KrIPi-HBw-Q-AXaMQ-1; Mon, 08 Dec 2025 10:44:53 -0500 X-MC-Unique: 1s479KrIPi-HBw-Q-AXaMQ-1 X-Mimecast-MFC-AGG-ID: 1s479KrIPi-HBw-Q-AXaMQ_1765208692 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b9b9e8b0812so7143207a12.0 for ; Mon, 08 Dec 2025 07:44:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765208692; x=1765813492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+ZA8EtJ/Yb3hDRtk61pdFksnnDW88iHKAyV8Vf/m1G0=; b=HTb2A2UMVfDc6LZp04pyRoIY5K2pCkFmV7CDtosFsCHEbiqjrDsBQsABbuklyrSjPK hOqhWbxCj/VvSlVwfGqQgfu/oIDblU73ume05AF+08T072KgZ37ZkVxv+WgyQefQv4kI 3jVhi44LM9LzIshMFJTZhDcE6Wnc5Qf1+j5GWXej8f4lvojQuTa1BppgwN5D77F7YyEy xCkvDE2iHTIvI6uBD/ou1GbGhVSIm52ZDwoR6xC8DzPLTViuKMuWfPCcI94ulJAaG7+1 VWDo0cO8lMJ5WXeLJYezoY3mmDHKnzvSK8WClhnNCX6Kdapm3bJ4fi64aVLz5lnXAlcW sBVQ== X-Forwarded-Encrypted: i=1; AJvYcCWEguh+iBnji6V/NHMS2VciW20B+ghqqVK3jrJM3hTHo6m1EdCYs/tssy+QFz6ynOBU9z4heWTCg7PlzvE=@vger.kernel.org X-Gm-Message-State: AOJu0YxfToyw+Ci9iChJn+Es8MqwgLI7W0pnrvXKafLIbEh8EnnojD/9 h34qKlM5CElNKFkbakFhcQKGohl4J1iITxWHLPl1WfU9SYzFBZj563IpjbdTVJG4OVbFbd9WZlC kG7+V7argikTARu3dg9VQOc3a4cN0XT7OoiagdtPXDUmf4gM7YrhHAtjaJBqcN9eTYQ== X-Gm-Gg: ASbGncsKnNF9ZtrjPYYuKSEMvjGjs3fUqXQepOwC7iVK/2fyeAyGzqRBnHE5VoBzfR3 jjN+hjsgnfy4qvQf+Ro3UDsT5VCtiGs2Vbw5Tueg2wUQZC2xzKdB+5wbIPQ0hG2Sna10O1MWWzZ jrgDUHPwUJ2MFYJfNhA2cR2GjY+zZbakmotL23uqAeOdnfr7tPGdZDAVL/BCq9b5VjpeVx+VueC NTqMXhj3/H7nsuFWeJtwxcwjPp8Vo9eCFvN4xgmenI0sPfhF+vIbSdigm/sbWf1Ti/4lirh2ZOU cuNPOSqLre4E9dejrJH0oZwBD0JtWBS8BCW/nf8z7ROMpyNu48e7PXcTrRYwPLXUepps+JykQpm Duocf5NQ+ooM/cCFdwQfffnKmwzjaeIhchV2LJ39FZILInvBNvt6McZm3sKaemgITZYtxiBffyg == X-Received: by 2002:a05:7022:ec0c:b0:11d:f44d:1863 with SMTP id a92af1059eb24-11e0326b11fmr5785266c88.11.1765208692255; Mon, 08 Dec 2025 07:44:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAjO/iQcpglYWmyAUY5NhlLp8TjzTsbzOXCBjpFZBwT6DwAEkwKSVISxY8b2i+m6RPHCfxhQ== X-Received: by 2002:a05:7022:ec0c:b0:11d:f44d:1863 with SMTP id a92af1059eb24-11e0326b11fmr5785242c88.11.1765208691771; Mon, 08 Dec 2025 07:44:51 -0800 (PST) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-48-76-65-77-217.dsl.bell.ca. [76.65.77.217]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df7552defsm56860378c88.2.2025.12.08.07.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 07:44:51 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2025 10:44:45 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] selftests/mm: fix va_high_addr_switch.sh return value To: Chunyu Hu , akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org, linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com References: <20251207122239.3228920-1-chuhu@redhat.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20251207122239.3228920-1-chuhu@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-12-07 07:22, Chunyu Hu wrote: > Patch series "Fix va_high_addr_switch.sh test failure - again", v1. > > There are two issues exist for the va_high_addr_switch test. One issue is > the test return value is ignored in va_high_addr_switch.sh. The second is > the va_high_addr_switch requires 6 hugepages but it requires 5. > > Besides that, the nr_hugepages setup in run_vmtests.sh for arm64 can be > done in va_high_addr_switch.sh too. > > This patch: (of 3) > > The return value should be return value of va_high_addr_switch, otherwise > a test failure would be silently ignored. > > Fixes: d9d957bd7b61 ("selftests/mm: alloc hugepages in va_high_addr_switch test") > CC: Luiz Capitulino > Signed-off-by: Chunyu Hu This fix is good, but there are two additional issues that need fixing (maybe in separate patches): 1. In main() we do: """ ret = run_test(testcases, sz_testcases); if (argc == 2 && !strcmp(argv[1], "--run-hugetlb")) ret = run_test(hugetlb_testcases, sz_hugetlb_testcases); """ The second run_test() overwrites the return code of the first one, so if the first fails and the second one succeeds, the test will report success. 2. The following comment in va_high_addr_switch.sh is wrong in two counts: there's an eligibility check for powerpc64 and the test doesn't reject other architectures as it runs on arm64 as well. """ # The test supports x86_64 and powerpc64. We currently have no useful # eligibility check for powerpc64, and the test itself will reject other # architectures. """ For this fix: Reviewed-by: Luiz Capitulino > --- > tools/testing/selftests/mm/va_high_addr_switch.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > index a7d4b02b21dd..f89fe078a8e6 100755 > --- a/tools/testing/selftests/mm/va_high_addr_switch.sh > +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh > @@ -114,4 +114,6 @@ save_nr_hugepages > # 4 keep_mapped pages, and one for tmp usage > setup_nr_hugepages 5 > ./va_high_addr_switch --run-hugetlb > +retcode=$? > restore_nr_hugepages > +exit $retcode