From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB39C4338F for ; Mon, 2 Aug 2021 07:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79D9960FC1 for ; Mon, 2 Aug 2021 07:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232587AbhHBH6s (ORCPT ); Mon, 2 Aug 2021 03:58:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21336 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232537AbhHBH6q (ORCPT ); Mon, 2 Aug 2021 03:58:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627891117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lIN/txXSywnk/cxKQuSc+8OainBGlz8WJcUV6gIdz9Q=; b=A6gT3VpEEt2py+wYcF2WWne54o6T4Py1MgjNv325KTB4zwEso8F++eSrWXuOUrbYrvHhNk Pp2r+IWKT/Rm6qsNbia2NXS5pCToUEhx1FbNKgAE9pCLN+E5NKYKD5rsUADitpmqaLDrzz Y02VONpZZ0js+g6Hp/5l9WANfKIOaQA= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-i40sSfiVPQCxhP-lExqbUA-1; Mon, 02 Aug 2021 03:58:35 -0400 X-MC-Unique: i40sSfiVPQCxhP-lExqbUA-1 Received: by mail-ej1-f70.google.com with SMTP id lu19-20020a170906fad3b029058768348f55so4361614ejb.12 for ; Mon, 02 Aug 2021 00:58:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lIN/txXSywnk/cxKQuSc+8OainBGlz8WJcUV6gIdz9Q=; b=tNhvBXNkBNq/wBZmk4yjxmb//t1u1EvAzgdOBjvIusmy6K+iTl29/uA3g3yiCguIeA xXCHBRHE35cru3UN01GSHWmIppxIYPsyeK6v913EcbwQXD3j2QaKsxRLxul/8kNC74iv I/9uNExk79T4ZjpAx97DcQzssUaQTkWrk2QXz+l4gCfc7mRurMqGN8LS1hS5HGGnb0dL /bCQsnV47GVoS5Cr5ClmPZKu+IFZKt4SJRTzqtIYF8tcHpRpuaJz5TfEiJxXya+zeAAY rvg6+EOcLBjDUJ6+WNXuzOxcbCvFXeHIqlDR78WJry4mGy2TRWNJH+ZHiHrVryXGtNb1 r4Pw== X-Gm-Message-State: AOAM530qzyVScBtMH/XE8Ft2II1pRMhhJWMXlJDyBfSpeKEHYugQpUyM pmrXaHax8KKip1pYKbcg3nb55DeR0W7Yw4G6Ub17TiZmdDBZQBm+lJ3ist+gdFXi8RxQVIi+Xg+ GTQkKkXwNK5wbOvLOQNeIQLaG X-Received: by 2002:a17:906:c08e:: with SMTP id f14mr14190024ejz.380.1627891114662; Mon, 02 Aug 2021 00:58:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwd749wQ0qyrwQfxK6tvHsTGMJytAXV8uGx3Eoco/0erBXuJs8FPXLMIqaMrJ9W6ubS75TOkg== X-Received: by 2002:a17:906:c08e:: with SMTP id f14mr14190020ejz.380.1627891114560; Mon, 02 Aug 2021 00:58:34 -0700 (PDT) Received: from x1.bristot.me (host-95-239-202-226.retail.telecomitalia.it. [95.239.202.226]) by smtp.gmail.com with ESMTPSA id c6sm4129953eje.105.2021.08.02.00.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 00:58:34 -0700 (PDT) Subject: Re: [PATCH] trace: eradicate noisy warning in trace_osnoise.c To: Randy Dunlap , Steven Rostedt Cc: linux-kernel@vger.kernel.org, Matthew Wilcox , Ingo Molnar References: <20210731000055.28876-1-rdunlap@infradead.org> <20210730204050.46975ae2@oasis.local.home> From: Daniel Bristot de Oliveira Message-ID: Date: Mon, 2 Aug 2021 09:58:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/31/21 3:11 AM, Randy Dunlap wrote: > On 7/30/21 5:40 PM, Steven Rostedt wrote: >> On Fri, 30 Jul 2021 17:00:55 -0700 >> Randy Dunlap wrote: >> >>> OK, I'm officially tired of this noise warning coming from >>> trace_osnoise.c, so shut it up. Also, adding new warnings is not OK. >> I agree adding "new warnings" is not OK, but this is a stupid warning. >> >>> ../kernel/trace/trace_osnoise.c: In function ‘start_kthread’: >>> ../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain] >>> void *main = osnoise_main; >>> ^~~~ >>> >>> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations") >>> Signed-off-by: Randy Dunlap >>> Suggested-by: Matthew Wilcox >>> Cc: Steven Rostedt >>> Cc: Ingo Molnar >>> Cc: Daniel Bristot de Oliveira >>> --- >>> kernel/trace/Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> --- mmotm-2021-0728-1824.orig/kernel/trace/Makefile >>> +++ mmotm-2021-0728-1824/kernel/trace/Makefile >>> @@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src) >>> CFLAGS_trace_benchmark.o := -I$(src) >>> CFLAGS_trace_events_filter.o := -I$(src) >>> >>> +CFLAGS_trace_osnoise.o := -Wno-main >> Why just add it here. It's a silly warning to have for the kernel at >> all. Should this not be added in a more global place? > I don't know of any other places that name something 'main' when it is > not a main() function. > I would say that we either use -Wno-main for the entire kernel or rename the main variable to tracer_main.... -- Daniel